From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E684C34026 for ; Tue, 18 Feb 2020 15:40:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C31122527 for ; Tue, 18 Feb 2020 15:40:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=poorly.run header.i=@poorly.run header.b="WeWtpm9k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C31122527 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=poorly.run Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A932A89E59; Tue, 18 Feb 2020 15:40:57 +0000 (UTC) Received: from mail-yw1-xc44.google.com (mail-yw1-xc44.google.com [IPv6:2607:f8b0:4864:20::c44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 23D6E89E59 for ; Tue, 18 Feb 2020 15:40:57 +0000 (UTC) Received: by mail-yw1-xc44.google.com with SMTP id a125so9538849ywe.12 for ; Tue, 18 Feb 2020 07:40:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=I248Y/8CNKtvbdDU65iHEJA0YHjR0t7vqNEgoLY+B1s=; b=WeWtpm9kTJSBEPiyNFaeNwC6F2RaibZ+MfkHsBsyh/MUGthW1iNE27yIn0zCYP6FKC weYdD1htj9X6P9gIozWkPlgFWWsW1/WkrZUQyVk2x6uxHkCH8DxIIifJDMBDjR5tgIAk NMhMmrUnZy4e7AE2aBPjk4Yyrq/5RURaIdyhluDNbZPvNA4twGCjTxTOmCipCT/IV87v H36vcaZ2hgqT3OIeUIn+uDJjITwcpjhHiNBmnDb7y2IEqUT/710AZ0S4ducY7Dmmn0Mn esKqNcYSFx3A5NtHV3U1m/53qxGIa/ZJfakWndAW77WsDqq7TVWIxmELKBmFFplMzAy6 ZvMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=I248Y/8CNKtvbdDU65iHEJA0YHjR0t7vqNEgoLY+B1s=; b=KqRbqVM5KG/1oYgEaKjKMJGNvCB39bCTiC4P74DKpH6cmr3c770tCv5Y/dJ+ZVlC/b nIj5NU8OYSqr9lCWVNbqYB1YaKJ+UTYTbHNvs9O2MCH66Iv+LPByE4NTVNlOssK0ux/W oJHe/uPzObz5pYy8vdJeWeSZx4Wb6Pe+wEBlRfKx4+5bejWg+HTQA08jvLtl/cbLgV3l AY3xjIAJ2mbshiGypkT/ejPd2h9pvZkl6g6htSi7bueeyPvsxMeIvutBr3rmTZSD8gC9 Wr/2KVk6Odwy37DBF0i7jpVl1q/OsG08ZhUz7SwzduvX/QBtpa88WZ3SYejCvyzju2J0 eFvg== X-Gm-Message-State: APjAAAVuSciXcTzI2yHlljFr+3zTktNSCm532uaJB45XjztVSX8+L3OO V7n2xPwjqzIPTLmV3/FANsCkNw== X-Google-Smtp-Source: APXvYqx5jg70pCttNc9cCAh7/sTI3pZN/NBBjZ4mQUqhEvJ6rm0TvTO0+Gz6uH/X7McaVG+jqa3PUg== X-Received: by 2002:a81:444:: with SMTP id 65mr16442467ywe.171.1582040455404; Tue, 18 Feb 2020 07:40:55 -0800 (PST) Received: from localhost ([2620:0:1013:11:1e1:4760:6ce4:fc64]) by smtp.gmail.com with ESMTPSA id p2sm1650587ywd.58.2020.02.18.07.40.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 07:40:54 -0800 (PST) Date: Tue, 18 Feb 2020 10:40:53 -0500 From: Sean Paul To: Ramalingam C Message-ID: <20200218154053.GB253734@art_vandelay> References: <20200212102942.26568-1-ramalingam.c@intel.com> <20200212102942.26568-5-ramalingam.c@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200212102942.26568-5-ramalingam.c@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH v2 4/5] drm/i915: dont retry stream management at seq_num_m roll over X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx , dri-devel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Feb 12, 2020 at 03:59:41PM +0530, Ramalingam C wrote: > When roll over detected for seq_num_m, we shouldn't continue with stream > management with rolled over value. > > So we are terminating the stream management retry, on roll over of the > seq_num_m. > > v2: > using drm_dbg_kms instead of DRM_DEBUG_KMS [Anshuman] > v3: > dev_priv is used as i915 [JaniN] > > Signed-off-by: Ramalingam C > --- > drivers/gpu/drm/i915/display/intel_hdcp.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c > index b24d12efae0a..b35f50d4a0e9 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdcp.c > +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c > @@ -1419,11 +1419,6 @@ int _hdcp2_propagate_stream_management_info(struct intel_connector *connector) > > err_exit: > hdcp->seq_num_m++; > - if (hdcp->seq_num_m > HDCP_2_2_SEQ_NUM_MAX) { > - DRM_DEBUG_KMS("seq_num_m roll over.\n"); > - ret = -1; > - } > - > return ret; > } > > @@ -1618,8 +1613,11 @@ hdcp2_propagate_stream_management_info(struct intel_connector *connector) > > for (i = 0; i < tries; i++) { > ret = _hdcp2_propagate_stream_management_info(connector); > - if (!ret) > + if (!ret || connector->hdcp.seq_num_m > HDCP_2_2_SEQ_NUM_MAX) { > + if (connector->hdcp.seq_num_m > HDCP_2_2_SEQ_NUM_MAX) > + drm_dbg_kms(&i915->drm, "seq_num_m roll over.\n"); > break; > + } IMO it doesn't read quite right bunching up a success outcome and a failure, and it's actually less code (character-wise) to do: if (connector->hdcp.seq_num_m > HDCP_2_2_SEQ_NUM_MAX) { drm_dbg_kms(&i915->drm, "seq_num_m roll over.\n"); break; } else if (!ret) { break; } feel free to add Reviewed-by: Sean Paul with this addressed > > drm_dbg_kms(&i915->drm, > "HDCP2 stream management %d of %d Failed.(%d)\n", > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx