From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3B9CC3F2CD for ; Tue, 3 Mar 2020 07:49:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9D8E215A4 for ; Tue, 3 Mar 2020 07:49:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VAkeHOyH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9D8E215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5DDAB6E4CA; Tue, 3 Mar 2020 07:49:42 +0000 (UTC) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id A391B6E4CA for ; Tue, 3 Mar 2020 07:49:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583221779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gT2IDVutbKG4C1t6Thrf9XmPeO1zrVFNtS3owfJZNmk=; b=VAkeHOyHgd9TFA313fPhn/5p6BY5WTrB597/Vr2W+hAOBcO/LlDj7sG+ujjJ9JcL1HCZva CkyZ85bxL8WJ6ahrton2H2FZsIlmCSEXpQbY2UH22QlXee5yQspKKkgy2k3LlixWY9zvc3 IoEitmZ0Gg/pGJSeHdj64loe1EDix5s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-493-W6URLR4jMSmTNOUswYpKBw-1; Tue, 03 Mar 2020 02:49:37 -0500 X-MC-Unique: W6URLR4jMSmTNOUswYpKBw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0F91E801A08; Tue, 3 Mar 2020 07:49:36 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-150.ams2.redhat.com [10.36.116.150]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6DEF25D9C9; Tue, 3 Mar 2020 07:49:35 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id A9F5017449; Tue, 3 Mar 2020 08:49:34 +0100 (CET) Date: Tue, 3 Mar 2020 08:49:34 +0100 From: Gerd Hoffmann To: Daniel Vetter Message-ID: <20200303074934.vlqxiye7lydnoykd@sirius.home.kraxel.org> References: <20200302222631.3861340-1-daniel.vetter@ffwll.ch> <20200302222631.3861340-10-daniel.vetter@ffwll.ch> MIME-Version: 1.0 In-Reply-To: <20200302222631.3861340-10-daniel.vetter@ffwll.ch> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Subject: Re: [Intel-gfx] [PATCH 09/51] drm/cirrus: Use drmm_add_final_kfree X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , DRI Development , virtualization@lists.linux-foundation.org, Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Thomas Zimmermann , Dave Airlie , Daniel Vetter , Sam Ravnborg , Linus Walleij Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" > @@ -575,9 +574,12 @@ static int cirrus_pci_probe(struct pci_dev *pdev, > > dev = &cirrus->dev; > ret = drm_dev_init(dev, &cirrus_driver, &pdev->dev); > - if (ret) > - goto err_free_cirrus; > + if (ret) { > + kfree(cirrus); > + goto err_pci_release; > + } > dev->dev_private = cirrus; > + drmm_add_final_kfree(dev, cirrus); That doesn't look like an error path improvement. With patch #30 applied it'll looks alot better though. So maybe squash the patches? In any case: Acked-by: Gerd Hoffmann cheers, Gerd _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx