From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 04/12] dma-buf: Prettify typecasts for dma-fence-chain
Date: Thu, 26 Mar 2020 14:51:51 +0000 [thread overview]
Message-ID: <20200326145159.27431-4-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20200326145159.27431-1-chris@chris-wilson.co.uk>
Inside dma-fence-chain, we use a cmpxchg on an RCU-protected pointer. To
avoid the sparse warning for using the RCU pointer directly, we have to
cast away the __rcu annotation. However, we don't need to use void*
everywhere and can stick to the dma_fence*.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
drivers/dma-buf/dma-fence-chain.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dma-buf/dma-fence-chain.c b/drivers/dma-buf/dma-fence-chain.c
index 44a741677d25..3d123502ff12 100644
--- a/drivers/dma-buf/dma-fence-chain.c
+++ b/drivers/dma-buf/dma-fence-chain.c
@@ -62,7 +62,8 @@ struct dma_fence *dma_fence_chain_walk(struct dma_fence *fence)
replacement = NULL;
}
- tmp = cmpxchg((void **)&chain->prev, (void *)prev, (void *)replacement);
+ tmp = cmpxchg((struct dma_fence __force **)&chain->prev,
+ prev, replacement);
if (tmp == prev)
dma_fence_put(tmp);
else
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-26 14:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 14:51 [Intel-gfx] [PATCH 01/12] drm/i915/selftests: Add request throughput measurement to perf Chris Wilson
2020-03-26 14:51 ` [Intel-gfx] [PATCH 02/12] drm/i915: Wrap i915_active in a simple kreffed struct Chris Wilson
2020-03-26 14:51 ` [Intel-gfx] [PATCH 03/12] drm/i915/perf: Schedule oa_config after modifying the contexts Chris Wilson
2020-03-26 14:51 ` Chris Wilson [this message]
2020-03-26 14:51 ` [Intel-gfx] [PATCH 05/12] dma-buf: Report signaled links inside dma-fence-chain Chris Wilson
2020-03-26 14:51 ` [Intel-gfx] [PATCH 06/12] dma-buf: Exercise dma-fence-chain under selftests Chris Wilson
2020-03-26 14:51 ` [Intel-gfx] [PATCH 07/12] dma-buf: Proxy fence, an unsignaled fence placeholder Chris Wilson
2020-03-26 14:51 ` [Intel-gfx] [PATCH 08/12] drm/syncobj: Allow use of dma-fence-proxy Chris Wilson
2020-03-26 14:51 ` [Intel-gfx] [PATCH 09/12] drm/i915/gem: Teach execbuf how to wait on future syncobj Chris Wilson
2020-03-26 14:51 ` [Intel-gfx] [PATCH 10/12] drm/i915/gem: Allow combining submit-fences with syncobj Chris Wilson
2020-03-26 14:51 ` [Intel-gfx] [PATCH 11/12] drm/i915/gt: Yield the timeslice if caught waiting on a user semaphore Chris Wilson
2020-03-26 14:51 ` [Intel-gfx] [PATCH 12/12] drm/i915/gt: Declare when we enabled timeslicing Chris Wilson
2020-03-26 19:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/12] drm/i915/selftests: Add request throughput measurement to perf Patchwork
2020-03-26 20:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-03-23 13:43 [Intel-gfx] [PATCH 01/12] " Chris Wilson
2020-03-23 13:43 ` [Intel-gfx] [PATCH 04/12] dma-buf: Prettify typecasts for dma-fence-chain Chris Wilson
2020-03-17 12:27 [Intel-gfx] [PATCH 01/12] drm/i915/selftests: Add request throughput measurement to perf Chris Wilson
2020-03-17 12:27 ` [Intel-gfx] [PATCH 04/12] dma-buf: Prettify typecasts for dma-fence-chain Chris Wilson
2020-03-11 13:30 [Intel-gfx] [PATCH 01/12] drm/i915/selftests: Add request throughput measurement to perf Chris Wilson
2020-03-11 13:30 ` [Intel-gfx] [PATCH 04/12] dma-buf: Prettify typecasts for dma-fence-chain Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326145159.27431-4-chris@chris-wilson.co.uk \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).