From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: [Intel-gfx] [PATCH] drm/i915/selftests: Keep rps pinned during time critical tests
Date: Fri, 15 May 2020 20:46:55 +0100 [thread overview]
Message-ID: <20200515194655.3611-1-chris@chris-wilson.co.uk> (raw)
The timeslice queue tries to complete a round-robin discovery of a deep
and pathological semaphore chain within a certain time limit. It helps
if we can keep RPS pinned during this so that we do not waste time on a
slow GPU.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gt/selftest_lrc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index 824f99c4cc7c..9edb0eb02e90 100644
--- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
+++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
@@ -1197,6 +1197,8 @@ static int live_timeslice_queue(void *arg)
if (err)
goto err_pin;
+ atomic_inc(>->rps.num_waiters); /* keep rps pinned */
+ intel_gt_pm_get(gt);
for_each_engine(engine, gt, id) {
struct i915_sched_attr attr = {
.priority = I915_USER_PRIORITY(I915_PRIORITY_MAX),
@@ -1288,6 +1290,8 @@ static int live_timeslice_queue(void *arg)
if (err)
break;
}
+ intel_gt_pm_put(gt);
+ atomic_dec(>->rps.num_waiters);
err_pin:
i915_vma_unpin(vma);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2020-05-15 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 19:46 Chris Wilson [this message]
2020-05-15 20:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Keep rps pinned during time critical tests Patchwork
2020-05-16 2:17 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515194655.3611-1-chris@chris-wilson.co.uk \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).