intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Liviu Dudau <liviu.dudau@arm.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 2/3] drm/malidp: Don't call drm_crtc_vblank_off on unbind
Date: Tue, 2 Jun 2020 13:59:48 +0100	[thread overview]
Message-ID: <20200602125948.GQ159988@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200602095140.36678-2-daniel.vetter@ffwll.ch>

Hi Daniel,

On Tue, Jun 02, 2020 at 11:51:39AM +0200, Daniel Vetter wrote:
> This is already done as part of the drm_atomic_helper_shutdown(),
> and in that case only for the crtc which are actually on.
>

I'm pretty sure that it didn't used to be the case when I wrote the code
and I was hitting warnings from 84014b0a39eef6df ("drm/atomic-helper: check that
drivers call drm_crtc_vblank_off"), but I'm happy that things have now been fixed.

> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>

Acked-by: Liviu Dudau <liviu.dudau@arm.com>

Best regards,
Liviu

> Cc: Brian Starkey <brian.starkey@arm.com>
> Cc:
> ---
>  drivers/gpu/drm/arm/malidp_drv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> index 02904392e370..db6ba5c78042 100644
> --- a/drivers/gpu/drm/arm/malidp_drv.c
> +++ b/drivers/gpu/drm/arm/malidp_drv.c
> @@ -928,7 +928,6 @@ static void malidp_unbind(struct device *dev)
>  	drm_dev_unregister(drm);
>  	drm_kms_helper_poll_fini(drm);
>  	pm_runtime_get_sync(dev);
> -	drm_crtc_vblank_off(&malidp->crtc);
>  	malidp_se_irq_fini(hwdev);
>  	malidp_de_irq_fini(hwdev);
>  	drm->irq_enabled = false;
> -- 
> 2.26.2
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-06-02 12:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-02  9:51 [Intel-gfx] [PATCH 1/3] drm/atomic-helper: reset vblank on crtc reset Daniel Vetter
2020-06-02  9:51 ` [Intel-gfx] [PATCH 2/3] drm/malidp: Don't call drm_crtc_vblank_off on unbind Daniel Vetter
2020-06-02  9:55   ` [Intel-gfx] [PATCH] " Daniel Vetter
2020-06-02 13:02     ` Liviu Dudau
2020-06-02 12:59   ` Liviu Dudau [this message]
2020-06-02  9:51 ` [Intel-gfx] [PATCH 3/3] drm/hdlcd: " Daniel Vetter
2020-06-02 13:00   ` Liviu Dudau
2020-06-03 13:46     ` Daniel Vetter
2020-06-02 12:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/atomic-helper: reset vblank on crtc reset (rev2) Patchwork
2020-06-02 12:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-06-02 19:44 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-06-03  0:19 ` [Intel-gfx] [PATCH 1/3] drm/atomic-helper: reset vblank on crtc reset Laurent Pinchart
2020-06-03  7:55   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200602125948.GQ159988@e110455-lin.cambridge.arm.com \
    --to=liviu.dudau@arm.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).