From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E0DEC433E7 for ; Tue, 14 Jul 2020 14:56:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64075223B0 for ; Tue, 14 Jul 2020 14:56:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gBNtZsvr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64075223B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 221B96E072; Tue, 14 Jul 2020 14:56:03 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 15FD96E03F; Tue, 14 Jul 2020 14:56:02 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id j4so22225153wrp.10; Tue, 14 Jul 2020 07:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=RqFq1NaLVNBIbToXT9qdq38OqjbXpvM12of+sWUmP7I=; b=gBNtZsvrx4arqCLByJfpm1CJFbuHVxJkcIsiXkaN7kRCcGVANFq/R31nplss35s0tX YTSXHDr+fRVAFlZZKe4L+6vdczqhmsJKNGVVd1w9h8A1olPpacZTWcY8QTJlSXF5iFT8 c9IZhwt2CxBJ+jkgDhPB/Doo6jLEJRw7u/o4/l1tc5/NqHywdJpx/lT+a+j+9LnqAr78 02UKzZ89srNbdrQ7Do/+qDKiT9Ne5v5tsnXgh3/hd0k8Er6YdIxnj00PKqpVxLrfZSu2 3ZGQ17bn6SKQrotc040woUNPtsjKeo7NjI9D2HklW3Ax7LTAG4NidhX+gluf2tQFmqjR YkIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RqFq1NaLVNBIbToXT9qdq38OqjbXpvM12of+sWUmP7I=; b=A0A+q33BTER6O1oaBanAZg3J1eBUccLURRJeDYR6ie6YB26uBngLg1OhpkOugoZ54S GVgAeRoIzmZ6uVy2adG4dQpqv/Rl82R3TELJOQNVsiSbcPm+XW6BkxIzlYBz7rmJRPkP Z6k6JAtRYVFA6rPU3NDN6H7KkRpI1uuUcVesjJgR/jBgnLdUVYLdXOeRmAObNhLZiL9R 9Tsgn/oqw2XbVUZbbWgzfw9J+tbvv/yEwGSGWrDgR8NA1sOr3TH2BPvtQGS9AxrEt9Nb whmWPXsbFllzL5cDRIZkwrBdc0hUtiATuLkujd32y4TIZiXAUo0py32lUKbFTJOLv//I sdHQ== X-Gm-Message-State: AOAM531xW1ekEVv7NBV1OaKJuzVNuEH1z35BYiZuInaMBXj5noUr42+i 4SJDIXRVQmtLGpInSB0ArUE= X-Google-Smtp-Source: ABdhPJwQyYnurrKzmkh5mIhbZp11kOQERD+D2QEXfAJk6Km1H0q74KOlTFspmFoiBPP7G77IvTX4fg== X-Received: by 2002:adf:e38d:: with SMTP id e13mr6211703wrm.304.1594738560705; Tue, 14 Jul 2020 07:56:00 -0700 (PDT) Received: from smtp.gmail.com (a95-92-181-29.cpe.netcabo.pt. [95.92.181.29]) by smtp.gmail.com with ESMTPSA id k131sm4935268wmb.36.2020.07.14.07.55.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:56:00 -0700 (PDT) Date: Tue, 14 Jul 2020 11:55:53 -0300 From: Melissa Wen To: Daniel Vetter Message-ID: <20200714145553.zetjvbewixnf2rla@smtp.gmail.com> References: <20200707201229.472834-1-daniel.vetter@ffwll.ch> <20200707201229.472834-5-daniel.vetter@ffwll.ch> <20200712222716.4rhvj7hryiecjthv@smtp.gmail.com> <20200714095717.njwk2u4tkgro54jn@smtp.gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH 04/25] drm/vkms: Annotate vblank timer X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haneen Mohammed , Rodrigo Siqueira , linux-rdma , Intel Graphics Development , DRI Development , Chris Wilson , "moderated list:DMA BUFFER SHARING FRAMEWORK" , amd-gfx list , Daniel Vetter , Trevor Woerner , Christian =?utf-8?B?S8O2bmln?= , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi, On 07/14, Daniel Vetter wrote: > On Tue, Jul 14, 2020 at 11:57 AM Melissa Wen wrot= e: > > > > On 07/12, Rodrigo Siqueira wrote: > > > Hi, > > > > > > Everything looks fine to me, I just noticed that the amdgpu patches d= id > > > not apply smoothly, however it was trivial to fix the issues. > > > > > > Reviewed-by: Rodrigo Siqueira > > > > > > Melissa, > > > Since you are using vkms regularly, could you test this patch and rev= iew > > > it? Remember to add your Tested-by when you finish. > > > > > Hi, > > > > I've applied the patch series, ran some tests on vkms, and found no > > issues. I mean, things have remained stable. > > > > Tested-by: Melissa Wen > = > Did you test with CONFIG_PROVE_LOCKING enabled in the kernel .config? > Without that enabled, there's not really any change here, but with > that enabled there might be some lockdep splats in dmesg indicating a > problem. > Even with the lock debugging config enabled, no new issue arose in dmesg during my tests using vkms. Melissa > Thanks, Daniel > > > > > Thanks > > > > > > On 07/07, Daniel Vetter wrote: > > > > This is needed to signal the fences from page flips, annotate it > > > > accordingly. We need to annotate entire timer callback since if we = get > > > > stuck anywhere in there, then the timer stops, and hence fences sto= p. > > > > Just annotating the top part that does the vblank handling isn't > > > > enough. > > > > > > > > Cc: linux-media@vger.kernel.org > > > > Cc: linaro-mm-sig@lists.linaro.org > > > > Cc: linux-rdma@vger.kernel.org > > > > Cc: amd-gfx@lists.freedesktop.org > > > > Cc: intel-gfx@lists.freedesktop.org > > > > Cc: Chris Wilson > > > > Cc: Maarten Lankhorst > > > > Cc: Christian K=F6nig > > > > Signed-off-by: Daniel Vetter > > > > Cc: Rodrigo Siqueira > > > > Cc: Haneen Mohammed > > > > Cc: Daniel Vetter > > > > --- > > > > drivers/gpu/drm/vkms/vkms_crtc.c | 8 +++++++- > > > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkm= s/vkms_crtc.c > > > > index ac85e17428f8..a53a40848a72 100644 > > > > --- a/drivers/gpu/drm/vkms/vkms_crtc.c > > > > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c > > > > @@ -1,5 +1,7 @@ > > > > // SPDX-License-Identifier: GPL-2.0+ > > > > > > > > +#include > > > > + > > > > #include > > > > #include > > > > #include > > > > @@ -14,7 +16,9 @@ static enum hrtimer_restart vkms_vblank_simulate(= struct hrtimer *timer) > > > > struct drm_crtc *crtc =3D &output->crtc; > > > > struct vkms_crtc_state *state; > > > > u64 ret_overrun; > > > > - bool ret; > > > > + bool ret, fence_cookie; > > > > + > > > > + fence_cookie =3D dma_fence_begin_signalling(); > > > > > > > > ret_overrun =3D hrtimer_forward_now(&output->vblank_hrtimer, > > > > output->period_ns); > > > > @@ -49,6 +53,8 @@ static enum hrtimer_restart vkms_vblank_simulate(= struct hrtimer *timer) > > > > DRM_DEBUG_DRIVER("Composer worker already queue= d\n"); > > > > } > > > > > > > > + dma_fence_end_signalling(fence_cookie); > > > > + > > > > return HRTIMER_RESTART; > > > > } > > > > > > > > -- > > > > 2.27.0 > > > > > > > > > > -- > > > Rodrigo Siqueira > > > https://siqueira.tech > > > > > = > = > -- = > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx