From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Uma Shankar <uma.shankar@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [v2] drm/i915/display/fbc: Disable fbc by default on TGL
Date: Thu, 16 Jul 2020 17:44:46 +0300 [thread overview]
Message-ID: <20200716144446.GW6112@intel.com> (raw)
In-Reply-To: <20200716145857.6911-1-uma.shankar@intel.com>
On Thu, Jul 16, 2020 at 08:28:57PM +0530, Uma Shankar wrote:
> Fbc is causing random underruns in CI execution on TGL platforms.
> Disabling the same while the problem is being debugged and analyzed.
>
> v2: Moved the check below the module param check (Ville)
>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fbc.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
> index 3a4f980788a6..195b8be4532a 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -1426,6 +1426,13 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
> if (!HAS_FBC(dev_priv))
> return 0;
>
> + /*
> + * Fbc is causing random underruns in CI execution on TGL platforms.
> + * Disabling the same while the problem is being debugged and analyzed.
> + */
> + if (IS_TIGERLAKE(dev_priv))
> + return 0;
> +
> if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9)
> return 1;
>
> --
> 2.22.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-07-16 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 14:58 [Intel-gfx] [v2] drm/i915/display/fbc: Disable fbc by default on TGL Uma Shankar
2020-07-16 14:44 ` Ville Syrjälä [this message]
2020-07-28 8:21 ` Shankar, Uma
2020-07-16 15:43 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display/fbc: Disable fbc by default on TGL (rev2) Patchwork
2020-07-16 15:51 ` Shankar, Uma
2020-07-16 17:24 ` Vudum, Lakshminarayana
2020-07-16 17:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-07-16 19:28 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716144446.GW6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).