From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org, Chris Wilson <chris@chris-wilson.co.uk>
Subject: [Intel-gfx] [PATCH i-g-t 4/4] lib/i915: Pick a subtest conformant name for an unknown engine
Date: Fri, 24 Jul 2020 18:06:49 +0100 [thread overview]
Message-ID: <20200724170649.463842-4-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20200724170649.463842-1-chris@chris-wilson.co.uk>
IGT disallows ':' in its subtest names, and as we use the engine name
for dynamic subtest names, pick a name that doesn't accidentally cause
IGT to assert (even when those tests are not being run).
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
lib/i915/gem_engine_topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c
index 76222186c..63e1b7ddc 100644
--- a/lib/i915/gem_engine_topology.c
+++ b/lib/i915/gem_engine_topology.c
@@ -136,7 +136,7 @@ static void init_engine(struct intel_execution_engine2 *e2,
} else {
igt_debug("found unknown engine (%d, %d)\n", class, instance);
e2->flags = -1;
- ret = snprintf(e2->name, sizeof(e2->name), "%u:%u",
+ ret = snprintf(e2->name, sizeof(e2->name), "c%u_%u",
class, instance);
}
--
2.28.0.rc1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2020-07-24 17:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 17:06 [Intel-gfx] [PATCH i-g-t 1/4] lib/i915: Identify Rocketlake Chris Wilson
2020-07-24 17:06 ` [Intel-gfx] [PATCH i-g-t 2/4] lib/i915: Report unknown device as the future Chris Wilson
2020-07-24 17:06 ` [Intel-gfx] [PATCH i-g-t 3/4] tools: Use the gt number stored in the device info Chris Wilson
2020-07-24 17:06 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724170649.463842-4-chris@chris-wilson.co.uk \
--to=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).