From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Karol Herbst <kherbst@redhat.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/uc: tune down GuC communication enabled/disabled messages
Date: Thu, 17 Sep 2020 20:05:25 +0300 [thread overview]
Message-ID: <20200917170525.GA6112@intel.com> (raw)
In-Reply-To: <20200917165056.29766-1-jani.nikula@intel.com>
On Thu, Sep 17, 2020 at 07:50:56PM +0300, Jani Nikula wrote:
> The GuC communication enabled/disabled messages are too noisy in info
> level. Convert them from info to debug level, and switch to device based
> logging while at it.
>
> Reported-by: Karol Herbst <kherbst@redhat.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_uc.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> index d6f55f70889d..4e6070e95fe9 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
> @@ -231,13 +231,15 @@ static int guc_enable_communication(struct intel_guc *guc)
> intel_guc_ct_event_handler(&guc->ct);
> spin_unlock_irq(&i915->irq_lock);
>
> - DRM_INFO("GuC communication enabled\n");
> + drm_dbg(&i915->drm, "GuC communication enabled\n");
>
> return 0;
> }
>
> static void guc_disable_communication(struct intel_guc *guc)
> {
> + struct drm_i915_private *i915 = guc_to_gt(guc)->i915;
> +
> /*
> * Events generated during or after CT disable are logged by guc in
> * via mmio. Make sure the register is clear before disabling CT since
> @@ -257,7 +259,7 @@ static void guc_disable_communication(struct intel_guc *guc)
> */
> guc_get_mmio_msg(guc);
>
> - DRM_INFO("GuC communication disabled\n");
> + drm_dbg(&i915->drm, "GuC communication disabled\n");
> }
>
> static void __uc_fetch_firmwares(struct intel_uc *uc)
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-09-17 17:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 16:50 [Intel-gfx] [PATCH] drm/i915/uc: tune down GuC communication enabled/disabled messages Jani Nikula
2020-09-17 17:05 ` Ville Syrjälä [this message]
2020-09-23 9:09 ` Jani Nikula
2020-09-17 17:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-09-17 18:53 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-09-18 9:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/uc: tune down GuC communication enabled/disabled messages (rev2) Patchwork
2020-09-18 11:34 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917170525.GA6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=kherbst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).