From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36810C2D0E2 for ; Tue, 22 Sep 2020 10:19:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1E5A2395C for ; Tue, 22 Sep 2020 10:19:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1E5A2395C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 074D96E0B6; Tue, 22 Sep 2020 10:19:20 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6B2CA6E0B6 for ; Tue, 22 Sep 2020 10:19:18 +0000 (UTC) IronPort-SDR: ECVO6QSK11VY6oXcxNdcQnwqJko/VBVLVRHXm+VfaC81qeOxPaF5g/FXQ1FrvOusSfcRxPbCMK MLPiIS02nVnw== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="178637582" X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="178637582" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 03:19:17 -0700 IronPort-SDR: EEnobcza2gbR2Kx23LA+sZW5JvAMU1N2NSNKQalGsCPn2E4dX2oJOIIpI7zBuwfh+cl3aGZJmE wP+QE9KUYg4Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="338239965" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga008.jf.intel.com with SMTP; 22 Sep 2020 03:19:15 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 22 Sep 2020 13:19:15 +0300 Date: Tue, 22 Sep 2020 13:19:15 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Navare, Manasi" Message-ID: <20200922101915.GN6112@intel.com> References: <20200715224222.7557-1-manasi.d.navare@intel.com> <20200715224222.7557-2-manasi.d.navare@intel.com> <20200903174944.GW6112@intel.com> <20200903180432.GA22804@labuser-Z97X-UD5H> <20200903184044.GZ6112@intel.com> <20200907123523.GG6112@intel.com> <20200914183242.GA28634@labuser-Z97X-UD5H> <20200914185257.GW6112@intel.com> <20200921210118.GA18761@labuser-Z97X-UD5H> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200921210118.GA18761@labuser-Z97X-UD5H> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH v6 02/11] drm/i915: Remove hw.mode X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Sep 21, 2020 at 02:01:25PM -0700, Navare, Manasi wrote: > On Mon, Sep 14, 2020 at 09:52:57PM +0300, Ville Syrj=E4l=E4 wrote: > > On Mon, Sep 14, 2020 at 11:32:48AM -0700, Navare, Manasi wrote: > > > On Mon, Sep 07, 2020 at 03:35:23PM +0300, Ville Syrj=E4l=E4 wrote: > > > > On Thu, Sep 03, 2020 at 09:40:44PM +0300, Ville Syrj=E4l=E4 wrote: > > > > > On Thu, Sep 03, 2020 at 11:04:33AM -0700, Navare, Manasi wrote: > > > > > > On Thu, Sep 03, 2020 at 08:49:44PM +0300, Ville Syrj=E4l=E4 wro= te: > > > > > > > On Wed, Jul 15, 2020 at 03:42:13PM -0700, Manasi Navare wrote: > > > > > > > > From: Maarten Lankhorst > > > > > > > > = > > > > > > > > The members in hw.mode can be used from adjusted_mode as we= ll, > > > > > > > > use that when available. > > > > > > > > = > > > > > > > > Some places that use hw.mode can be converted to use adjust= ed_mode > > > > > > > > as well. > > > > > > > > = > > > > > > > > v2: > > > > > > > > * Manual rebase (Manasi) > > > > > > > > * remove the use of pipe_mode defined in patch 3 (Manasi) > > > > > > > > = > > > > > > > > v3: > > > > > > > > * Rebase on drm-tip (Manasi) > > > > > > > = > > > > > > > Previous review was apparently ignored. Or is there a better = version > > > > > > > somewhere? If not, this still looks very wrong. > > > > > > = > > > > > > This was the latest rev that Maarten had in his local tree whic= h he said should address all the review comments. > > > > > > What in particular looks wrong or what review comments were una= ddressed here? > > > > > = > > > > > The dvo/sdvo changes. > > > > = > > > > I recommend just dropping this patch entirely. It doesn't seem to h= ave > > > > anything to do with the bigjoiner anyway. > > > = > > > So for the dvo/svdo changes, no need to use the adjusted_mode instead= keep using hw.mode? > > > How about other cleanups like: intel_crtc_copy_hw_to_uapi_state(crtc_= state, &mode); and > > > static void intel_crtc_copy_hw_to_uapi_state(struct intel_crtc_state = *crtc_state, > > > + struct drm_display_mode *user_mode) > > > = > > > You think we dont need mode as an argument there either? > > = > > Not in this patch if all the other stuff disappears. No idea if some > > later patch might need something like it. > = > Hi Ville, > = > So this patch basically removes the hw.mode and just keeps hw.adjusted_mo= de > So no need to remove that? = > But basically from this patch onwards we say that there is hw.pipe_mode > and hw.adjusted_mode, there is no hw.mode. > Are you suggesting keeping hw.mode as well? Would this be replacing hw.pi= pe_mode then? No. hw.mode is the original timings, adjusted_mode is the output timings, pipe_mode is the the pipe timings. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx