From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
x86@kernel.org, Chris Wilson <chris@chris-wilson.co.uk>,
Minchan Kim <minchan@kernel.org>,
Matthew Auld <matthew.auld@intel.com>,
xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Nitin Gupta <ngupta@vflare.org>
Subject: [Intel-gfx] [PATCH 05/10] zsmalloc: switch from alloc_vm_area to get_vm_area
Date: Wed, 30 Sep 2020 19:51:28 +0200 [thread overview]
Message-ID: <20200930175133.1252382-6-hch@lst.de> (raw)
In-Reply-To: <20200930175133.1252382-1-hch@lst.de>
Just manually pre-fault the PTEs using apply_to_page_range.
Co-developed-by: Minchan Kim <minchan@kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
mm/zsmalloc.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index c36fdff9a37131..918c7b019b3d78 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -1122,10 +1122,16 @@ static inline int __zs_cpu_up(struct mapping_area *area)
*/
if (area->vm)
return 0;
- area->vm = alloc_vm_area(PAGE_SIZE * 2, NULL);
+ area->vm = get_vm_area(PAGE_SIZE * 2, 0);
if (!area->vm)
return -ENOMEM;
- return 0;
+
+ /*
+ * Populate ptes in advance to avoid pte allocation with GFP_KERNEL
+ * in non-preemtible context of zs_map_object.
+ */
+ return apply_to_page_range(&init_mm, (unsigned long)area->vm->addr,
+ PAGE_SIZE * 2, NULL, NULL);
}
static inline void __zs_cpu_down(struct mapping_area *area)
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-09-30 17:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 17:51 [Intel-gfx] remove alloc_vm_area v3 Christoph Hellwig
2020-09-30 17:51 ` [Intel-gfx] [PATCH 01/10] mm: update the documentation for vfree Christoph Hellwig
2020-09-30 17:51 ` [Intel-gfx] [PATCH 02/10] mm: add a VM_MAP_PUT_PAGES flag for vmap Christoph Hellwig
2020-09-30 17:51 ` [Intel-gfx] [PATCH 03/10] mm: add a vmap_pfn function Christoph Hellwig
2020-09-30 17:51 ` [Intel-gfx] [PATCH 04/10] mm: allow a NULL fn callback in apply_to_page_range Christoph Hellwig
2020-09-30 17:51 ` Christoph Hellwig [this message]
2020-09-30 17:51 ` [Intel-gfx] [PATCH 06/10] drm/i915: use vmap in shmem_pin_map Christoph Hellwig
2020-09-30 17:51 ` [Intel-gfx] [PATCH 07/10] drm/i915: use vmap in i915_gem_object_map Christoph Hellwig
2020-09-30 17:51 ` [Intel-gfx] [PATCH 08/10] xen/xenbus: use apply_to_page_range directly in xenbus_map_ring_pv Christoph Hellwig
2020-09-30 17:51 ` [Intel-gfx] [PATCH 09/10] x86/xen: open code alloc_vm_area in arch_gnttab_valloc Christoph Hellwig
2020-09-30 17:51 ` [Intel-gfx] [PATCH 10/10] mm: remove alloc_vm_area Christoph Hellwig
2020-09-30 20:10 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [01/10] mm: update the documentation for vfree Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930175133.1252382-6-hch@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=boris.ostrovsky@oracle.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.auld@intel.com \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=peterz@infradead.org \
--cc=sstabellini@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).