intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
	David Airlie <airlied@linux.ie>,
	open list <linux-kernel@vger.kernel.org>,
	greg.depoire@gmail.com, Ben Skeggs <bskeggs@redhat.com>
Subject: [Intel-gfx] [RFC 2/5] drm/nouveau/kms: Don't probe eDP connectors more then once
Date: Wed,  9 Dec 2020 20:21:40 -0500	[thread overview]
Message-ID: <20201210012143.729402-3-lyude@redhat.com> (raw)
In-Reply-To: <20201210012143.729402-1-lyude@redhat.com>

eDP doesn't do hotplugging, so there's no reason for us to reprobe it (unless a
connection status change is being forced, of course).

Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Dave Airlie <airlied@gmail.com>
Cc: greg.depoire@gmail.com
---
 drivers/gpu/drm/nouveau/nouveau_connector.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
index 8b4b3688c7ae..398fee9b7ae9 100644
--- a/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -554,6 +554,12 @@ nouveau_connector_detect(struct drm_connector *connector, bool force)
 	int ret;
 	enum drm_connector_status conn_status = connector_status_disconnected;
 
+	/* eDP doesn't do hotplugging, never probe more then once */
+	if (nv_connector->type == DCB_CONNECTOR_eDP &&
+	    connector->force == DRM_FORCE_UNSPECIFIED &&
+	    connector->status != connector_status_unknown)
+		return connector->status;
+
 	/* Outputs are only polled while runtime active, so resuming the
 	 * device here is unnecessary (and would deadlock upon runtime suspend
 	 * because it waits for polling to finish). We do however, want to
-- 
2.28.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-12-10  1:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10  1:21 [Intel-gfx] [RFC 0/5] drm: Extract DPCD backlight helpers from i915, add support in nouveau Lyude Paul
2020-12-10  1:21 ` [Intel-gfx] [RFC 1/5] drm/nouveau/kms/nv40-/backlight: Assign prop type once Lyude Paul
2020-12-10  1:21 ` Lyude Paul [this message]
2020-12-10  1:21 ` [Intel-gfx] [RFC 3/5] drm/i915/dp: Remove redundant AUX backlight frequency calculations Lyude Paul
2020-12-11 14:45   ` Jani Nikula
2020-12-10  1:21 ` [Intel-gfx] [RFC 4/5] drm/dp: Extract i915's eDP backlight code into DRM helpers Lyude Paul
2020-12-11 15:01   ` Jani Nikula
2021-01-26  0:02     ` Lyude Paul
2020-12-10  1:21 ` [Intel-gfx] [RFC 5/5] drm/nouveau/kms/nv50-: Add basic DPCD backlight support for nouveau Lyude Paul
2020-12-10  3:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Extract DPCD backlight helpers from i915, add support in nouveau Patchwork
2020-12-10  4:00 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-12-10  4:03 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2020-12-10  4:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-12-10  7:32 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-12-10 18:38 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev2) Patchwork
2020-12-10 18:40 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-12-10 18:43 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2020-12-10 19:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-12-10 20:52 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-12-10 23:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev3) Patchwork
2020-12-10 23:03 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-12-10 23:07 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2020-12-10 23:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-12-11  1:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201210012143.729402-3-lyude@redhat.com \
    --to=lyude@redhat.com \
    --cc=airlied@linux.ie \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=greg.depoire@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).