Intel-GFX Archive on lore.kernel.org
 help / color / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: [Intel-gfx] [PATCH 07/10] drm/i915/gt: Insert spaces into GEN3_L3LOG_SIZE/4
Date: Fri, 22 Jan 2021 15:06:19 +0000
Message-ID: <20210122150622.21088-7-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20210122150622.21088-1-chris@chris-wilson.co.uk>

Checkpatch wants spaces, let's give it some spaces.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/intel_ring_submission.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
index 1a80673bc1dd..8b7cc637c432 100644
--- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c
+++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
@@ -730,13 +730,14 @@ static int mi_set_context(struct i915_request *rq,
 
 static int remap_l3_slice(struct i915_request *rq, int slice)
 {
+#define L3LOG_DW (GEN7_L3LOG_SIZE / sizeof(u32))
 	u32 *cs, *remap_info = rq->engine->i915->l3_parity.remap_info[slice];
 	int i;
 
 	if (!remap_info)
 		return 0;
 
-	cs = intel_ring_begin(rq, GEN7_L3LOG_SIZE/4 * 2 + 2);
+	cs = intel_ring_begin(rq, L3LOG_DW * 2 + 2);
 	if (IS_ERR(cs))
 		return PTR_ERR(cs);
 
@@ -745,8 +746,8 @@ static int remap_l3_slice(struct i915_request *rq, int slice)
 	 * here because no other code should access these registers other than
 	 * at initialization time.
 	 */
-	*cs++ = MI_LOAD_REGISTER_IMM(GEN7_L3LOG_SIZE/4);
-	for (i = 0; i < GEN7_L3LOG_SIZE/4; i++) {
+	*cs++ = MI_LOAD_REGISTER_IMM(L3LOG_DW);
+	for (i = 0; i < L3LOG_DW; i++) {
 		*cs++ = i915_mmio_reg_offset(GEN7_L3LOG(slice, i));
 		*cs++ = remap_info[i];
 	}
@@ -754,6 +755,7 @@ static int remap_l3_slice(struct i915_request *rq, int slice)
 	intel_ring_advance(rq, cs);
 
 	return 0;
+#undef L3LOG_DW
 }
 
 static int remap_l3(struct i915_request *rq)
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply index

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 15:06 [Intel-gfx] [PATCH 01/10] drm/i915/gt: SPDX cleanup Chris Wilson
2021-01-22 15:06 ` [Intel-gfx] [PATCH 02/10] drm/i915/gt: Add some missing blank lines after declaration Chris Wilson
2021-01-22 15:06 ` [Intel-gfx] [PATCH 03/10] drm/i915/gt: Remove repeated words from comments Chris Wilson
2021-01-22 15:06 ` [Intel-gfx] [PATCH 04/10] drm/i915/gt: Fixup misaligned function parameters Chris Wilson
2021-01-22 15:06 ` [Intel-gfx] [PATCH 05/10] drm/i915/gt: Remove a bonus newline Chris Wilson
2021-01-22 15:06 ` [Intel-gfx] [PATCH 06/10] drm/i915/gt: Wrap macro arg in () Chris Wilson
2021-01-22 15:06 ` Chris Wilson [this message]
2021-01-22 15:06 ` [Intel-gfx] [PATCH 08/10] drm/i915/gt: Replace unnecessary ',' with '; ' Chris Wilson
2021-01-22 15:06 ` [Intel-gfx] [PATCH 09/10] drm/i915/gt: Add a space before '(' Chris Wilson
2021-01-22 15:06 ` [Intel-gfx] [PATCH 10/10] drm/i915/gt: Replace 'return' with a fall-through Chris Wilson
2021-01-22 15:43 ` [Intel-gfx] [PATCH 01/10] drm/i915/gt: SPDX cleanup Michal Wajdeczko
2021-01-22 15:49   ` Chris Wilson
2021-01-22 16:03     ` Michal Wajdeczko
2021-01-22 16:16       ` Chris Wilson
2021-01-22 18:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] " Patchwork
2021-01-22 18:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-01-22 19:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-23  3:24 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210122150622.21088-7-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Intel-GFX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/intel-gfx/0 intel-gfx/git/0.git
	git clone --mirror https://lore.kernel.org/intel-gfx/1 intel-gfx/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 intel-gfx intel-gfx/ https://lore.kernel.org/intel-gfx \
		intel-gfx@lists.freedesktop.org
	public-inbox-index intel-gfx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.intel-gfx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git