From: Christoph Hellwig <hch@lst.de>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: Serge Belyshev <belyshev@depni.sinp.msu.ru>,
Peter Zijlstra <peterz@infradead.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Chris Wilson <chris@chris-wilson.co.uk>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [Intel-gfx] [PATCH 4/4] i915: fix remap_io_sg to verify the pgprot
Date: Tue, 18 May 2021 15:23:33 +0200 [thread overview]
Message-ID: <20210518132333.GC2617@lst.de> (raw)
In-Reply-To: <976fb38a-7780-6ca6-d602-a5f02c0938c9@linux.intel.com>
On Mon, May 17, 2021 at 11:46:35PM +0200, Thomas Hellström wrote:
> Apart from the caching aliasing Mattew brought up, doesn't the
> remap_pfn_range_xxx() family require the mmap_sem held in write mode since
> it modifies the vma structure? remap_io_sg() is called from the fault
> handler with the mmap_sem held in read mode only.
Only for vma->vm_flags, and remap_sg already asserts all the interesting
flags are set, although it does not assert VM_IO.
We could move the assignment out of remap_pfn_range_notrack and
into remap_pfn_range and just assert that the proper flags are set,
though.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-05-18 13:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 5:55 [Intel-gfx] add remap_pfn_range_notrack instead of reinventing it in i915 v2 Christoph Hellwig
2021-03-26 5:55 ` [Intel-gfx] [PATCH 1/4] mm: add remap_pfn_range_notrack Christoph Hellwig
2021-03-26 5:55 ` [Intel-gfx] [PATCH 2/4] mm: add a io_mapping_map_user helper Christoph Hellwig
2021-10-20 15:40 ` Lucas De Marchi
2021-10-20 19:37 ` Peter Zijlstra
2021-10-21 6:18 ` Christoph Hellwig
2021-03-26 5:55 ` [Intel-gfx] [PATCH 3/4] i915: use io_mapping_map_user Christoph Hellwig
2021-03-26 5:55 ` [Intel-gfx] [PATCH 4/4] i915: fix remap_io_sg to verify the pgprot Christoph Hellwig
2021-05-08 19:33 ` youling257
2021-05-10 8:58 ` Christoph Hellwig
2021-05-16 16:06 ` Serge Belyshev
2021-05-17 12:37 ` Christoph Hellwig
2021-05-17 13:09 ` Serge Belyshev
2021-05-17 13:11 ` Christoph Hellwig
2021-05-17 17:06 ` Matthew Auld
2021-05-18 13:21 ` Christoph Hellwig
2021-05-18 15:00 ` Matthew Auld
2021-05-19 5:46 ` Thomas Hellström (Intel)
2021-05-17 21:46 ` Thomas Hellström
2021-05-18 6:46 ` Thomas Hellström
2021-05-18 13:24 ` Christoph Hellwig
2021-05-18 13:33 ` Thomas Hellström
2021-05-18 13:23 ` Christoph Hellwig [this message]
2021-05-19 5:51 ` Thomas Hellström
2021-03-26 7:28 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] mm: add remap_pfn_range_notrack Patchwork
2021-03-26 7:31 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-03-26 7:34 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-03-26 7:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-04-08 10:36 ` [Intel-gfx] add remap_pfn_range_notrack instead of reinventing it in i915 v2 Daniel Vetter
2021-04-08 11:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518132333.GC2617@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=belyshev@depni.sinp.msu.ru \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).