intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
@ 2021-06-30 23:06 Anusha Srivatsa
  2021-06-30 23:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 12+ messages in thread
From: Anusha Srivatsa @ 2021-06-30 23:06 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lucas De Marchi

On the dmc side,we maintain a lookup table with different display
stepping-substepping combinations.

Instead of adding new table for every new platform, lets ues
the stepping info from RUNTIME_INFO(dev_priv)->step
Adding the helper intel_get_display_step().

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dmc.c | 49 ++++++++++++++++++++++--
 1 file changed, 45 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
index f8789d4543bf..c7ff7ff3f412 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
@@ -266,14 +266,55 @@ static const struct stepping_info icl_stepping_info[] = {
 };
 
 static const struct stepping_info no_stepping_info = { '*', '*' };
+struct stepping_info *display_step;
+
+static struct stepping_info *
+intel_get_display_stepping(struct intel_step_info step)
+{
+
+	switch (step.display_step) {
+	case STEP_A0:
+		display_step->stepping = 'A';
+		display_step->substepping = '0';
+		break;
+	case STEP_A2:
+		display_step->stepping = 'A';
+		display_step->substepping = '2';
+		break;
+	case STEP_B0:
+		display_step->stepping = 'B';
+		display_step->substepping = '0';
+		break;
+	case STEP_B1:
+		display_step->stepping = 'B';
+		display_step->substepping = '1';
+		break;
+	case STEP_C0:
+		display_step->stepping = 'C';
+		display_step->substepping = '0';
+		break;
+	case STEP_D0:
+		display_step->stepping = 'D';
+		display_step->substepping = '0';
+		break;
+	default:
+		display_step->stepping = '*';
+		display_step->substepping = '*';
+		break;
+	}
+	return display_step;
+}
 
 static const struct stepping_info *
 intel_get_stepping_info(struct drm_i915_private *dev_priv)
 {
 	const struct stepping_info *si;
+	struct intel_step_info step = RUNTIME_INFO(dev_priv)->step;
 	unsigned int size;
 
-	if (IS_ICELAKE(dev_priv)) {
+	if (DISPLAY_VER(dev_priv) >= 12) {
+		si = intel_get_display_stepping(step);
+	} else if (IS_ICELAKE(dev_priv)) {
 		size = ARRAY_SIZE(icl_stepping_info);
 		si = icl_stepping_info;
 	} else if (IS_SKYLAKE(dev_priv)) {
@@ -287,10 +328,10 @@ intel_get_stepping_info(struct drm_i915_private *dev_priv)
 		si = NULL;
 	}
 
-	if (INTEL_REVID(dev_priv) < size)
-		return si + INTEL_REVID(dev_priv);
+	if (DISPLAY_VER(dev_priv) < 12)
+		return INTEL_REVID(dev_priv) < size ? si + INTEL_REVID(dev_priv) : &no_stepping_info;
 
-	return &no_stepping_info;
+	return si;
 }
 
 static void gen9_set_dc_state_debugmask(struct drm_i915_private *dev_priv)
-- 
2.32.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
  2021-06-30 23:06 [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC Anusha Srivatsa
@ 2021-06-30 23:13 ` Patchwork
  2021-06-30 23:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2021-06-30 23:13 UTC (permalink / raw)
  To: Anusha Srivatsa; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
URL   : https://patchwork.freedesktop.org/series/92088/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
dc34e57ce634 drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
-:29: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#29: FILE: drivers/gpu/drm/i915/display/intel_dmc.c:274:
+{
+

-:84: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#84: FILE: drivers/gpu/drm/i915/display/intel_dmc.c:332:
+		return INTEL_REVID(dev_priv) < size ? si + INTEL_REVID(dev_priv) : &no_stepping_info;

total: 0 errors, 1 warnings, 1 checks, 69 lines checked


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
  2021-06-30 23:06 [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC Anusha Srivatsa
  2021-06-30 23:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2021-06-30 23:14 ` Patchwork
  2021-06-30 23:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2021-06-30 23:14 UTC (permalink / raw)
  To: Anusha Srivatsa; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
URL   : https://patchwork.freedesktop.org/series/92088/
State : warning

== Summary ==

$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+drivers/gpu/drm/i915/display/intel_dmc.c:269:22: warning: symbol 'display_step' was not declared. Should it be static?


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
  2021-06-30 23:06 [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC Anusha Srivatsa
  2021-06-30 23:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
  2021-06-30 23:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2021-06-30 23:44 ` Patchwork
  2021-07-01  0:01 ` [Intel-gfx] [PATCH] " Lucas De Marchi
  2021-07-01  5:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
  4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2021-06-30 23:44 UTC (permalink / raw)
  To: Anusha Srivatsa; +Cc: intel-gfx


[-- Attachment #1.1: Type: text/plain, Size: 1730 bytes --]

== Series Details ==

Series: drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
URL   : https://patchwork.freedesktop.org/series/92088/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10295 -> Patchwork_20500
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/index.html

Known issues
------------

  Here are the changes found in Patchwork_20500 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-bdw-5557u:       [PASS][1] -> [DMESG-FAIL][2] ([i915#541])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/fi-bdw-5557u/igt@i915_selftest@live@gt_heartbeat.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/fi-bdw-5557u/igt@i915_selftest@live@gt_heartbeat.html

  
  [i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541


Participating hosts (39 -> 33)
------------------------------

  Missing    (6): fi-ilk-m540 fi-tgl-dsi fi-tgl-1115g4 fi-bsw-cyan fi-dg1-1 fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_10295 -> Patchwork_20500

  CI-20190529: 20190529
  CI_DRM_10295: 683b7f160eb6993ccfc19e67e3c7111f12946bea @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_6124: 357d5477c93f2bdd3354afe91b89ccfd4ee4fd56 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_20500: dc34e57ce63492d648bec07e172458837b8d71d8 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

dc34e57ce634 drm/i915/dmc: Use RUNTIME_INFO->stp for DMC

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/index.html

[-- Attachment #1.2: Type: text/html, Size: 2329 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
  2021-06-30 23:06 [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC Anusha Srivatsa
                   ` (2 preceding siblings ...)
  2021-06-30 23:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-07-01  0:01 ` Lucas De Marchi
  2021-07-01  0:15   ` Souza, Jose
  2021-07-02  7:49   ` Jani Nikula
  2021-07-01  5:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
  4 siblings, 2 replies; 12+ messages in thread
From: Lucas De Marchi @ 2021-07-01  0:01 UTC (permalink / raw)
  To: Anusha Srivatsa; +Cc: intel-gfx

Typo: RUNTIME_INFO->stp

On Wed, Jun 30, 2021 at 04:06:24PM -0700, Anusha Srivatsa wrote:
>On the dmc side,we maintain a lookup table with different display
>stepping-substepping combinations.
>
>Instead of adding new table for every new platform, lets ues
>the stepping info from RUNTIME_INFO(dev_priv)->step
>Adding the helper intel_get_display_step().
>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_dmc.c | 49 ++++++++++++++++++++++--
> 1 file changed, 45 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
>index f8789d4543bf..c7ff7ff3f412 100644
>--- a/drivers/gpu/drm/i915/display/intel_dmc.c
>+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
>@@ -266,14 +266,55 @@ static const struct stepping_info icl_stepping_info[] = {
> };
>
> static const struct stepping_info no_stepping_info = { '*', '*' };
>+struct stepping_info *display_step;
>+
>+static struct stepping_info *
>+intel_get_display_stepping(struct intel_step_info step)
>+{
>+
>+	switch (step.display_step) {
>+	case STEP_A0:
>+		display_step->stepping = 'A';
>+		display_step->substepping = '0';
>+		break;
>+	case STEP_A2:
>+		display_step->stepping = 'A';
>+		display_step->substepping = '2';
>+		break;
>+	case STEP_B0:
>+		display_step->stepping = 'B';
>+		display_step->substepping = '0';
>+		break;
>+	case STEP_B1:
>+		display_step->stepping = 'B';
>+		display_step->substepping = '1';
>+		break;
>+	case STEP_C0:
>+		display_step->stepping = 'C';
>+		display_step->substepping = '0';
>+		break;
>+	case STEP_D0:
>+		display_step->stepping = 'D';
>+		display_step->substepping = '0';
>+		break;
>+	default:
>+		display_step->stepping = '*';
>+		display_step->substepping = '*';
>+		break;
>+	}


"crazy" idea that would avoid this type of conversion:
changing the step enum to be:


#define make_step(letter, num) (int)(((letter) << 8 ) | (num))

STEP_A0 = make_step('A', '0'),
STEP_A1 = make_step('A', '1'),

and adapt the rest of the code to play with u16 instead of u8, and
handle the STEP_FUTURE/STEP_NONE/STEP_FOREVER.
Maybe it is crazy, dunno.

+Jani / +Jose. Thoughts?


For this version the next comment is probably more important.

>+	return display_step;
>+}
>
> static const struct stepping_info *
> intel_get_stepping_info(struct drm_i915_private *dev_priv)
> {
> 	const struct stepping_info *si;
>+	struct intel_step_info step = RUNTIME_INFO(dev_priv)->step;
> 	unsigned int size;
>
>-	if (IS_ICELAKE(dev_priv)) {
>+	if (DISPLAY_VER(dev_priv) >= 12) {
>+		si = intel_get_display_stepping(step);
>+	} else if (IS_ICELAKE(dev_priv)) {
> 		size = ARRAY_SIZE(icl_stepping_info);
> 		si = icl_stepping_info;

can we move the other ones too? Just use display_step for all platforms.
Notice that before the separation we will have display_step ==
graphics_step, so it should just work.


Lucas De Marchi

> 	} else if (IS_SKYLAKE(dev_priv)) {
>@@ -287,10 +328,10 @@ intel_get_stepping_info(struct drm_i915_private *dev_priv)
> 		si = NULL;
> 	}
>
>-	if (INTEL_REVID(dev_priv) < size)
>-		return si + INTEL_REVID(dev_priv);
>+	if (DISPLAY_VER(dev_priv) < 12)
>+		return INTEL_REVID(dev_priv) < size ? si + INTEL_REVID(dev_priv) : &no_stepping_info;
>
>-	return &no_stepping_info;
>+	return si;
> }
>
> static void gen9_set_dc_state_debugmask(struct drm_i915_private *dev_priv)
>-- 
>2.32.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
  2021-07-01  0:01 ` [Intel-gfx] [PATCH] " Lucas De Marchi
@ 2021-07-01  0:15   ` Souza, Jose
  2021-07-01  0:17     ` Lucas De Marchi
  2021-07-02  7:49   ` Jani Nikula
  1 sibling, 1 reply; 12+ messages in thread
From: Souza, Jose @ 2021-07-01  0:15 UTC (permalink / raw)
  To: Srivatsa, Anusha, De Marchi, Lucas; +Cc: intel-gfx

On Wed, 2021-06-30 at 17:01 -0700, Lucas De Marchi wrote:
> Typo: RUNTIME_INFO->stp
> 
> On Wed, Jun 30, 2021 at 04:06:24PM -0700, Anusha Srivatsa wrote:
> > On the dmc side,we maintain a lookup table with different display
> > stepping-substepping combinations.
> > 
> > Instead of adding new table for every new platform, lets ues
> > the stepping info from RUNTIME_INFO(dev_priv)->step
> > Adding the helper intel_get_display_step().
> > 
> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_dmc.c | 49 ++++++++++++++++++++++--
> > 1 file changed, 45 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
> > index f8789d4543bf..c7ff7ff3f412 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> > @@ -266,14 +266,55 @@ static const struct stepping_info icl_stepping_info[] = {
> > };
> > 
> > static const struct stepping_info no_stepping_info = { '*', '*' };
> > +struct stepping_info *display_step;
> > +
> > +static struct stepping_info *
> > +intel_get_display_stepping(struct intel_step_info step)
> > +{
> > +
> > +	switch (step.display_step) {
> > +	case STEP_A0:
> > +		display_step->stepping = 'A';
> > +		display_step->substepping = '0';
> > +		break;
> > +	case STEP_A2:
> > +		display_step->stepping = 'A';
> > +		display_step->substepping = '2';
> > +		break;
> > +	case STEP_B0:
> > +		display_step->stepping = 'B';
> > +		display_step->substepping = '0';
> > +		break;
> > +	case STEP_B1:
> > +		display_step->stepping = 'B';
> > +		display_step->substepping = '1';
> > +		break;
> > +	case STEP_C0:
> > +		display_step->stepping = 'C';
> > +		display_step->substepping = '0';
> > +		break;
> > +	case STEP_D0:
> > +		display_step->stepping = 'D';
> > +		display_step->substepping = '0';
> > +		break;
> > +	default:
> > +		display_step->stepping = '*';
> > +		display_step->substepping = '*';
> > +		break;
> > +	}
> 
> 
> "crazy" idea that would avoid this type of conversion:
> changing the step enum to be:
> 
> 
> #define make_step(letter, num) (int)(((letter) << 8 ) | (num))
> 
> STEP_A0 = make_step('A', '0'),
> STEP_A1 = make_step('A', '1'),

Looks a good idea to me, we could also keep it u8 using 4bits for each if there is memory concerns.

> 
> and adapt the rest of the code to play with u16 instead of u8, and
> handle the STEP_FUTURE/STEP_NONE/STEP_FOREVER.
> Maybe it is crazy, dunno.
> 
> +Jani / +Jose. Thoughts?
> 
> 
> For this version the next comment is probably more important.
> 
> > +	return display_step;
> > +}
> > 
> > static const struct stepping_info *
> > intel_get_stepping_info(struct drm_i915_private *dev_priv)
> > {
> > 	const struct stepping_info *si;
> > +	struct intel_step_info step = RUNTIME_INFO(dev_priv)->step;
> > 	unsigned int size;
> > 
> > -	if (IS_ICELAKE(dev_priv)) {
> > +	if (DISPLAY_VER(dev_priv) >= 12) {
> > +		si = intel_get_display_stepping(step);
> > +	} else if (IS_ICELAKE(dev_priv)) {
> > 		size = ARRAY_SIZE(icl_stepping_info);
> > 		si = icl_stepping_info;
> 
> can we move the other ones too? Just use display_step for all platforms.
> Notice that before the separation we will have display_step ==
> graphics_step, so it should just work.
> 
> 
> Lucas De Marchi
> 
> > 	} else if (IS_SKYLAKE(dev_priv)) {
> > @@ -287,10 +328,10 @@ intel_get_stepping_info(struct drm_i915_private *dev_priv)
> > 		si = NULL;
> > 	}
> > 
> > -	if (INTEL_REVID(dev_priv) < size)
> > -		return si + INTEL_REVID(dev_priv);
> > +	if (DISPLAY_VER(dev_priv) < 12)
> > +		return INTEL_REVID(dev_priv) < size ? si + INTEL_REVID(dev_priv) : &no_stepping_info;
> > 
> > -	return &no_stepping_info;
> > +	return si;
> > }
> > 
> > static void gen9_set_dc_state_debugmask(struct drm_i915_private *dev_priv)
> > -- 
> > 2.32.0
> > 

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
  2021-07-01  0:15   ` Souza, Jose
@ 2021-07-01  0:17     ` Lucas De Marchi
  2021-07-01 17:46       ` Lucas De Marchi
  0 siblings, 1 reply; 12+ messages in thread
From: Lucas De Marchi @ 2021-07-01  0:17 UTC (permalink / raw)
  To: Souza, Jose; +Cc: intel-gfx

On Wed, Jun 30, 2021 at 05:15:00PM -0700, Jose Souza wrote:
>On Wed, 2021-06-30 at 17:01 -0700, Lucas De Marchi wrote:
>> Typo: RUNTIME_INFO->stp
>>
>> On Wed, Jun 30, 2021 at 04:06:24PM -0700, Anusha Srivatsa wrote:
>> > On the dmc side,we maintain a lookup table with different display
>> > stepping-substepping combinations.
>> >
>> > Instead of adding new table for every new platform, lets ues
>> > the stepping info from RUNTIME_INFO(dev_priv)->step
>> > Adding the helper intel_get_display_step().
>> >
>> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> > ---
>> > drivers/gpu/drm/i915/display/intel_dmc.c | 49 ++++++++++++++++++++++--
>> > 1 file changed, 45 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
>> > index f8789d4543bf..c7ff7ff3f412 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_dmc.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
>> > @@ -266,14 +266,55 @@ static const struct stepping_info icl_stepping_info[] = {
>> > };
>> >
>> > static const struct stepping_info no_stepping_info = { '*', '*' };
>> > +struct stepping_info *display_step;
>> > +
>> > +static struct stepping_info *
>> > +intel_get_display_stepping(struct intel_step_info step)
>> > +{
>> > +
>> > +	switch (step.display_step) {
>> > +	case STEP_A0:
>> > +		display_step->stepping = 'A';
>> > +		display_step->substepping = '0';
>> > +		break;
>> > +	case STEP_A2:
>> > +		display_step->stepping = 'A';
>> > +		display_step->substepping = '2';
>> > +		break;
>> > +	case STEP_B0:
>> > +		display_step->stepping = 'B';
>> > +		display_step->substepping = '0';
>> > +		break;
>> > +	case STEP_B1:
>> > +		display_step->stepping = 'B';
>> > +		display_step->substepping = '1';
>> > +		break;
>> > +	case STEP_C0:
>> > +		display_step->stepping = 'C';
>> > +		display_step->substepping = '0';
>> > +		break;
>> > +	case STEP_D0:
>> > +		display_step->stepping = 'D';
>> > +		display_step->substepping = '0';
>> > +		break;
>> > +	default:
>> > +		display_step->stepping = '*';
>> > +		display_step->substepping = '*';
>> > +		break;
>> > +	}
>>
>>
>> "crazy" idea that would avoid this type of conversion:
>> changing the step enum to be:
>>
>>
>> #define make_step(letter, num) (int)(((letter) << 8 ) | (num))
>>
>> STEP_A0 = make_step('A', '0'),
>> STEP_A1 = make_step('A', '1'),
>
>Looks a good idea to me, we could also keep it u8 using 4bits for each if there is memory concerns.

humn... indeed. Not much a concern actually, but not having to change
additional code is already a good thing.


I hope no stepping goes beyond Z9 :)

Lucas De Marchi

>
>>
>> and adapt the rest of the code to play with u16 instead of u8, and
>> handle the STEP_FUTURE/STEP_NONE/STEP_FOREVER.
>> Maybe it is crazy, dunno.
>>
>> +Jani / +Jose. Thoughts?
>>
>>
>> For this version the next comment is probably more important.
>>
>> > +	return display_step;
>> > +}
>> >
>> > static const struct stepping_info *
>> > intel_get_stepping_info(struct drm_i915_private *dev_priv)
>> > {
>> > 	const struct stepping_info *si;
>> > +	struct intel_step_info step = RUNTIME_INFO(dev_priv)->step;
>> > 	unsigned int size;
>> >
>> > -	if (IS_ICELAKE(dev_priv)) {
>> > +	if (DISPLAY_VER(dev_priv) >= 12) {
>> > +		si = intel_get_display_stepping(step);
>> > +	} else if (IS_ICELAKE(dev_priv)) {
>> > 		size = ARRAY_SIZE(icl_stepping_info);
>> > 		si = icl_stepping_info;
>>
>> can we move the other ones too? Just use display_step for all platforms.
>> Notice that before the separation we will have display_step ==
>> graphics_step, so it should just work.
>>
>>
>> Lucas De Marchi
>>
>> > 	} else if (IS_SKYLAKE(dev_priv)) {
>> > @@ -287,10 +328,10 @@ intel_get_stepping_info(struct drm_i915_private *dev_priv)
>> > 		si = NULL;
>> > 	}
>> >
>> > -	if (INTEL_REVID(dev_priv) < size)
>> > -		return si + INTEL_REVID(dev_priv);
>> > +	if (DISPLAY_VER(dev_priv) < 12)
>> > +		return INTEL_REVID(dev_priv) < size ? si + INTEL_REVID(dev_priv) : &no_stepping_info;
>> >
>> > -	return &no_stepping_info;
>> > +	return si;
>> > }
>> >
>> > static void gen9_set_dc_state_debugmask(struct drm_i915_private *dev_priv)
>> > --
>> > 2.32.0
>> >
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
  2021-06-30 23:06 [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC Anusha Srivatsa
                   ` (3 preceding siblings ...)
  2021-07-01  0:01 ` [Intel-gfx] [PATCH] " Lucas De Marchi
@ 2021-07-01  5:48 ` Patchwork
  4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2021-07-01  5:48 UTC (permalink / raw)
  To: Anusha Srivatsa; +Cc: intel-gfx


[-- Attachment #1.1: Type: text/plain, Size: 27153 bytes --]

== Series Details ==

Series: drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
URL   : https://patchwork.freedesktop.org/series/92088/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10295_full -> Patchwork_20500_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_20500_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_20500_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_20500_full:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
    - shard-skl:          NOTRUN -> [FAIL][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl9/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html

  
Known issues
------------

  Here are the changes found in Patchwork_20500_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_create@create-massive:
    - shard-apl:          NOTRUN -> [DMESG-WARN][2] ([i915#3002])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl1/igt@gem_create@create-massive.html

  * igt@gem_ctx_persistence@legacy-engines-hostile-preempt:
    - shard-snb:          NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +3 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-snb6/igt@gem_ctx_persistence@legacy-engines-hostile-preempt.html

  * igt@gem_eio@unwedge-stress:
    - shard-skl:          [PASS][4] -> [TIMEOUT][5] ([i915#2369] / [i915#3063])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl5/igt@gem_eio@unwedge-stress.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl5/igt@gem_eio@unwedge-stress.html
    - shard-iclb:         [PASS][6] -> [TIMEOUT][7] ([i915#2369] / [i915#2481] / [i915#3070])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb3/igt@gem_eio@unwedge-stress.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-iclb8/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-apl:          [PASS][8] -> [SKIP][9] ([fdo#109271])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-apl1/igt@gem_exec_fair@basic-none-share@rcs0.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl7/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-pace@vcs1:
    - shard-iclb:         NOTRUN -> [FAIL][10] ([i915#2842])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs1.html

  * igt@gem_exec_whisper@basic-queues-forked:
    - shard-skl:          [PASS][11] -> [DMESG-WARN][12] ([i915#1982]) +1 similar issue
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl7/igt@gem_exec_whisper@basic-queues-forked.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl6/igt@gem_exec_whisper@basic-queues-forked.html

  * igt@gem_huc_copy@huc-copy:
    - shard-apl:          NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#2190])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl1/igt@gem_huc_copy@huc-copy.html

  * igt@gem_mmap_gtt@big-copy-odd:
    - shard-iclb:         [PASS][14] -> [FAIL][15] ([i915#307])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb4/igt@gem_mmap_gtt@big-copy-odd.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-iclb4/igt@gem_mmap_gtt@big-copy-odd.html

  * igt@gem_mmap_gtt@big-copy-xy:
    - shard-glk:          [PASS][16] -> [FAIL][17] ([i915#307])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-glk6/igt@gem_mmap_gtt@big-copy-xy.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-glk3/igt@gem_mmap_gtt@big-copy-xy.html

  * igt@gem_pwrite@basic-exhaustion:
    - shard-snb:          NOTRUN -> [WARN][18] ([i915#2658])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-snb5/igt@gem_pwrite@basic-exhaustion.html
    - shard-apl:          NOTRUN -> [WARN][19] ([i915#2658])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl8/igt@gem_pwrite@basic-exhaustion.html

  * igt@gem_userptr_blits@dmabuf-sync:
    - shard-apl:          NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#3323])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl3/igt@gem_userptr_blits@dmabuf-sync.html

  * igt@gem_userptr_blits@vma-merge:
    - shard-apl:          NOTRUN -> [FAIL][21] ([i915#3318])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl2/igt@gem_userptr_blits@vma-merge.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-skl:          [PASS][22] -> [DMESG-WARN][23] ([i915#1436] / [i915#716])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl9/igt@gen9_exec_parse@allowed-single.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl7/igt@gen9_exec_parse@allowed-single.html

  * igt@i915_selftest@live@hangcheck:
    - shard-snb:          NOTRUN -> [INCOMPLETE][24] ([i915#2782])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-snb6/igt@i915_selftest@live@hangcheck.html

  * igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
    - shard-apl:          NOTRUN -> [SKIP][25] ([fdo#109271]) +336 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl8/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html

  * igt@kms_chamelium@hdmi-mode-timings:
    - shard-kbl:          NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +18 similar issues
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl2/igt@kms_chamelium@hdmi-mode-timings.html

  * igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
    - shard-snb:          NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +12 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-snb6/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html

  * igt@kms_color_chamelium@pipe-c-ctm-0-25:
    - shard-apl:          NOTRUN -> [SKIP][28] ([fdo#109271] / [fdo#111827]) +31 similar issues
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl1/igt@kms_color_chamelium@pipe-c-ctm-0-25.html

  * igt@kms_color_chamelium@pipe-c-degamma:
    - shard-skl:          NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +4 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl3/igt@kms_color_chamelium@pipe-c-degamma.html

  * igt@kms_content_protection@atomic:
    - shard-kbl:          NOTRUN -> [TIMEOUT][30] ([i915#1319]) +2 similar issues
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl3/igt@kms_content_protection@atomic.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [PASS][31] -> [INCOMPLETE][32] ([i915#155] / [i915#2828])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-d-cursor-suspend:
    - shard-kbl:          NOTRUN -> [SKIP][33] ([fdo#109271]) +215 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl2/igt@kms_cursor_crc@pipe-d-cursor-suspend.html

  * igt@kms_cursor_legacy@pipe-d-torture-bo:
    - shard-kbl:          NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#533]) +2 similar issues
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl2/igt@kms_cursor_legacy@pipe-d-torture-bo.html

  * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
    - shard-kbl:          [PASS][35] -> [DMESG-WARN][36] ([i915#180]) +2 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
    - shard-apl:          [PASS][37] -> [DMESG-WARN][38] ([i915#180])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite:
    - shard-snb:          NOTRUN -> [SKIP][39] ([fdo#109271]) +272 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-snb5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite.html

  * igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
    - shard-apl:          NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#533]) +2 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl3/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
    - shard-skl:          [PASS][41] -> [INCOMPLETE][42] ([i915#198] / [i915#2828])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
    - shard-skl:          NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#533])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html

  * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
    - shard-apl:          NOTRUN -> [FAIL][44] ([fdo#108145] / [i915#265]) +3 similar issues
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl2/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html

  * igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
    - shard-kbl:          NOTRUN -> [FAIL][45] ([fdo#108145] / [i915#265]) +2 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl6/igt@kms_plane_alpha_blend@pipe-c-alpha-7efc.html

  * igt@kms_plane_lowres@pipe-d-tiling-yf:
    - shard-skl:          NOTRUN -> [SKIP][46] ([fdo#109271]) +49 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl3/igt@kms_plane_lowres@pipe-d-tiling-yf.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
    - shard-apl:          NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#658]) +7 similar issues
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
    - shard-kbl:          NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#658]) +3 similar issues
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html

  * igt@kms_psr@psr2_cursor_plane_move:
    - shard-iclb:         [PASS][49] -> [SKIP][50] ([fdo#109441]) +3 similar issues
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-iclb6/igt@kms_psr@psr2_cursor_plane_move.html

  * igt@kms_writeback@writeback-check-output:
    - shard-apl:          NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#2437]) +2 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl1/igt@kms_writeback@writeback-check-output.html

  * igt@kms_writeback@writeback-invalid-parameters:
    - shard-skl:          NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#2437])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl3/igt@kms_writeback@writeback-invalid-parameters.html

  * igt@sysfs_clients@fair-0:
    - shard-apl:          NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#2994]) +3 similar issues
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl3/igt@sysfs_clients@fair-0.html

  * igt@sysfs_clients@fair-3:
    - shard-skl:          NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#2994])
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl3/igt@sysfs_clients@fair-3.html

  * igt@sysfs_clients@sema-10:
    - shard-kbl:          NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#2994]) +3 similar issues
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl2/igt@sysfs_clients@sema-10.html

  
#### Possible fixes ####

  * igt@gem_exec_fair@basic-pace-solo@rcs0:
    - shard-kbl:          [FAIL][56] ([i915#2842]) -> [PASS][57]
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl6/igt@gem_exec_fair@basic-pace-solo@rcs0.html

  * igt@gem_exec_fair@basic-pace@vcs0:
    - shard-glk:          [FAIL][58] ([i915#2842]) -> [PASS][59]
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-glk1/igt@gem_exec_fair@basic-pace@vcs0.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-glk6/igt@gem_exec_fair@basic-pace@vcs0.html

  * igt@gem_exec_fair@basic-pace@vcs1:
    - shard-kbl:          [SKIP][60] ([fdo#109271]) -> [PASS][61]
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs1.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html

  * igt@kms_big_fb@x-tiled-32bpp-rotate-0:
    - shard-glk:          [DMESG-WARN][62] ([i915#118] / [i915#95]) -> [PASS][63] +1 similar issue
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-glk3/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-glk5/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html

  * igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled:
    - shard-skl:          [DMESG-WARN][64] ([i915#1982]) -> [PASS][65]
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl5/igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl5/igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-apl:          [INCOMPLETE][66] ([i915#180]) -> [PASS][67]
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-apl3/igt@kms_fbcon_fbt@fbc-suspend.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1:
    - shard-glk:          [FAIL][68] ([i915#2122]) -> [PASS][69] +1 similar issue
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html

  * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
    - shard-apl:          [DMESG-WARN][70] ([i915#180]) -> [PASS][71] +1 similar issue
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html

  * igt@kms_flip@flip-vs-suspend@c-dp1:
    - shard-kbl:          [DMESG-WARN][72] ([i915#180]) -> [PASS][73] +10 similar issues
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl6/igt@kms_flip@flip-vs-suspend@c-dp1.html

  * igt@kms_frontbuffer_tracking@fbc-farfromfence-mmap-gtt:
    - shard-glk:          [FAIL][74] ([i915#2546]) -> [PASS][75]
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-glk5/igt@kms_frontbuffer_tracking@fbc-farfromfence-mmap-gtt.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-glk9/igt@kms_frontbuffer_tracking@fbc-farfromfence-mmap-gtt.html

  * igt@kms_hdr@bpc-switch-suspend:
    - shard-skl:          [INCOMPLETE][76] ([i915#146] / [i915#198] / [i915#2828]) -> [PASS][77]
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl2/igt@kms_hdr@bpc-switch-suspend.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl9/igt@kms_hdr@bpc-switch-suspend.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         [SKIP][78] ([fdo#109441]) -> [PASS][79] +3 similar issues
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html

  * igt@perf_pmu@module-unload:
    - shard-skl:          [DMESG-WARN][80] ([i915#1982] / [i915#262]) -> [PASS][81]
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl5/igt@perf_pmu@module-unload.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl5/igt@perf_pmu@module-unload.html

  
#### Warnings ####

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [SKIP][82] ([fdo#109349]) -> [DMESG-WARN][83] ([i915#1226])
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb4/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
    - shard-iclb:         [SKIP][84] ([i915#2920]) -> [SKIP][85] ([i915#658]) +1 similar issue
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-iclb6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
    - shard-iclb:         [SKIP][86] ([i915#658]) -> [SKIP][87] ([i915#2920]) +1 similar issue
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html

  * igt@runner@aborted:
    - shard-kbl:          ([FAIL][88], [FAIL][89], [FAIL][90], [FAIL][91], [FAIL][92], [FAIL][93], [FAIL][94], [FAIL][95], [FAIL][96], [FAIL][97], [FAIL][98], [FAIL][99], [FAIL][100]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#602] / [i915#92]) -> ([FAIL][101], [FAIL][102], [FAIL][103], [FAIL][104], [FAIL][105]) ([i915#180] / [i915#3002] / [i915#3363] / [i915#92])
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl2/igt@runner@aborted.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl3/igt@runner@aborted.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl2/igt@runner@aborted.html
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl7/igt@runner@aborted.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl7/igt@runner@aborted.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl4/igt@runner@aborted.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl7/igt@runner@aborted.html
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl4/igt@runner@aborted.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl2/igt@runner@aborted.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl1/igt@runner@aborted.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl3/igt@runner@aborted.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl2/igt@runner@aborted.html
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl7/igt@runner@aborted.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl2/igt@runner@aborted.html
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl4/igt@runner@aborted.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl4/igt@runner@aborted.html
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl7/igt@runner@aborted.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-kbl7/igt@runner@aborted.html
    - shard-apl:          ([FAIL][106], [FAIL][107], [FAIL][108], [FAIL][109]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3363]) -> ([FAIL][110], [FAIL][111]) ([i915#180] / [i915#3002] / [i915#3363])
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-apl6/igt@runner@aborted.html
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-apl6/igt@runner@aborted.html
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-apl8/igt@runner@aborted.html
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-apl3/igt@runner@aborted.html
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl3/igt@runner@aborted.html
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-apl1/igt@runner@aborted.html
    - shard-tglb:         ([FAIL][112], [FAIL][113], [FAIL][114]) ([i915#1814] / [i915#2426] / [i915#3002] / [i915#3690]) -> [FAIL][115] ([i915#2426] / [i915#3690])
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-tglb1/igt@runner@aborted.html
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-tglb6/igt@runner@aborted.html
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-tglb7/igt@runner@aborted.html
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-tglb6/igt@runner@aborted.html
    - shard-skl:          ([FAIL][116], [FAIL][117]) ([i915#3002] / [i915#3363]) -> ([FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121]) ([i915#1436] / [i915#1814] / [i915#2029] / [i915#3002] / [i915#3363])
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl5/igt@runner@aborted.html
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl10/igt@runner@aborted.html
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl4/igt@runner@aborted.html
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl5/igt@runner@aborted.html
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl5/igt@runner@aborted.html
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/shard-skl7/igt@runner@aborted.html

  
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
  [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
  [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
  [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
  [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
  [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
  [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
  [i915#2481]: https://gitlab.freedesktop.org/drm/intel/issues/2481
  [i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
  [i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
  [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
  [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
  [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
  [i915#2828]: https://gitlab.freedesktop.org/drm/intel/issues/2828
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
  [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
  [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
  [i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
  [i915#307]: https://gitlab.freedesktop.org/drm/intel/issues/307
  [i915#3070]: https://gitlab.freedesktop.org/drm/intel/issues/3070
  [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
  [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
  [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
  [i915#3690]: https://gitlab.freedesktop.org/drm/intel/issues/3690
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
  [i915#602]: https://gitlab.freedesktop.org/drm/intel/issues/602
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
  [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (11 -> 10)
------------------------------

  Missing    (1): shard-rkl 


Build changes
-------------

  * Linux: CI_DRM_10295 -> Patchwork_20500

  CI-20190529: 20190529
  CI_DRM_10295: 683b7f160eb6993ccfc19e67e3c7111f12946bea @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_6124: 357d5477c93f2bdd3354afe91b89ccfd4ee4fd56 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_20500: dc34e57ce63492d648bec07e172458837b8d71d8 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20500/index.html

[-- Attachment #1.2: Type: text/html, Size: 34557 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
  2021-07-01  0:17     ` Lucas De Marchi
@ 2021-07-01 17:46       ` Lucas De Marchi
  0 siblings, 0 replies; 12+ messages in thread
From: Lucas De Marchi @ 2021-07-01 17:46 UTC (permalink / raw)
  To: Souza, Jose; +Cc: intel-gfx

On Wed, Jun 30, 2021 at 05:17:52PM -0700, Lucas De Marchi wrote:
>On Wed, Jun 30, 2021 at 05:15:00PM -0700, Jose Souza wrote:
>>On Wed, 2021-06-30 at 17:01 -0700, Lucas De Marchi wrote:
>>>Typo: RUNTIME_INFO->stp
>>>
>>>On Wed, Jun 30, 2021 at 04:06:24PM -0700, Anusha Srivatsa wrote:
>>>> On the dmc side,we maintain a lookup table with different display
>>>> stepping-substepping combinations.
>>>>
>>>> Instead of adding new table for every new platform, lets ues
>>>> the stepping info from RUNTIME_INFO(dev_priv)->step
>>>> Adding the helper intel_get_display_step().
>>>>
>>>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>>>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>>>> ---
>>>> drivers/gpu/drm/i915/display/intel_dmc.c | 49 ++++++++++++++++++++++--
>>>> 1 file changed, 45 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
>>>> index f8789d4543bf..c7ff7ff3f412 100644
>>>> --- a/drivers/gpu/drm/i915/display/intel_dmc.c
>>>> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
>>>> @@ -266,14 +266,55 @@ static const struct stepping_info icl_stepping_info[] = {
>>>> };
>>>>
>>>> static const struct stepping_info no_stepping_info = { '*', '*' };
>>>> +struct stepping_info *display_step;
>>>> +
>>>> +static struct stepping_info *
>>>> +intel_get_display_stepping(struct intel_step_info step)
>>>> +{
>>>> +
>>>> +	switch (step.display_step) {
>>>> +	case STEP_A0:
>>>> +		display_step->stepping = 'A';
>>>> +		display_step->substepping = '0';
>>>> +		break;
>>>> +	case STEP_A2:
>>>> +		display_step->stepping = 'A';
>>>> +		display_step->substepping = '2';
>>>> +		break;
>>>> +	case STEP_B0:
>>>> +		display_step->stepping = 'B';
>>>> +		display_step->substepping = '0';
>>>> +		break;
>>>> +	case STEP_B1:
>>>> +		display_step->stepping = 'B';
>>>> +		display_step->substepping = '1';
>>>> +		break;
>>>> +	case STEP_C0:
>>>> +		display_step->stepping = 'C';
>>>> +		display_step->substepping = '0';
>>>> +		break;
>>>> +	case STEP_D0:
>>>> +		display_step->stepping = 'D';
>>>> +		display_step->substepping = '0';
>>>> +		break;
>>>> +	default:
>>>> +		display_step->stepping = '*';
>>>> +		display_step->substepping = '*';
>>>> +		break;
>>>> +	}
>>>
>>>
>>>"crazy" idea that would avoid this type of conversion:
>>>changing the step enum to be:
>>>
>>>
>>>#define make_step(letter, num) (int)(((letter) << 8 ) | (num))
>>>
>>>STEP_A0 = make_step('A', '0'),
>>>STEP_A1 = make_step('A', '1'),
>>
>>Looks a good idea to me, we could also keep it u8 using 4bits for each if there is memory concerns.
>
>humn... indeed. Not much a concern actually, but not having to change
>additional code is already a good thing.
>
>
>I hope no stepping goes beyond Z9 :)

I take that out. Even if we would do (number - 'A'), there is not enough
room in 4bits to handle until Z. In fact we could go only until P8 - so
if we are going that route we will need to have some extra build checks
that we don't go beyond that.

Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
  2021-07-01  0:01 ` [Intel-gfx] [PATCH] " Lucas De Marchi
  2021-07-01  0:15   ` Souza, Jose
@ 2021-07-02  7:49   ` Jani Nikula
  2021-07-04  5:34     ` Lucas De Marchi
  1 sibling, 1 reply; 12+ messages in thread
From: Jani Nikula @ 2021-07-02  7:49 UTC (permalink / raw)
  To: Lucas De Marchi, Anusha Srivatsa; +Cc: intel-gfx

On Wed, 30 Jun 2021, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> Typo: RUNTIME_INFO->stp
>
> On Wed, Jun 30, 2021 at 04:06:24PM -0700, Anusha Srivatsa wrote:
>>On the dmc side,we maintain a lookup table with different display
>>stepping-substepping combinations.
>>
>>Instead of adding new table for every new platform, lets ues
>>the stepping info from RUNTIME_INFO(dev_priv)->step
>>Adding the helper intel_get_display_step().
>>
>>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>>Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>>---
>> drivers/gpu/drm/i915/display/intel_dmc.c | 49 ++++++++++++++++++++++--
>> 1 file changed, 45 insertions(+), 4 deletions(-)
>>
>>diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
>>index f8789d4543bf..c7ff7ff3f412 100644
>>--- a/drivers/gpu/drm/i915/display/intel_dmc.c
>>+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
>>@@ -266,14 +266,55 @@ static const struct stepping_info icl_stepping_info[] = {
>> };
>>
>> static const struct stepping_info no_stepping_info = { '*', '*' };
>>+struct stepping_info *display_step;
>>+
>>+static struct stepping_info *
>>+intel_get_display_stepping(struct intel_step_info step)
>>+{
>>+
>>+	switch (step.display_step) {
>>+	case STEP_A0:
>>+		display_step->stepping = 'A';
>>+		display_step->substepping = '0';
>>+		break;
>>+	case STEP_A2:
>>+		display_step->stepping = 'A';
>>+		display_step->substepping = '2';
>>+		break;
>>+	case STEP_B0:
>>+		display_step->stepping = 'B';
>>+		display_step->substepping = '0';
>>+		break;
>>+	case STEP_B1:
>>+		display_step->stepping = 'B';
>>+		display_step->substepping = '1';
>>+		break;
>>+	case STEP_C0:
>>+		display_step->stepping = 'C';
>>+		display_step->substepping = '0';
>>+		break;
>>+	case STEP_D0:
>>+		display_step->stepping = 'D';
>>+		display_step->substepping = '0';
>>+		break;
>>+	default:
>>+		display_step->stepping = '*';
>>+		display_step->substepping = '*';
>>+		break;
>>+	}
>
>
> "crazy" idea that would avoid this type of conversion:
> changing the step enum to be:
>
>
> #define make_step(letter, num) (int)(((letter) << 8 ) | (num))
>
> STEP_A0 = make_step('A', '0'),
> STEP_A1 = make_step('A', '1'),
>
> and adapt the rest of the code to play with u16 instead of u8, and
> handle the STEP_FUTURE/STEP_NONE/STEP_FOREVER.
> Maybe it is crazy, dunno.
>
> +Jani / +Jose. Thoughts?

Frankly, I think all of this should be incorporated to intel_step.[ch]
instead of having a semi-overlapping handling here. Just look at the
amount of duplication already.


BR,
Jani.

>
>
> For this version the next comment is probably more important.
>
>>+	return display_step;
>>+}
>>
>> static const struct stepping_info *
>> intel_get_stepping_info(struct drm_i915_private *dev_priv)
>> {
>> 	const struct stepping_info *si;
>>+	struct intel_step_info step = RUNTIME_INFO(dev_priv)->step;
>> 	unsigned int size;
>>
>>-	if (IS_ICELAKE(dev_priv)) {
>>+	if (DISPLAY_VER(dev_priv) >= 12) {
>>+		si = intel_get_display_stepping(step);
>>+	} else if (IS_ICELAKE(dev_priv)) {
>> 		size = ARRAY_SIZE(icl_stepping_info);
>> 		si = icl_stepping_info;
>
> can we move the other ones too? Just use display_step for all platforms.
> Notice that before the separation we will have display_step ==
> graphics_step, so it should just work.
>
>
> Lucas De Marchi
>
>> 	} else if (IS_SKYLAKE(dev_priv)) {
>>@@ -287,10 +328,10 @@ intel_get_stepping_info(struct drm_i915_private *dev_priv)
>> 		si = NULL;
>> 	}
>>
>>-	if (INTEL_REVID(dev_priv) < size)
>>-		return si + INTEL_REVID(dev_priv);
>>+	if (DISPLAY_VER(dev_priv) < 12)
>>+		return INTEL_REVID(dev_priv) < size ? si + INTEL_REVID(dev_priv) : &no_stepping_info;
>>
>>-	return &no_stepping_info;
>>+	return si;
>> }
>>
>> static void gen9_set_dc_state_debugmask(struct drm_i915_private *dev_priv)
>>-- 
>>2.32.0
>>

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
  2021-07-02  7:49   ` Jani Nikula
@ 2021-07-04  5:34     ` Lucas De Marchi
  2021-07-05  7:45       ` Jani Nikula
  0 siblings, 1 reply; 12+ messages in thread
From: Lucas De Marchi @ 2021-07-04  5:34 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

On Fri, Jul 02, 2021 at 10:49:05AM +0300, Jani Nikula wrote:
>On Wed, 30 Jun 2021, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>> Typo: RUNTIME_INFO->stp
>>
>> On Wed, Jun 30, 2021 at 04:06:24PM -0700, Anusha Srivatsa wrote:
>>>On the dmc side,we maintain a lookup table with different display
>>>stepping-substepping combinations.
>>>
>>>Instead of adding new table for every new platform, lets ues
>>>the stepping info from RUNTIME_INFO(dev_priv)->step
>>>Adding the helper intel_get_display_step().
>>>
>>>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>>>Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>>>---
>>> drivers/gpu/drm/i915/display/intel_dmc.c | 49 ++++++++++++++++++++++--
>>> 1 file changed, 45 insertions(+), 4 deletions(-)
>>>
>>>diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
>>>index f8789d4543bf..c7ff7ff3f412 100644
>>>--- a/drivers/gpu/drm/i915/display/intel_dmc.c
>>>+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
>>>@@ -266,14 +266,55 @@ static const struct stepping_info icl_stepping_info[] = {
>>> };
>>>
>>> static const struct stepping_info no_stepping_info = { '*', '*' };
>>>+struct stepping_info *display_step;
>>>+
>>>+static struct stepping_info *
>>>+intel_get_display_stepping(struct intel_step_info step)
>>>+{
>>>+
>>>+	switch (step.display_step) {
>>>+	case STEP_A0:
>>>+		display_step->stepping = 'A';
>>>+		display_step->substepping = '0';
>>>+		break;
>>>+	case STEP_A2:
>>>+		display_step->stepping = 'A';
>>>+		display_step->substepping = '2';
>>>+		break;
>>>+	case STEP_B0:
>>>+		display_step->stepping = 'B';
>>>+		display_step->substepping = '0';
>>>+		break;
>>>+	case STEP_B1:
>>>+		display_step->stepping = 'B';
>>>+		display_step->substepping = '1';
>>>+		break;
>>>+	case STEP_C0:
>>>+		display_step->stepping = 'C';
>>>+		display_step->substepping = '0';
>>>+		break;
>>>+	case STEP_D0:
>>>+		display_step->stepping = 'D';
>>>+		display_step->substepping = '0';
>>>+		break;
>>>+	default:
>>>+		display_step->stepping = '*';
>>>+		display_step->substepping = '*';
>>>+		break;
>>>+	}
>>
>>
>> "crazy" idea that would avoid this type of conversion:
>> changing the step enum to be:
>>
>>
>> #define make_step(letter, num) (int)(((letter) << 8 ) | (num))
>>
>> STEP_A0 = make_step('A', '0'),
>> STEP_A1 = make_step('A', '1'),
>>
>> and adapt the rest of the code to play with u16 instead of u8, and
>> handle the STEP_FUTURE/STEP_NONE/STEP_FOREVER.
>> Maybe it is crazy, dunno.
>>
>> +Jani / +Jose. Thoughts?
>
>Frankly, I think all of this should be incorporated to intel_step.[ch]
>instead of having a semi-overlapping handling here. Just look at the
>amount of duplication already.

I guess you missed I gave the same suggestion below and that there is
already a new version of this patch? Question here was about going a
step further to avoid the conversion STEP_* to 2 chars.

thanks
Lucas De Marchi

>
>
>BR,
>Jani.
>
>>
>>
>> For this version the next comment is probably more important.
>>
>>>+	return display_step;
>>>+}
>>>
>>> static const struct stepping_info *
>>> intel_get_stepping_info(struct drm_i915_private *dev_priv)
>>> {
>>> 	const struct stepping_info *si;
>>>+	struct intel_step_info step = RUNTIME_INFO(dev_priv)->step;
>>> 	unsigned int size;
>>>
>>>-	if (IS_ICELAKE(dev_priv)) {
>>>+	if (DISPLAY_VER(dev_priv) >= 12) {
>>>+		si = intel_get_display_stepping(step);
>>>+	} else if (IS_ICELAKE(dev_priv)) {
>>> 		size = ARRAY_SIZE(icl_stepping_info);
>>> 		si = icl_stepping_info;
>>
>> can we move the other ones too? Just use display_step for all platforms.
>> Notice that before the separation we will have display_step ==
>> graphics_step, so it should just work.
>>
>>
>> Lucas De Marchi
>>
>>> 	} else if (IS_SKYLAKE(dev_priv)) {
>>>@@ -287,10 +328,10 @@ intel_get_stepping_info(struct drm_i915_private *dev_priv)
>>> 		si = NULL;
>>> 	}
>>>
>>>-	if (INTEL_REVID(dev_priv) < size)
>>>-		return si + INTEL_REVID(dev_priv);
>>>+	if (DISPLAY_VER(dev_priv) < 12)
>>>+		return INTEL_REVID(dev_priv) < size ? si + INTEL_REVID(dev_priv) : &no_stepping_info;
>>>
>>>-	return &no_stepping_info;
>>>+	return si;
>>> }
>>>
>>> static void gen9_set_dc_state_debugmask(struct drm_i915_private *dev_priv)
>>>--
>>>2.32.0
>>>
>
>-- 
>Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC
  2021-07-04  5:34     ` Lucas De Marchi
@ 2021-07-05  7:45       ` Jani Nikula
  0 siblings, 0 replies; 12+ messages in thread
From: Jani Nikula @ 2021-07-05  7:45 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

On Sat, 03 Jul 2021, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Fri, Jul 02, 2021 at 10:49:05AM +0300, Jani Nikula wrote:
>>Frankly, I think all of this should be incorporated to intel_step.[ch]
>>instead of having a semi-overlapping handling here. Just look at the
>>amount of duplication already.
>
> I guess you missed I gave the same suggestion below and that there is
> already a new version of this patch? Question here was about going a
> step further to avoid the conversion STEP_* to 2 chars.

Sorry for the noise.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-07-05  7:45 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-30 23:06 [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC Anusha Srivatsa
2021-06-30 23:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-06-30 23:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-06-30 23:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-01  0:01 ` [Intel-gfx] [PATCH] " Lucas De Marchi
2021-07-01  0:15   ` Souza, Jose
2021-07-01  0:17     ` Lucas De Marchi
2021-07-01 17:46       ` Lucas De Marchi
2021-07-02  7:49   ` Jani Nikula
2021-07-04  5:34     ` Lucas De Marchi
2021-07-05  7:45       ` Jani Nikula
2021-07-01  5:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).