Re: [Intel-gfx] [PATCH 06/14] drm/i915/guc/slpc: Enable SLPC and add related H2G events

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2740 bytes --]

Hi Vinay,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm/drm-next v5.14-rc2 next-20210723]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Vinay-Belgaumkar/drm-i915-guc-Enable-GuC-based-power-management-features/20210722-001528
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/14352081e4f18759e70413f3be4151d623c97b8c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Vinay-Belgaumkar/drm-i915-guc-Enable-GuC-based-power-management-features/20210722-001528
        git checkout 14352081e4f18759e70413f3be4151d623c97b8c
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/i915/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c:217:5: sparse: sparse: symbol 'slpc_decode_min_freq' was not declared. Should it be static?
>> drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c:229:5: sparse: sparse: symbol 'slpc_decode_max_freq' was not declared. Should it be static?

vim +/slpc_decode_min_freq +217 drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c

   216	
 > 217	u32 slpc_decode_min_freq(struct intel_guc_slpc *slpc)
   218	{
   219		struct slpc_shared_data *data = slpc->vaddr;
   220	
   221		GEM_BUG_ON(!slpc->vma);
   222	
   223		return	DIV_ROUND_CLOSEST(
   224			REG_FIELD_GET(SLPC_MIN_UNSLICE_FREQ_MASK,
   225				data->task_state_data.freq) *
   226			GT_FREQUENCY_MULTIPLIER, GEN9_FREQ_SCALER);
   227	}
   228	
 > 229	u32 slpc_decode_max_freq(struct intel_guc_slpc *slpc)
   230	{
   231		struct slpc_shared_data *data = slpc->vaddr;
   232	
   233		GEM_BUG_ON(!slpc->vma);
   234	
   235		return	DIV_ROUND_CLOSEST(
   236			REG_FIELD_GET(SLPC_MAX_UNSLICE_FREQ_MASK,
   237				data->task_state_data.freq) *
   238			GT_FREQUENCY_MULTIPLIER, GEN9_FREQ_SCALER);
   239	}
   240	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 42206 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx