intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Correct SFC_DONE register offset
Date: Wed, 28 Jul 2021 18:05:55 -0700	[thread overview]
Message-ID: <20210729010555.GI1556418@mdroper-desk1.amr.corp.intel.com> (raw)
In-Reply-To: <20210728233411.2365788-1-matthew.d.roper@intel.com>

On Wed, Jul 28, 2021 at 04:34:11PM -0700, Matt Roper wrote:
> The register offset for SFC_DONE was missing a '0' at the end, causing
> us to read from a non-existent register address.  We only use this
> register in error state dumps so the mistake hasn't caused any real
> problems, but fixing it will hopefully make the error state dumps a bit
> more useful for debugging.
> 
> Fixes: e50dbdbfd9fb ("drm/i915/tgl: Add SFC instdone to error state")
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>

Hmm, actually on a closer look it appears this register may have been
removed completely from media version 12.  It will return in media
version 13 at this offset, but for now I guess we should just drop it
completely.


Matt

> ---
>  drivers/gpu/drm/i915/i915_reg.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 70eed4fe3fe3..49dd5e75429e 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -430,7 +430,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
>  #define   GEN12_HCP_SFC_LOCK_ACK_BIT		REG_BIT(1)
>  #define   GEN12_HCP_SFC_USAGE_BIT			REG_BIT(0)
>  
> -#define GEN12_SFC_DONE(n)		_MMIO(0x1cc00 + (n) * 0x100)
> +#define GEN12_SFC_DONE(n)		_MMIO(0x1cc000 + (n) * 0x1000)
>  #define GEN12_SFC_DONE_MAX		4
>  
>  #define RING_PP_DIR_BASE(base)		_MMIO((base) + 0x228)
> -- 
> 2.25.4
> 

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-07-29  1:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 23:34 Matt Roper
2021-07-29  1:05 ` Matt Roper [this message]
2021-07-30 22:22   ` Matt Roper
2021-08-02 10:29     ` Mika Kuoppala
2021-07-29  1:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-07-29  6:45 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210729010555.GI1556418@mdroper-desk1.amr.corp.intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --subject='Re: [Intel-gfx] [PATCH] drm/i915: Correct SFC_DONE register offset' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).