intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Jose Souza <jose.souza@intel.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/xehp: Fix missing sentinel on mcr_ranges_xehp
Date: Fri, 30 Jul 2021 18:10:13 -0700	[thread overview]
Message-ID: <20210731011013.xkqxitcngnd52b7r@ldmartin-desk2> (raw)
In-Reply-To: <20210730191859.GV1556418@mdroper-desk1.amr.corp.intel.com>

I guess I forgot to Cc dri-devel. Doing it now.

Lucas De Marchi

On Fri, Jul 30, 2021 at 12:18:59PM -0700, Matt Roper wrote:
>On Fri, Jul 30, 2021 at 12:11:15PM -0700, Lucas De Marchi wrote:
>> There's a missing sentinel since we are not using ARRAY_SIZE(), but rather
>> checking that the .start is 0 to stop the iteration in mcr_range().
>>
>> 	BUG: KASAN: global-out-of-bounds in mcr_range.isra.0+0x69/0xa0 [i915]
>> 	Read of size 4 at addr ffffffffa0889928 by task modprobe/3881
>>
>> Fixes: d8905ba705ab ("drm/i915/xehp: Define multicast register ranges")
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
>Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>
>> ---
>>  drivers/gpu/drm/i915/gt/intel_workarounds.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> index 9173df59821a..053fa7251cd0 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> @@ -2000,6 +2000,7 @@ static const struct mcr_range mcr_ranges_xehp[] = {
>>  	{ .start =  0xdc00, .end =  0xffff },
>>  	{ .start = 0x17000, .end = 0x17fff },
>>  	{ .start = 0x24a00, .end = 0x24a7f },
>> +	{},
>>  };
>>
>>  static bool mcr_range(struct drm_i915_private *i915, u32 offset)
>> --
>> 2.31.1
>>
>
>-- 
>Matt Roper
>Graphics Software Engineer
>VTT-OSGC Platform Enablement
>Intel Corporation
>(916) 356-2795

  reply	other threads:[~2021-07-31  1:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 19:11 [Intel-gfx] [PATCH] drm/i915/xehp: Fix missing sentinel on mcr_ranges_xehp Lucas De Marchi
2021-07-30 19:18 ` Matt Roper
2021-07-31  1:10   ` Lucas De Marchi [this message]
2021-07-30 19:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-07-31  1:31 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-07-31  2:07   ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210731011013.xkqxitcngnd52b7r@ldmartin-desk2 \
    --to=lucas.demarchi@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).