From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64A47C4338F for ; Sat, 7 Aug 2021 05:02:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17690610FD for ; Sat, 7 Aug 2021 05:02:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 17690610FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3F0916E08C; Sat, 7 Aug 2021 05:02:26 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB9D96E08C; Sat, 7 Aug 2021 05:02:24 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10068"; a="212623634" X-IronPort-AV: E=Sophos;i="5.84,301,1620716400"; d="scan'208";a="212623634" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2021 22:02:24 -0700 X-IronPort-AV: E=Sophos;i="5.84,301,1620716400"; d="scan'208";a="482016359" Received: from mdroper-desk1.fm.intel.com (HELO mdroper-desk1.amr.corp.intel.com) ([10.1.27.134]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2021 22:02:23 -0700 Date: Fri, 6 Aug 2021 22:02:22 -0700 From: Matt Roper To: Daniel Vetter Cc: John Harrison , Matthew Brost , intel-gfx , dri-devel Message-ID: <20210807050222.GP1556418@mdroper-desk1.amr.corp.intel.com> References: <20210728192100.132425-1-matthew.brost@intel.com> <23d6e809-1d6e-ae35-1aee-e6f0c8c90419@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH] drm/i915: Disable bonding on gen12+ platforms X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Aug 06, 2021 at 08:54:59PM +0200, Daniel Vetter wrote: > On Fri, Aug 6, 2021 at 8:25 PM John Harrison wrote: > > On 7/28/2021 12:21, Matthew Brost wrote: > > > Disable bonding on gen12+ platforms aside from ones already supported by > > > the i915 - TGL, RKL, and ADL-S. > > > > > > Signed-off-by: Matthew Brost > > > --- > > > drivers/gpu/drm/i915/gem/i915_gem_context.c | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c > > > index 05c3ee191710..9c3672bac0e2 100644 > > > --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c > > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c > > > @@ -446,6 +446,13 @@ set_proto_ctx_engines_bond(struct i915_user_extension __user *base, void *data) > > > u16 idx, num_bonds; > > > int err, n; > > > > > > + if (GRAPHICS_VER(i915) >= 12 && !IS_TIGERLAKE(i915) && > > > + !IS_ROCKETLAKE(i915) && !IS_ALDERLAKE_S(i915)) { > > > + drm_dbg(&i915->drm, > > > + "Bonding on gen12+ aside from TGL, RKL, and ADL_S not allowed\n"); > > I would have said not supported rather than not allowed. Either way: > > Reviewed-by: John Harrison > > Either is fine with me. > > Acked-by: Daniel Vetter > Applied to drm-intel-gt-next (with the suggested debug message wording tweak). Thanks for the patch and reviews. Matt > > > > > + return -ENODEV; > > > + } > > > + > > > if (get_user(idx, &ext->virtual_index)) > > > return -EFAULT; > > > > > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795