Re: [Intel-gfx] [PATCH 0/4] Enable GuC submission by default on DG1

From: Matthew Brost <matthew.brost@intel.com>
To: "Thomas Hellström (Intel)" <thomas_os@shipmail.org>
Cc: Daniel Vetter <daniel@ffwll.ch>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 0/4] Enable GuC submission by default on DG1
Date: Sat, 7 Aug 2021 17:20:53 +0000	[thread overview]
Message-ID: <20210807172053.GA108264@DUT151-ICLU.fm.intel.com> (raw)
In-Reply-To: <b20f28eb-9efc-3d4e-57fa-c52c255063a5@shipmail.org>

On Fri, Aug 06, 2021 at 01:34:33PM +0200, Thomas Hellström (Intel) wrote:
> Hi,
> 
> On 8/3/21 7:26 PM, Matthew Brost wrote:
> > On Tue, Aug 03, 2021 at 02:15:13PM +0200, Daniel Vetter wrote:
> > > On Tue, Aug 3, 2021 at 6:53 AM Matthew Brost <matthew.brost@intel.com> wrote:
> > > > Minimum set of patches to enable GuC submission on DG1 and enable it by
> > > > default.
> > > > 
> > > > A little difficult to test as IGTs do not work with DG1 due to a bunch
> > > > of uAPI features being disabled (e.g. relocations, caching memory
> > > > options, etc...).
> > > Matt Auld has an igt series which fixes a lot of this stuff, would be
> > > good to do at least a Test-With run with that.
> > > 
> It looks like Maarten now merged Matt's series to IGT.

Great.

> 
> There is a series on IGT trybot with pending work to have some igt tests
> support relocations,
> 
> https://patchwork.freedesktop.org/series/92043/
>

Will take a look but at the moment we are blocked because SLPC won't
init on the DG1 in CI but it works just fine on all other parts I've
tried in RIL. We suspect the DG1 in CI is an early stepping and we may
be missing workarounds. Have a possible fix, just need to try it out. We
also might just want to replace the DG1 part in CI with a newer
stepping so we don't have to upstream WAs for non-shipping parts.

> One of the tests that have WIP fixes is gem_exec_whisper, and that
> particular test has historically shown occasional hangs with GuC submission
> on DG1 so it would be very desirable if we could make that test in
> particular work (I haven't verified that that's the case) reliably.
>

I just ran gem_exec_whisper on DG1, with GuC submission, and kernel
hacked to allow relocs. It passed for me. Only 1 run though so it is
possible there are still intermittent issues. We really need to get CI
up and running ASAP on all platforms where GuC submission is POR.
Perhaps on all gen11+ platforms as well because GuC submission is
supported and the more coverage we can get, the better.

> Also the following series:
> 
> https://patchwork.freedesktop.org/series/93455/

I'll check this series out too.

Matt

> 
> tries a bit harder to get some more tests running, squashing the above
> series on top of latest IGT.
> 
> Thanks,
> /Thomas
> 
> 