From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7F95C4338F for ; Thu, 12 Aug 2021 16:04:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AEC8604AC for ; Thu, 12 Aug 2021 16:04:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7AEC8604AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF7956E42A; Thu, 12 Aug 2021 16:04:45 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5A3646E42A for ; Thu, 12 Aug 2021 16:04:44 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10074"; a="215372717" X-IronPort-AV: E=Sophos;i="5.84,316,1620716400"; d="scan'208";a="215372717" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2021 09:01:25 -0700 X-IronPort-AV: E=Sophos;i="5.84,316,1620716400"; d="scan'208";a="517506148" Received: from ideak-desk.fi.intel.com ([10.237.68.141]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2021 09:01:21 -0700 Date: Thu, 12 Aug 2021 19:01:18 +0300 From: Imre Deak To: Swati Sharma Cc: intel-gfx@lists.freedesktop.org, Ankit Nautiyal , Uma Shankar , Jani Nikula , Ville Syrj_l_ , Manasi Navare , Jos_ Roberto de Souza , Sean Paul , stable@vger.kernel.org Message-ID: <20210812160118.GH2600583@ideak-desk.fi.intel.com> References: <20210812131107.5531-1-swati2.sharma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210812131107.5531-1-swati2.sharma@intel.com> Subject: Re: [Intel-gfx] [v3][PATCH] drm/i915/display: Drop redundant debug print X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Aug 12, 2021 at 06:41:07PM +0530, Swati Sharma wrote: > drm_dp_dpcd_read/write already has debug error message. > Drop redundant error messages which gives false > status even if correct value is read in drm_dp_dpcd_read(). > > v2: -Added fixes tag (Ankit) > v3: -Fixed build error (CI) > > Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery") > Cc: Swati Sharma > Cc: Ankit Nautiyal > Cc: Uma Shankar (v2) > Cc: Jani Nikula > Cc: "Ville Syrj_l_" > Cc: Imre Deak > Cc: Manasi Navare > Cc: Uma Shankar > Cc: "Jos_ Roberto de Souza" > Cc: Sean Paul > Cc: # v5.12+ > > Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@intel.com > > Signed-off-by: Swati Sharma > --- > drivers/gpu/drm/i915/display/intel_dp.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index c386ef8eb200..2526c9c8c690 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -3864,23 +3864,18 @@ static void intel_dp_check_device_service_irq(struct intel_dp *intel_dp) > > static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp) > { > - struct drm_i915_private *i915 = dp_to_i915(intel_dp); > u8 val; > > if (intel_dp->dpcd[DP_DPCD_REV] < 0x11) > return; > > if (drm_dp_dpcd_readb(&intel_dp->aux, > - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) { > - drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n"); The only problem seems to be that for !val the debug print is incorrect, so maybe just have a separate check for that after this one for the read() and return w/o the debug message? Is it really a stable material, since the change wouldn't have any effect for regular users? > + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) > return; > - } > > if (drm_dp_dpcd_writeb(&intel_dp->aux, > - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) { > - drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n"); > + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) > return; > - } > > if (val & HDMI_LINK_STATUS_CHANGED) > intel_dp_handle_hdmi_link_status_change(intel_dp); > -- > 2.25.1 >