From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FE53C4338F for ; Thu, 12 Aug 2021 23:18:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4751860E93 for ; Thu, 12 Aug 2021 23:18:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4751860E93 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE0D76E49C; Thu, 12 Aug 2021 23:18:17 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B1F76E49C for ; Thu, 12 Aug 2021 23:18:15 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10074"; a="212354298" X-IronPort-AV: E=Sophos;i="5.84,317,1620716400"; d="scan'208";a="212354298" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2021 16:18:15 -0700 X-IronPort-AV: E=Sophos;i="5.84,317,1620716400"; d="scan'208";a="517656951" Received: from testes-mobl.amr.corp.intel.com (HELO ldmartin-desk2) ([10.209.37.214]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2021 16:18:14 -0700 Date: Thu, 12 Aug 2021 16:18:14 -0700 From: Lucas De Marchi To: "Souza, Jose" Cc: "Roper, Matthew D" , "intel-gfx@lists.freedesktop.org" , Joonas Lahtinen Message-ID: <20210812231814.7yexelqyiprus4jk@ldmartin-desk2> X-Patchwork-Hint: comment References: <20210805163647.801064-1-matthew.d.roper@intel.com> <20210805163647.801064-6-matthew.d.roper@intel.com> <267531628ba0b49b722f4feef31ca57e9ac61e78.camel@intel.com> <20210812231411.toiiqfiw2r5mga5f@ldmartin-desk2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210812231411.toiiqfiw2r5mga5f@ldmartin-desk2> Subject: Re: [Intel-gfx] [PATCH v5 5/9] drm/i915/xehpsdv: factor out function to read RP_STATE_CAP X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Aug 12, 2021 at 04:14:11PM -0700, Lucas De Marchi wrote: >On Thu, Aug 12, 2021 at 03:49:17PM -0700, Jose Souza wrote: >>On Thu, 2021-08-05 at 09:36 -0700, Matt Roper wrote: >>>From: Lucas De Marchi >>> >>>Instead of maintaining the same if ladder in 3 different places, add a >>>function to read RP_STATE_CAP. >>> >> >>gt_perf_status looks a good next candidate to have the same handling as rp_state_cap > >I was actually hoping to remove it: >https://patchwork.freedesktop.org/patch/397131/ > >Discussion there stalled though. +Joonas and btw, the main reason for that patch is xehpsdv: we shouldn't access any register from the MCHBAR mirror Lucas De Marchi