* [Intel-gfx] [v3][PATCH] drm/i915/display: Drop redundant debug print
@ 2021-08-12 13:11 Swati Sharma
2021-08-12 16:01 ` Imre Deak
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Swati Sharma @ 2021-08-12 13:11 UTC (permalink / raw)
To: intel-gfx
Cc: Swati Sharma, Ankit Nautiyal, Uma Shankar, Jani Nikula,
Ville Syrj_l_, Imre Deak, Manasi Navare, Jos_ Roberto de Souza,
Sean Paul, stable
drm_dp_dpcd_read/write already has debug error message.
Drop redundant error messages which gives false
status even if correct value is read in drm_dp_dpcd_read().
v2: -Added fixes tag (Ankit)
v3: -Fixed build error (CI)
Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery")
Cc: Swati Sharma <swati2.sharma@intel.com>
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com> (v2)
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: "Ville Syrj_l_" <ville.syrjala@linux.intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: "Jos_ Roberto de Souza" <jose.souza@intel.com>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: <stable@vger.kernel.org> # v5.12+
Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@intel.com
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index c386ef8eb200..2526c9c8c690 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3864,23 +3864,18 @@ static void intel_dp_check_device_service_irq(struct intel_dp *intel_dp)
static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
{
- struct drm_i915_private *i915 = dp_to_i915(intel_dp);
u8 val;
if (intel_dp->dpcd[DP_DPCD_REV] < 0x11)
return;
if (drm_dp_dpcd_readb(&intel_dp->aux,
- DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) {
- drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n");
+ DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val)
return;
- }
if (drm_dp_dpcd_writeb(&intel_dp->aux,
- DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) {
- drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n");
+ DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
return;
- }
if (val & HDMI_LINK_STATUS_CHANGED)
intel_dp_handle_hdmi_link_status_change(intel_dp);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [v3][PATCH] drm/i915/display: Drop redundant debug print
2021-08-12 13:11 [Intel-gfx] [v3][PATCH] drm/i915/display: Drop redundant debug print Swati Sharma
@ 2021-08-12 16:01 ` Imre Deak
2021-08-16 11:53 ` Sharma, Swati2
2021-08-12 18:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Drop redundant debug print (rev3) Patchwork
2021-08-12 23:12 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Imre Deak @ 2021-08-12 16:01 UTC (permalink / raw)
To: Swati Sharma
Cc: intel-gfx, Ankit Nautiyal, Uma Shankar, Jani Nikula,
Ville Syrj_l_, Manasi Navare, Jos_ Roberto de Souza, Sean Paul,
stable
On Thu, Aug 12, 2021 at 06:41:07PM +0530, Swati Sharma wrote:
> drm_dp_dpcd_read/write already has debug error message.
> Drop redundant error messages which gives false
> status even if correct value is read in drm_dp_dpcd_read().
>
> v2: -Added fixes tag (Ankit)
> v3: -Fixed build error (CI)
>
> Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery")
> Cc: Swati Sharma <swati2.sharma@intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Cc: Uma Shankar <uma.shankar@intel.com> (v2)
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: "Ville Syrj_l_" <ville.syrjala@linux.intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Cc: Uma Shankar <uma.shankar@intel.com>
> Cc: "Jos_ Roberto de Souza" <jose.souza@intel.com>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: <stable@vger.kernel.org> # v5.12+
>
> Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@intel.com
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index c386ef8eb200..2526c9c8c690 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3864,23 +3864,18 @@ static void intel_dp_check_device_service_irq(struct intel_dp *intel_dp)
>
> static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
> {
> - struct drm_i915_private *i915 = dp_to_i915(intel_dp);
> u8 val;
>
> if (intel_dp->dpcd[DP_DPCD_REV] < 0x11)
> return;
>
> if (drm_dp_dpcd_readb(&intel_dp->aux,
> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) {
> - drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n");
The only problem seems to be that for !val the debug print is incorrect,
so maybe just have a separate check for that after this one for the read()
and return w/o the debug message?
Is it really a stable material, since the change wouldn't have any
effect for regular users?
> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val)
> return;
> - }
>
> if (drm_dp_dpcd_writeb(&intel_dp->aux,
> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) {
> - drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n");
> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
> return;
> - }
>
> if (val & HDMI_LINK_STATUS_CHANGED)
> intel_dp_handle_hdmi_link_status_change(intel_dp);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Drop redundant debug print (rev3)
2021-08-12 13:11 [Intel-gfx] [v3][PATCH] drm/i915/display: Drop redundant debug print Swati Sharma
2021-08-12 16:01 ` Imre Deak
@ 2021-08-12 18:44 ` Patchwork
2021-08-12 23:12 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-08-12 18:44 UTC (permalink / raw)
To: Swati Sharma; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3460 bytes --]
== Series Details ==
Series: drm/i915/display: Drop redundant debug print (rev3)
URL : https://patchwork.freedesktop.org/series/93025/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10478 -> Patchwork_20805
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/index.html
Known issues
------------
Here are the changes found in Patchwork_20805 that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- fi-kbl-soraka: NOTRUN -> [FAIL][1] ([i915#3895])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/fi-kbl-soraka/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-1115g4: [PASS][2] -> [FAIL][3] ([i915#1888])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0.html
* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][4] ([fdo#109271]) +48 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/fi-pnv-d510/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@gem_exec_parallel@engines@userptr:
- fi-pnv-d510: [INCOMPLETE][5] ([i915#299]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/fi-pnv-d510/igt@gem_exec_parallel@engines@userptr.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/fi-pnv-d510/igt@gem_exec_parallel@engines@userptr.html
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-1115g4: [FAIL][7] ([i915#1888]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: [DMESG-WARN][9] ([i915#3958]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#299]: https://gitlab.freedesktop.org/drm/intel/issues/299
[i915#3895]: https://gitlab.freedesktop.org/drm/intel/issues/3895
[i915#3958]: https://gitlab.freedesktop.org/drm/intel/issues/3958
Participating hosts (38 -> 35)
------------------------------
Additional (1): fi-kbl-soraka
Missing (4): fi-bdw-samus fi-bsw-cyan bat-jsl-1 fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_10478 -> Patchwork_20805
CI-20190529: 20190529
CI_DRM_10478: d65ef4634e5c795a6a4df1d198992c70e9692fb3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6174: 0de07aea208ea848066f4f6af04c13e25d23d9a7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20805: 0c814e774ec968d72901d505d1ddeee88ed15109 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
0c814e774ec9 drm/i915/display: Drop redundant debug print
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/index.html
[-- Attachment #2: Type: text/html, Size: 4278 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Drop redundant debug print (rev3)
2021-08-12 13:11 [Intel-gfx] [v3][PATCH] drm/i915/display: Drop redundant debug print Swati Sharma
2021-08-12 16:01 ` Imre Deak
2021-08-12 18:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Drop redundant debug print (rev3) Patchwork
@ 2021-08-12 23:12 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-08-12 23:12 UTC (permalink / raw)
To: Swati Sharma; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30274 bytes --]
== Series Details ==
Series: drm/i915/display: Drop redundant debug print (rev3)
URL : https://patchwork.freedesktop.org/series/93025/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10478_full -> Patchwork_20805_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_20805_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_20805_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20805_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_frontbuffer_tracking@psr-slowdraw:
- shard-skl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-skl9/igt@kms_frontbuffer_tracking@psr-slowdraw.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-skl3/igt@kms_frontbuffer_tracking@psr-slowdraw.html
### Piglit changes ###
#### Possible regressions ####
* spec@glsl-1.50@execution@texturesize@gs-texturesize-usamplercube (NEW):
- pig-glk-j5005: NOTRUN -> [INCOMPLETE][3] +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/pig-glk-j5005/spec@glsl-1.50@execution@texturesize@gs-texturesize-usamplercube.html
New tests
---------
New tests have been introduced between CI_DRM_10478_full and Patchwork_20805_full:
### New Piglit tests (5) ###
* spec@ext_packed_depth_stencil@depthstencil-render-miplevels 1024 d=s=z24_s8:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@glsl-1.50@execution@texturesize@gs-texturesize-usampler1d:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@glsl-1.50@execution@texturesize@gs-texturesize-usampler1darray:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@glsl-1.50@execution@texturesize@gs-texturesize-usampler3d:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@glsl-1.50@execution@texturesize@gs-texturesize-usamplercube:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_20805_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +5 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-snb6/igt@gem_ctx_persistence@legacy-engines-mixed.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][5] -> [TIMEOUT][6] ([i915#2369] / [i915#3063] / [i915#3648])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-tglb7/igt@gem_eio@unwedge-stress.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-tglb3/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: [PASS][7] -> [FAIL][8] ([i915#2842]) +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-kbl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-kbl4/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][9] -> [SKIP][10] ([i915#2190])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-tglb5/igt@gem_huc_copy@huc-copy.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-tglb6/igt@gem_huc_copy@huc-copy.html
- shard-kbl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#2190])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-kbl1/igt@gem_huc_copy@huc-copy.html
* igt@gem_mmap_gtt@cpuset-big-copy-xy:
- shard-glk: [PASS][12] -> [FAIL][13] ([i915#1888] / [i915#307])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-glk1/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-glk6/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
* igt@gem_pwrite@basic-exhaustion:
- shard-skl: NOTRUN -> [WARN][14] ([i915#2658])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-skl7/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][15] ([i915#3002])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl2/igt@gem_userptr_blits@input-checking.html
- shard-snb: NOTRUN -> [DMESG-WARN][16] ([i915#3002])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-snb6/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][17] ([i915#2724])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-snb6/igt@gem_userptr_blits@vma-merge.html
- shard-apl: NOTRUN -> [FAIL][18] ([i915#3318])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl2/igt@gem_userptr_blits@vma-merge.html
* igt@gen7_exec_parse@basic-offset:
- shard-apl: NOTRUN -> [SKIP][19] ([fdo#109271]) +329 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl6/igt@gen7_exec_parse@basic-offset.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-skl: [PASS][20] -> [INCOMPLETE][21] ([i915#198])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-skl8/igt@i915_suspend@fence-restore-tiled2untiled.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-skl5/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@i915_suspend@forcewake:
- shard-apl: NOTRUN -> [DMESG-WARN][22] ([i915#180])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl2/igt@i915_suspend@forcewake.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-skl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#3777])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-skl7/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#3777]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl1/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3886]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-glk9/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3886]) +3 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-kbl1/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3886]) +17 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl2/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3886]) +5 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-skl2/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@dp-hpd-with-enabled-mode:
- shard-glk: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +7 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-glk7/igt@kms_chamelium@dp-hpd-with-enabled-mode.html
* igt@kms_chamelium@dp-mode-timings:
- shard-apl: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) +26 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl6/igt@kms_chamelium@dp-mode-timings.html
* igt@kms_chamelium@hdmi-mode-timings:
- shard-snb: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +25 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-snb2/igt@kms_chamelium@hdmi-mode-timings.html
* igt@kms_color@pipe-a-ctm-red-to-blue:
- shard-skl: [PASS][32] -> [DMESG-WARN][33] ([i915#1982])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-skl9/igt@kms_color@pipe-a-ctm-red-to-blue.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-skl1/igt@kms_color@pipe-a-ctm-red-to-blue.html
* igt@kms_color_chamelium@pipe-c-ctm-limited-range:
- shard-kbl: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +4 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-kbl1/igt@kms_color_chamelium@pipe-c-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-c-ctm-negative:
- shard-skl: NOTRUN -> [SKIP][35] ([fdo#109271] / [fdo#111827]) +6 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-skl2/igt@kms_color_chamelium@pipe-c-ctm-negative.html
* igt@kms_content_protection@atomic-dpms:
- shard-kbl: NOTRUN -> [TIMEOUT][36] ([i915#1319])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-kbl1/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][37] ([i915#1319]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl3/igt@kms_content_protection@lic.html
* igt@kms_content_protection@srm:
- shard-glk: NOTRUN -> [SKIP][38] ([fdo#109271]) +56 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-glk7/igt@kms_content_protection@srm.html
* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][39] ([i915#2105])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl1/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][40] ([i915#180])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-32x10-random:
- shard-kbl: NOTRUN -> [SKIP][41] ([fdo#109271]) +52 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-kbl7/igt@kms_cursor_crc@pipe-b-cursor-32x10-random.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-legacy:
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#111825])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-tglb7/igt@kms_cursor_legacy@cursorb-vs-flipb-legacy.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#2672]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite:
- shard-skl: NOTRUN -> [SKIP][44] ([fdo#109271]) +69 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-skl2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff:
- shard-snb: NOTRUN -> [SKIP][45] ([fdo#109271]) +423 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-snb6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [PASS][46] -> [DMESG-WARN][47] ([i915#180]) +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-kbl7/igt@kms_hdr@bpc-switch-suspend.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-kbl3/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-glk: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#533])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-glk7/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#533])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-skl7/igt@kms_pipe_crc_basic@read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][50] ([fdo#108145] / [i915#265]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl2/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: NOTRUN -> [FAIL][51] ([fdo#108145] / [i915#265])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][52] ([i915#265]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl6/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][53] ([fdo#108145] / [i915#265])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-kbl1/igt@kms_plane_alpha_blend@pipe-c-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: NOTRUN -> [FAIL][54] ([fdo#108145] / [i915#265])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-glk7/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][55] -> [FAIL][56] ([fdo#108145] / [i915#265])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-glk: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#2733])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-glk7/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#658]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-kbl7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#658]) +5 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
- shard-glk: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#658]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-glk9/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-skl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#658]) +3 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-skl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][62] -> [SKIP][63] ([fdo#109441]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_vblank@pipe-a-accuracy-idle:
- shard-glk: [PASS][64] -> [FAIL][65] ([i915#43])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-glk3/igt@kms_vblank@pipe-a-accuracy-idle.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-glk3/igt@kms_vblank@pipe-a-accuracy-idle.html
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-kbl: [PASS][66] -> [INCOMPLETE][67] ([i915#155] / [i915#2828])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-kbl7/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-kbl3/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-kbl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#2437])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-kbl1/igt@kms_writeback@writeback-invalid-parameters.html
* igt@sysfs_clients@create:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#2994]) +4 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl6/igt@sysfs_clients@create.html
* igt@sysfs_clients@fair-3:
- shard-glk: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#2994])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-glk7/igt@sysfs_clients@fair-3.html
* igt@sysfs_clients@fair-7:
- shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#2994]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-skl7/igt@sysfs_clients@fair-7.html
#### Possible fixes ####
* igt@gem_eio@in-flight-contexts-immediate:
- shard-tglb: [TIMEOUT][72] ([i915#3063]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-tglb5/igt@gem_eio@in-flight-contexts-immediate.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-tglb8/igt@gem_eio@in-flight-contexts-immediate.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][74] ([i915#2846]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-glk3/igt@gem_exec_fair@basic-deadline.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-glk4/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][76] ([i915#2842]) -> [PASS][77] +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-iclb: [FAIL][78] ([i915#2842]) -> [PASS][79] +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-iclb8/igt@gem_exec_fair@basic-pace@vcs0.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-iclb3/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [FAIL][80] ([i915#2842]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs1.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_flush@basic-wb-ro-default:
- shard-glk: [INCOMPLETE][82] -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-glk5/igt@gem_exec_flush@basic-wb-ro-default.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-glk9/igt@gem_exec_flush@basic-wb-ro-default.html
* igt@gem_exec_schedule@u-independent@vecs0:
- shard-iclb: [FAIL][84] ([i915#3795]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-iclb8/igt@gem_exec_schedule@u-independent@vecs0.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-iclb8/igt@gem_exec_schedule@u-independent@vecs0.html
* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-iclb: [FAIL][86] ([i915#2428]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-iclb5/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-iclb2/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
* igt@gem_mmap_gtt@cpuset-big-copy-xy:
- shard-iclb: [FAIL][88] ([i915#307]) -> [PASS][89] +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-iclb8/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-iclb8/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-apl: [DMESG-WARN][90] ([i915#180]) -> [PASS][91] +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-apl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [FAIL][92] ([i915#2122]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-skl1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-skl10/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [DMESG-WARN][94] ([i915#180]) -> [PASS][95] +3 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-kbl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-kbl1/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][96] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-iclb6/igt@kms_psr2_su@page_flip.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][98] ([fdo#109441]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-iclb3/igt@kms_psr@psr2_sprite_blt.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-skl: [INCOMPLETE][100] ([i915#198] / [i915#2828]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-skl1/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-skl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [FAIL][102] ([i915#2680]) -> [WARN][103] ([i915#2684])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-iclb4/igt@i915_pm_rc6_residency@rc6-idle.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-iclb8/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-0:
- shard-iclb: [SKIP][104] ([i915#658]) -> [SKIP][105] ([i915#2920]) +2 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-iclb6/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
- shard-iclb: [SKIP][106] ([i915#2920]) -> [SKIP][107] ([i915#658]) +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-iclb4/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html
* igt@runner@aborted:
- shard-apl: ([FAIL][108], [FAIL][109], [FAIL][110]) ([fdo#109271] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][111], [FAIL][112], [FAIL][113]) ([i915#180] / [i915#3002] / [i915#3363])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-apl3/igt@runner@aborted.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-apl1/igt@runner@aborted.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-apl1/igt@runner@aborted.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl2/igt@runner@aborted.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl6/igt@runner@aborted.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-apl2/igt@runner@aborted.html
- shard-glk: ([FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118]) ([i915#1814] / [i915#2426] / [i915#2722] / [i915#3002] / [i915#3363] / [k.org#202321]) -> ([FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122]) ([i915#1814] / [i915#2426] / [i915#3002] / [i915#3363] / [k.org#202321])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-glk7/igt@runner@aborted.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-glk7/igt@runner@aborted.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-glk5/igt@runner@aborted.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-glk1/igt@runner@aborted.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-glk6/igt@runner@aborted.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-glk6/igt@runner@aborted.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-glk9/igt@runner@aborted.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-glk7/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-glk8/igt@runner@aborted.html
- shard-skl: ([FAIL][123], [FAIL][124], [FAIL][125]) ([i915#1814] / [i915#2029] / [i915#3002] / [i915#3363]) -> [FAIL][126] ([i915#3002] / [i915#3363])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-skl8/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-skl2/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10478/shard-skl6/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/shard-skl9/igt@runner@aborted.html
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2428]: https://gitlab.freedesktop.org/drm/intel/issues/2428
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2680]: https://gitlab.freedesktop.org/drm/intel/issues/2680
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724
[i915#2733]: https://gitlab.freedesktop.org/drm/intel/issues/2733
[i915#2828]: https://gitlab.freedesktop.org/drm/intel/issues/2828
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#307]: https://gitlab.freedesktop.org/drm/intel/issues/307
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3648]: https://gitlab.freedesktop.org/drm/intel/issues/3648
[i915#3777]
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20805/index.html
[-- Attachment #2: Type: text/html, Size: 38577 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [v3][PATCH] drm/i915/display: Drop redundant debug print
2021-08-12 16:01 ` Imre Deak
@ 2021-08-16 11:53 ` Sharma, Swati2
2021-08-16 12:01 ` Imre Deak
0 siblings, 1 reply; 6+ messages in thread
From: Sharma, Swati2 @ 2021-08-16 11:53 UTC (permalink / raw)
To: Imre Deak
Cc: intel-gfx, Ankit Nautiyal, Uma Shankar, Jani Nikula,
Ville Syrj_l_, Manasi Navare, Jos_ Roberto de Souza, Sean Paul,
stable
On 12-Aug-21 9:31 PM, Imre Deak wrote:
> On Thu, Aug 12, 2021 at 06:41:07PM +0530, Swati Sharma wrote:
>> drm_dp_dpcd_read/write already has debug error message.
>> Drop redundant error messages which gives false
>> status even if correct value is read in drm_dp_dpcd_read().
>>
>> v2: -Added fixes tag (Ankit)
>> v3: -Fixed build error (CI)
>>
>> Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery")
>> Cc: Swati Sharma <swati2.sharma@intel.com>
>> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>> Cc: Uma Shankar <uma.shankar@intel.com> (v2)
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: "Ville Syrj_l_" <ville.syrjala@linux.intel.com>
>> Cc: Imre Deak <imre.deak@intel.com>
>> Cc: Manasi Navare <manasi.d.navare@intel.com>
>> Cc: Uma Shankar <uma.shankar@intel.com>
>> Cc: "Jos_ Roberto de Souza" <jose.souza@intel.com>
>> Cc: Sean Paul <seanpaul@chromium.org>
>> Cc: <stable@vger.kernel.org> # v5.12+
>>
>> Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@intel.com
>>
>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_dp.c | 9 ++-------
>> 1 file changed, 2 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>> index c386ef8eb200..2526c9c8c690 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> @@ -3864,23 +3864,18 @@ static void intel_dp_check_device_service_irq(struct intel_dp *intel_dp)
>>
>> static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
>> {
>> - struct drm_i915_private *i915 = dp_to_i915(intel_dp);
>> u8 val;
>>
>> if (intel_dp->dpcd[DP_DPCD_REV] < 0x11)
>> return;
>>
>> if (drm_dp_dpcd_readb(&intel_dp->aux,
>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) {
>> - drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n");
>
> The only problem seems to be that for !val the debug print is incorrect,
> so maybe just have a separate check for that after this one for the read()
> and return w/o the debug message?
>
> Is it really a stable material, since the change wouldn't have any
> effect for regular users?
>
W/o this change in case of valid short pulse this error message will
come even if
it doesn't have anything to do with link service irq. For ex: in case of
hdcp we keep getting unnecessary error message because the value read is
0 which will always be the case unless its really a link failure between
PCON and HDMI2.1 sink.
Also, code is written in accordance with other IRQ func() above like
intel_dp_check_device_service_irq().
>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val)
>> return;
>> - }
>>
>> if (drm_dp_dpcd_writeb(&intel_dp->aux,
>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) {
>> - drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n");
>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
>> return;
>> - }
>>
>> if (val & HDMI_LINK_STATUS_CHANGED)
>> intel_dp_handle_hdmi_link_status_change(intel_dp);
>> --
>> 2.25.1
>>
--
~Swati Sharma
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [v3][PATCH] drm/i915/display: Drop redundant debug print
2021-08-16 11:53 ` Sharma, Swati2
@ 2021-08-16 12:01 ` Imre Deak
0 siblings, 0 replies; 6+ messages in thread
From: Imre Deak @ 2021-08-16 12:01 UTC (permalink / raw)
To: Sharma, Swati2
Cc: intel-gfx, Ankit Nautiyal, Uma Shankar, Jani Nikula,
Ville Syrj_l_, Manasi Navare, Jos_ Roberto de Souza, Sean Paul,
stable
On Mon, Aug 16, 2021 at 05:23:00PM +0530, Sharma, Swati2 wrote:
> On 12-Aug-21 9:31 PM, Imre Deak wrote:
> > On Thu, Aug 12, 2021 at 06:41:07PM +0530, Swati Sharma wrote:
> > > drm_dp_dpcd_read/write already has debug error message.
> > > Drop redundant error messages which gives false
> > > status even if correct value is read in drm_dp_dpcd_read().
> > >
> > > v2: -Added fixes tag (Ankit)
> > > v3: -Fixed build error (CI)
> > >
> > > Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery")
> > > Cc: Swati Sharma <swati2.sharma@intel.com>
> > > Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> > > Cc: Uma Shankar <uma.shankar@intel.com> (v2)
> > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > Cc: "Ville Syrj_l_" <ville.syrjala@linux.intel.com>
> > > Cc: Imre Deak <imre.deak@intel.com>
> > > Cc: Manasi Navare <manasi.d.navare@intel.com>
> > > Cc: Uma Shankar <uma.shankar@intel.com>
> > > Cc: "Jos_ Roberto de Souza" <jose.souza@intel.com>
> > > Cc: Sean Paul <seanpaul@chromium.org>
> > > Cc: <stable@vger.kernel.org> # v5.12+
> > >
> > > Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@intel.com
> > >
> > > Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_dp.c | 9 ++-------
> > > 1 file changed, 2 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > > index c386ef8eb200..2526c9c8c690 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > > @@ -3864,23 +3864,18 @@ static void intel_dp_check_device_service_irq(struct intel_dp *intel_dp)
> > > static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
> > > {
> > > - struct drm_i915_private *i915 = dp_to_i915(intel_dp);
> > > u8 val;
> > > if (intel_dp->dpcd[DP_DPCD_REV] < 0x11)
> > > return;
> > > if (drm_dp_dpcd_readb(&intel_dp->aux,
> > > - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) {
> > > - drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n");
> >
> > The only problem seems to be that for !val the debug print is incorrect,
> > so maybe just have a separate check for that after this one for the read()
> > and return w/o the debug message?
> >
> > Is it really a stable material, since the change wouldn't have any
> > effect for regular users?
>
> W/o this change in case of valid short pulse this error message will
> come even if it doesn't have anything to do with link service irq. For
> ex: in case of hdcp we keep getting unnecessary error message because
> the value read is 0 which will always be the case unless its really a
> link failure between PCON and HDMI2.1 sink.
Yes, that's why I suggested to return for the '0 value read' case
without any message printed, but still keep the message for the case
when the drm_dp_dpcd_readb() fails.
Note that it's not an error message but a debug message.
> Also, code is written in accordance with other IRQ func() above like
> intel_dp_check_device_service_irq().
Ok, it's good to keep them in sync at least, so I'm ok with removing the
debug messages from here too.
> > > + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val)
> > > return;
> > > - }
> > > if (drm_dp_dpcd_writeb(&intel_dp->aux,
> > > - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) {
> > > - drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n");
> > > + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
> > > return;
> > > - }
> > > if (val & HDMI_LINK_STATUS_CHANGED)
> > > intel_dp_handle_hdmi_link_status_change(intel_dp);
> > > --
> > > 2.25.1
> > >
>
> --
> ~Swati Sharma
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-08-16 12:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-12 13:11 [Intel-gfx] [v3][PATCH] drm/i915/display: Drop redundant debug print Swati Sharma
2021-08-12 16:01 ` Imre Deak
2021-08-16 11:53 ` Sharma, Swati2
2021-08-16 12:01 ` Imre Deak
2021-08-12 18:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Drop redundant debug print (rev3) Patchwork
2021-08-12 23:12 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).