intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: intel-gfx <intel-gfx@lists.freedesktop.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Sam Ravnborg <sam@ravnborg.org>,
	Maxime Ripard <mripard@kernel.org>,
	Matthew Auld <matthew.auld@intel.com>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
	Nirmoy Das <nirmoy.das@intel.com>
Subject: [Intel-gfx] [PATCH RESEND AGAIN v2 2/2] drm/i915: Ratelimit debug log in vm_fault_ttm
Date: Wed,  6 Dec 2023 22:09:48 +0100	[thread overview]
Message-ID: <20231206210948.106238-3-andi.shyti@linux.intel.com> (raw)
In-Reply-To: <20231206210948.106238-1-andi.shyti@linux.intel.com>

From: Nirmoy Das <nirmoy.das@intel.com>

Test like i915_gem_mman_live_selftests/igt_mmap_migrate can cause
dmesg spamming. Use ratelimit api to reduce log rate.

References: https://gitlab.freedesktop.org/drm/intel/-/issues/7038
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
index 9227f8146a58..6b69ef0cdbb4 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
@@ -1101,8 +1101,9 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf)
 		}
 
 		if (err) {
-			drm_dbg(dev, "Unable to make resource CPU accessible(err = %pe)\n",
-				ERR_PTR(err));
+			drm_dbg_ratelimited(dev,
+					    "Unable to make resource CPU accessible(err = %pe)\n",
+					    ERR_PTR(err));
 			dma_resv_unlock(bo->base.resv);
 			ret = VM_FAULT_SIGBUS;
 			goto out_rpm;
-- 
2.43.0


  parent reply	other threads:[~2023-12-06 21:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-06 21:09 [Intel-gfx] [PATCH RESEND AGAIN v2 0/2] Add drm_dbg_ratelimited() Andi Shyti
2023-12-06 21:09 ` [Intel-gfx] [PATCH RESEND AGAIN v2 1/2] drm/print: Add drm_dbg_ratelimited Andi Shyti
2023-12-06 21:09 ` Andi Shyti [this message]
2023-12-07  1:44 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add drm_dbg_ratelimited() (rev2) Patchwork
2023-12-07  1:44 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-12-07  1:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-12-07  3:19 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-12-07  9:00 ` [Intel-gfx] [PATCH RESEND AGAIN v2 0/2] Add drm_dbg_ratelimited() Thomas Zimmermann
2023-12-07  9:10 ` Maxime Ripard
2023-12-07  9:23   ` Andi Shyti
2023-12-07 13:06     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231206210948.106238-3-andi.shyti@linux.intel.com \
    --to=andi.shyti@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    --cc=mripard@kernel.org \
    --cc=nirmoy.das@intel.com \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).