From: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Check for a change in fb size, and reconfigure the pipe
Date: Tue, 13 Nov 2012 13:33:37 +0000 [thread overview]
Message-ID: <275ffc$7crnav@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <20121113131555.GI3791@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1569 bytes --]
On Tue, 13 Nov 2012 15:15:55 +0200, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Nov 13, 2012 at 12:48:11PM +0000, Chris Wilson wrote:
> > On Tue, 13 Nov 2012 14:42:36 +0200, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > > On Tue, Nov 13, 2012 at 12:15:10PM +0000, Chris Wilson wrote:
> > > > In the slightly unusual case where the pipe is programmed to the same
> > > > modeline, but the framebuffer is a new size, we need to resetup the
> > > > panel fitter as appropriate and this requires a full modeset. This can
> > > > only occur currently as part of the BIOS takeover where there are
> > > > slightly different semantics governing how the panel fitter and
> > > > framebuffer is programmed relative to the modeline.
> > >
> > > Hmm. I don't get it. Why would the framebuffer size affect the panel
> > > fitter configuration?
> >
> > The BIOS uses fb->(width,height) to program PIPESRC, we use
> > mode->[hv]display. The BIOS's semantics makes more sense
>
> I don't think so. That would make panning impossible.
True. The issue really appears that we recreate the mode using the crtc
values and assume that the reverse mapping works. Further issues arise
if we want to recover any offsets in a multiple output configuration. I
will just have to double-check that the BIOS configuration matches our
usage.
And I whole-heartedly agree with separating the display mode from the
plane configuration, I guess you have something planned along those
lines already ;-)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2012-11-13 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 12:15 [PATCH] drm/i915: Check for a change in fb size, and reconfigure the pipe Chris Wilson
2012-11-13 12:42 ` Ville Syrjälä
2012-11-13 12:48 ` Chris Wilson
2012-11-13 13:15 ` Ville Syrjälä
2012-11-13 13:33 ` Chris Wilson [this message]
2012-11-13 13:59 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='275ffc$7crnav@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).