From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4002CC4338F for ; Wed, 28 Jul 2021 12:22:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E54F060C3E for ; Wed, 28 Jul 2021 12:22:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E54F060C3E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7575B6E43B; Wed, 28 Jul 2021 12:22:57 +0000 (UTC) Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7593A6E98F; Wed, 28 Jul 2021 11:29:03 +0000 (UTC) Received: by mail-wr1-x434.google.com with SMTP id c16so2047217wrp.13; Wed, 28 Jul 2021 04:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=VI1b/7Zio0QbTHVDmC7OIx9Iv7sUZ3kXOO83Nnb1/lI=; b=MOA/VOEXpidjw9AYaF3IXPbM6aik0n/2pDu3qGV734GI/MKZej41DpACQshSitpBHp LQ3YHoaO3xcBZzpcsNjShILGXUpmKS5ZgVAmgwqvbopYjCV6Oe7kqDCKvQGMz1GhH8FV iSxZcRNrR7p1TZ5rVO3i3rez8Tf1bgPKxGIL7d8oWchGGL320KpKfOsAda6x+TjTz5O4 4bCPnPYjchzaaC50jNDk1qaP8p8alaDlxruTYCJqyH5+MzTNO6GiD6mTiiIIejBu2nm4 +Vr4pubkhVWp5DZvj/DSgx8P3RUgT6oeNuzxq4zWxIwzW6zjdND1aBxfxo7GqdOlIOLr 7nyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=VI1b/7Zio0QbTHVDmC7OIx9Iv7sUZ3kXOO83Nnb1/lI=; b=WsTRh+zsSrWEaye7sRJ8ij4HB83bEzmA0n/+t1R5mg5m6An4hIWlrizzgd2XBgcimp 6A6GHErQVzDAgD9xpdCdjlX0K4a7gwqpD1lyBo+uLTYnclcjFMnSyRgl+HzqWZ/UosYu SgqoEacQAFFI6fKeWcGnznR6pH+MIp0W6Lltlk7Cgd4n0MnMTuILECG0Y/wi/uKl6QeF q0EPTNDAntU6rjAqVqKkcoHZ615u6AYoGJ5C9XQu7NZm9FgWU/Tyzs2UYl81DUnPm30D +pYsVzjKMQqRbY7cleq/rtuVQzToU14avK8MKZEnozfPcn+aZWx32GONTBvVK6Ma51rk ZGgg== X-Gm-Message-State: AOAM530oOqpYwWCc8FpL1ShyMAH5NWAfH5Lz9ygAtiPWkK9CpBUIf6v/ bEFovncUGutYs/roqAqk1C8= X-Google-Smtp-Source: ABdhPJwO3jBbz+R3AJiHF0WQfeY+oF3uwMVgNB4ghF4GPoF75Jaw2yWir3ze6NE+b9AvVpMjJ+cXcg== X-Received: by 2002:a5d:61c8:: with SMTP id q8mr18198915wrv.151.1627471741909; Wed, 28 Jul 2021 04:29:01 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:6a5d:b580:2891:cbac? ([2a02:908:1252:fb60:6a5d:b580:2891:cbac]) by smtp.gmail.com with ESMTPSA id l2sm4888332wru.67.2021.07.28.04.29.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jul 2021 04:29:01 -0700 (PDT) To: Daniel Vetter , DRI Development , Melissa Wen , Boris Brezillon , Lucas Stach References: <20210712175352.802687-1-daniel.vetter@ffwll.ch> <20210712175352.802687-4-daniel.vetter@ffwll.ch> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <2bcfba05-b7d5-1bd9-d74a-b9aac1147e20@gmail.com> Date: Wed, 28 Jul 2021 13:28:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mailman-Approved-At: Wed, 28 Jul 2021 12:22:55 +0000 Subject: Re: [Intel-gfx] [Linaro-mm-sig] [PATCH v4 03/18] drm/sched: Add dependency tracking X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Grodzovsky , Jack Zhang , David Airlie , Intel Graphics Development , Steven Price , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Luben Tuikov , Alex Deucher , Daniel Vetter , Nirmoy Das , Lee Jones , =?UTF-8?Q?Christian_K=c3=b6nig?= , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Am 27.07.21 um 13:09 schrieb Daniel Vetter: > Adding a few more people to this bikeshed. > > On Mon, Jul 12, 2021 at 10:02 PM Daniel Vetter wrote: > >> @@ -349,6 +367,13 @@ int drm_sched_job_init(struct drm_sched_job *job, >> struct drm_sched_entity *entity, >> void *owner); >> void drm_sched_job_arm(struct drm_sched_job *job); >> +int drm_sched_job_await_fence(struct drm_sched_job *job, >> + struct dma_fence *fence); >> +int drm_sched_job_await_implicit(struct drm_sched_job *job, >> + struct drm_gem_object *obj, >> + bool write); >> + >> + > I'm still waiting on the paint delivery for these two functions so I > can finish this shed. Well I wouldn't call that bike shedding, good names are important. Just imaging we would have called the exclusive-fence write-fence instead. What speaks against calling them add_dependency() and _add_implicit_depencencies() ? Regards, Christian. > > Thanks, Daniel > >> void drm_sched_entity_modify_sched(struct drm_sched_entity *entity, >> struct drm_gpu_scheduler **sched_list, >> unsigned int num_sched_list); >> -- >> 2.32.0 >> > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx