From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Flush the submission, not cancel it!
Date: Thu, 21 May 2020 14:54:48 +0100 [thread overview]
Message-ID: <2fb55543-c9fe-2b90-386e-4f98367f60aa@linux.intel.com> (raw)
In-Reply-To: <20200521124304.3157692-1-chris@chris-wilson.co.uk>
On 21/05/2020 13:43, Chris Wilson wrote:
> Use intel_engine_flush_submission() when we want to ensure that the
> tasklet is run. tasklet_kill(), while it may ensure that an ongoing
> tasklet is completed, also prevents the tasklet from running if it's
> already scheduled and hasn't yet been run.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1874
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> index ef38dd52945c..66f710b1b61e 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> @@ -332,7 +332,7 @@ static int live_unlite_restore(struct intel_gt *gt, int prio)
> i915_request_put(rq[0]);
>
> err_ce:
> - tasklet_kill(&engine->execlists.tasklet); /* flush submission */
> + intel_engine_flush_submission(engine);
> igt_spinner_end(&spin);
> for (n = 0; n < ARRAY_SIZE(ce); n++) {
> if (IS_ERR_OR_NULL(ce[n]))
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-05-21 13:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 12:43 [Intel-gfx] [PATCH] drm/i915/selftests: Flush the submission, not cancel it! Chris Wilson
2020-05-21 13:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-05-21 13:54 ` Tvrtko Ursulin [this message]
2020-05-22 7:08 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fb55543-c9fe-2b90-386e-4f98367f60aa@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).