From: "Iddamsetty, Aravind" <aravind.iddamsetty@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org, matthew.auld@intel.com, daniel@ffwll.ch
Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915/mtl/UAPI: Disable SET_CACHING IOCTL for MTL+
Date: Tue, 29 Nov 2022 16:46:31 +0530 [thread overview]
Message-ID: <31004d50-1504-cd75-a15c-b2f2c61f0bd1@intel.com> (raw)
In-Reply-To: <20221128201933.5aifg3cyrkda3l4m@ldmartin-desk2.lan>
On 29-11-2022 01:49, Lucas De Marchi wrote:
> On Mon, Nov 28, 2022 at 03:43:52PM +0530, Aravind Iddamsetty wrote:
>> From: Pallavi Mishra <pallavi.mishra@intel.com>
>>
>> Caching mode for an object shall be selected via upcoming VM_BIND
>> interface.
>
> last I've heard there was no plan to support this through VM_BIND. Did
> anything change? Otherwise this needs a better explanation recorded in
> the cover letter.
sorry it was a confusion on my part, after discussing with Joonas i
understood we want to drop support for get/set caching ioctls on all
future platforms on the similar lines of the below commit.
Thanks,
Aravind.
>
> According to e7737b67ab46 ("drm/i915/uapi: reject caching ioctls for
> discrete")
> it seems it was already planned to extend this to all platforms.
>
> +Daniel, +Matt Auld
>
>>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Cc: Matt Roper <matthew.d.roper@intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>
>> Signed-off-by: Pallavi Mishra <pallavi.mishra@intel.com>
>> Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty@intel.com>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_domain.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_domain.c
>> b/drivers/gpu/drm/i915/gem/i915_gem_domain.c
>> index d44a152ce680..aebbfe186143 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_domain.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_domain.c
>> @@ -332,6 +332,9 @@ int i915_gem_set_caching_ioctl(struct drm_device
>> *dev, void *data,
>> if (IS_DGFX(i915))
>> return -ENODEV;
>>
>> + if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 70))
>> + return -EOPNOTSUPP;
>
> Why a different return? Should this be treated similar to the IS_DGFX()
> case above? It seems we are also missing an equivalent change in
> i915_gem_get_caching_ioctl().
>
> include/uapi/drm/i915_drm.h also needs to be updated with documentation
> about this behavior. See the commit mentioned above.
>
> Lucas De Marchi
>
>
>
>> +
>> switch (args->caching) {
>> case I915_CACHING_NONE:
>> level = I915_CACHE_NONE;
>> --
>> 2.25.1
>>
next prev parent reply other threads:[~2022-11-29 11:16 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 10:13 [Intel-gfx] [PATCH 1/3] drm/i915/mtl: Define MOCS and PAT tables for MTL Aravind Iddamsetty
2022-11-28 10:13 ` [Intel-gfx] [PATCH 2/3] drm/i915/mtl: Define new PTE encode " Aravind Iddamsetty
2022-11-28 19:52 ` Yang, Fei
2022-11-28 23:58 ` Iddamsetty, Aravind
2022-11-28 20:27 ` Lucas De Marchi
2022-11-29 4:28 ` Iddamsetty, Aravind
2022-11-29 6:51 ` Lucas De Marchi
2022-11-28 10:13 ` [Intel-gfx] [PATCH 3/3] drm/i915/mtl/UAPI: Disable SET_CACHING IOCTL for MTL+ Aravind Iddamsetty
2022-11-28 20:19 ` Lucas De Marchi
2022-11-29 5:07 ` Iddamsetty, Aravind
2022-11-29 11:16 ` Iddamsetty, Aravind [this message]
2022-11-28 12:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/mtl: Define MOCS and PAT tables for MTL Patchwork
2022-11-28 12:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-11-28 15:44 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-12-06 7:37 ` [Intel-gfx] [PATCH 1/4] " Aravind Iddamsetty
2022-12-06 7:37 ` [Intel-gfx] [PATCH 2/4] drm/i915: Reference pte_encode through vm pointer Aravind Iddamsetty
2022-12-06 8:27 ` Aravind Iddamsetty
2022-12-06 22:51 ` Matt Roper
2022-12-07 6:28 ` Iddamsetty, Aravind
2022-12-06 7:37 ` [Intel-gfx] [PATCH 3/4] drm/i915/mtl: Define new PTE encode for MTL Aravind Iddamsetty
2022-12-06 8:27 ` Aravind Iddamsetty
2022-12-06 23:39 ` Matt Roper
2022-12-07 7:26 ` Iddamsetty, Aravind
2022-12-07 18:11 ` Matt Roper
2022-12-14 12:07 ` Iddamsetty, Aravind
2022-12-15 13:02 ` Das, Nirmoy
2022-12-06 7:37 ` [Intel-gfx] [PATCH 4/4] drm/i915/mtl/UAPI: Disable GET/SET_CACHING IOCTL for MTL+ Aravind Iddamsetty
2022-12-06 8:27 ` [Intel-gfx] [PATCH v2 " Aravind Iddamsetty
2022-12-06 16:58 ` Matthew Auld
2022-12-06 23:49 ` Matt Roper
2022-12-06 23:51 ` Matt Roper
2022-12-15 8:16 ` Iddamsetty, Aravind
2022-12-06 8:08 ` [Intel-gfx] [PATCH 1/4] drm/i915/mtl: Define MOCS and PAT tables for MTL Iddamsetty, Aravind
2022-12-06 18:39 ` Lucas De Marchi
2022-12-07 6:20 ` Iddamsetty, Aravind
2022-12-06 8:27 ` Aravind Iddamsetty
2022-12-06 22:37 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31004d50-1504-cd75-a15c-b2f2c61f0bd1@intel.com \
--to=aravind.iddamsetty@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).