intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Zou, Nanhai" <nanhai.zou@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
	"Anholt, Eric" <eric.anholt@intel.com>
Subject: Re: [PATCH 0/3] implement multiple ring buffer V1
Date: Thu, 20 May 2010 15:38:13 +0800	[thread overview]
Message-ID: <41EFD7A46E18724CAB128DAD0073348006B2046B6E@shsmsx502.ccr.corp.intel.com> (raw)
In-Reply-To: <20100519172600.GC3537@viiv.ffwll.ch>


>>-----Original Message-----
>>From: Daniel Vetter [mailto:daniel@ffwll.ch]
>>Sent: 2010年5月20日 1:26
>>To: Zou, Nanhai
>>Cc: intel-gfx; Anholt, Eric; Xiang, Haihao
>>Subject: Re: [Intel-gfx] [PATCH 0/3] implement multiple ring buffer V1
>>
>>On Wed, May 19, 2010 at 05:33:28PM +0800, Zou Nan hai wrote:
>>>  The patch series try to abstruct ring buffer
>>>  structure, implement BSD (bit stream decoder) ring
>>>  buffer for H.264/VC1 VLD decoding.
>>>
>>>  I mark this as V1 for review.
>>
>>Woot, we're (slowly) getting there. I'll do an in-depth review some when
>>later this week (running short on free time, atm). On a quick look, the
>>series has definitely improved.
>>
>>One nitpick up-front: You haven't sent the individual patches as follow-ups
>>to the introduction email. Just use git format-patch and git send-email,
>>they'll take care of all the boring details for you. Quick primer, if
>>you're totally lazy:
>>
>>$ git format-patch --cover-letter -o output_directory revision_range
>>
>>creates a bunch of .patch files including introduction letter with the
>>commits int the given range. You only have to change the subject & text of
>>the cover letter. Then
>>
>>$ git send-email --to 'bla@bla.com' --cc 'foo@bar.com' *.patch [--dry-run]
>>
>>sends them away. Use --dry-run to check first that git does the right
>>thing with your patches.

Thanks for the hints,
	I was using git format-patch and git-send-email to send out those patches.
However later I found regression on non-ironlake platform with this series of patch. I have fixed that and doing regression and duration tests over the patch. I will sent out V2 tomorrow.

Thanks
Zou Nan hai
>>
>>Yours, Daniel
>>--
>>Daniel Vetter
>>Mail: daniel@ffwll.ch
>>Mobile: +41 (0)79 365 57 48
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2010-05-20  7:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-19  9:33 [PATCH 0/3] implement multiple ring buffer V1 Zou Nan hai
2010-05-19 17:26 ` Daniel Vetter
2010-05-20  7:38   ` Zou, Nanhai [this message]
2010-05-20 15:32     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41EFD7A46E18724CAB128DAD0073348006B2046B6E@shsmsx502.ccr.corp.intel.com \
    --to=nanhai.zou@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=eric.anholt@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).