intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Souza, Jose" <jose.souza@intel.com>
To: "Roper, Matthew D" <matthew.d.roper@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/adl_p: Also disable underrun recovery with MSO
Date: Wed, 18 Aug 2021 21:35:55 +0000	[thread overview]
Message-ID: <44704aac36d264f17d5673bf844310d1154ea49e.camel@intel.com> (raw)
In-Reply-To: <20210816204112.2960624-1-matthew.d.roper@intel.com>

On Mon, 2021-08-16 at 13:41 -0700, Matt Roper wrote:
> One of the cases that the bspec lists for when underrun recovery must be
> disabled is "COG;" that note actually refers to eDP multi-segmented
> operation (MSO).  Let's ensure the this additional restriction is
> honored by the driver.

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> 
> Bspec: 50351
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Fixes: ba3b049f4774 ("drm/i915/adl_p: Allow underrun recovery when possible")
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index a257e5dc381c..134a6acbd8fb 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -2226,6 +2226,9 @@ static bool underrun_recovery_supported(const struct intel_crtc_state *crtc_stat
>  	if (crtc_state->has_psr2)
>  		return false;
>  
> +	if (crtc_state->splitter.enable)
> +		return false;
> +
>  	return true;
>  }
>  


      parent reply	other threads:[~2021-08-18 21:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16 20:41 [Intel-gfx] [PATCH] drm/i915/adl_p: Also disable underrun recovery with MSO Matt Roper
2021-08-17 16:02 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2021-08-17 16:26   ` Matt Roper
2021-08-17 17:17     ` Vudum, Lakshminarayana
2021-08-17 16:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-08-17 18:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-08-18 21:35 ` Souza, Jose [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44704aac36d264f17d5673bf844310d1154ea49e.camel@intel.com \
    --to=jose.souza@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).