From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v4 2/3] drm/i915/perf: remove redundant power configuration register override
Date: Thu, 12 Mar 2020 17:46:57 +0000 [thread overview]
Message-ID: <45535944-c1f0-3967-b2f1-e21ba0545bee@linux.intel.com> (raw)
In-Reply-To: <20200306100557.2077450-2-lionel.g.landwerlin@intel.com>
On 06/03/2020 10:05, Lionel Landwerlin wrote:
> The caller of i915_oa_init_reg_state() already sets this.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
> drivers/gpu/drm/i915/i915_perf.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index 0069f09b988c..86c6abaa3e0e 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -2098,9 +2098,6 @@ gen8_update_reg_state_unlocked(const struct intel_context *ce,
> for (i = 0; i < ARRAY_SIZE(flex_regs); i++)
> reg_state[ctx_flexeu0 + i * 2 + 1] =
> oa_config_flex_reg(stream->oa_config, flex_regs[i]);
> -
> - reg_state[CTX_R_PWR_CLK_STATE] =
> - intel_sseu_make_rpcs(ce->engine->i915, &ce->sseu);
> }
>
> struct flex {
> @@ -2906,10 +2903,6 @@ void i915_oa_init_reg_state(const struct intel_context *ce,
>
> /* perf.exclusive_stream serialised by lrc_configure_all_contexts() */
> stream = READ_ONCE(engine->i915->perf.exclusive_stream);
> - /*
> - * For gen12, only CTX_R_PWR_CLK_STATE needs update, but the caller
> - * is already doing that, so nothing to be done for gen12 here.
> - */
> if (stream && INTEL_GEN(stream->perf->i915) < 12)
> gen8_update_reg_state_unlocked(ce, stream);
> }
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-12 17:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 10:05 [Intel-gfx] [PATCH v4 1/3] drm/i915/perf: remove generated code Lionel Landwerlin
2020-03-06 10:05 ` [Intel-gfx] [PATCH v4 2/3] drm/i915/perf: remove redundant power configuration register override Lionel Landwerlin
2020-03-12 17:46 ` Tvrtko Ursulin [this message]
2020-03-06 10:05 ` [Intel-gfx] [PATCH v4 3/3] drm/i915/perf: introduce global sseu pinning Lionel Landwerlin
2020-03-12 18:19 ` Tvrtko Ursulin
2020-03-12 22:41 ` Tvrtko Ursulin
2020-03-13 13:40 ` Lionel Landwerlin
2020-03-13 13:34 ` Lionel Landwerlin
2020-03-06 16:34 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v4,1/3] drm/i915/perf: remove generated code Patchwork
2020-03-06 16:51 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2020-03-06 17:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-03-12 13:51 ` [Intel-gfx] [PATCH v4 1/3] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45535944-c1f0-3967-b2f1-e21ba0545bee@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lionel.g.landwerlin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).