From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Cc: "Juha-Pekka Heikkilä" <juha-pekka.heikkila@intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/4] drm/i915/params: don't expose inject_probe_failure in debugfs
Date: Thu, 14 May 2020 22:16:09 +0300 [thread overview]
Message-ID: <482c61e3-489f-11d2-7151-1668fe8f02d1@gmail.com> (raw)
In-Reply-To: <20200514154006.4761-1-jani.nikula@intel.com>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 14.5.2020 18.40, Jani Nikula wrote:
> The parameter only makes sense as a module parameter only.
>
> Fixes: c43c5a8818d4 ("drm/i915/params: add i915 parameters to debugfs")
> Cc: Juha-Pekka Heikkilä <juha-pekka.heikkila@intel.com>
> Cc: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_params.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index 45323732f099..4f21bfffbf0e 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -64,7 +64,7 @@ struct drm_printer;
> param(int, mmio_debug, -IS_ENABLED(CONFIG_DRM_I915_DEBUG_MMIO), 0600) \
> param(int, edp_vswing, 0, 0400) \
> param(unsigned int, reset, 3, 0600) \
> - param(unsigned int, inject_probe_failure, 0, 0600) \
> + param(unsigned int, inject_probe_failure, 0, 0) \
> param(int, fastboot, -1, 0600) \
> param(int, enable_dpcd_backlight, -1, 0600) \
> param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE, 0400) \
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-05-14 19:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 15:40 [Intel-gfx] [PATCH 1/4] drm/i915/params: don't expose inject_probe_failure in debugfs Jani Nikula
2020-05-14 15:40 ` [Intel-gfx] [PATCH 2/4] drm/i915/params: fix i915.fake_lmem_start module param sysfs permissions Jani Nikula
2020-05-14 22:42 ` Rodrigo Vivi
2020-05-14 15:40 ` [Intel-gfx] [PATCH 3/4] drm/i915/params: prevent changing module params runtime Jani Nikula
2020-05-14 19:16 ` Juha-Pekka Heikkila
2020-05-14 15:40 ` [Intel-gfx] [PATCH 4/4] drm/i915/params: switch to device specific parameters Jani Nikula
2020-05-14 22:44 ` Rodrigo Vivi
2020-05-14 19:16 ` Juha-Pekka Heikkila [this message]
2020-05-15 14:24 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/params: don't expose inject_probe_failure in debugfs Patchwork
2020-05-15 14:41 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-05-18 14:06 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/params: don't expose inject_probe_failure in debugfs (rev2) Patchwork
2020-05-18 14:24 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482c61e3-489f-11d2-7151-1668fe8f02d1@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=juha-pekka.heikkila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).