Intel-GFX Archive on lore.kernel.org
 help / color / Atom feed
From: Kenneth Graunke <kenneth@whitecape.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915: Fix MI_DISPLAY_FLIP plane select offset on Ivybridge.
Date: Wed, 08 Jun 2011 02:54:36 -0700
Message-ID: <4DEF46DC.9050203@whitecape.org> (raw)
In-Reply-To: <f80fcd$eo6c1@fmsmga001.fm.intel.com>

On 06/08/2011 02:36 AM, Chris Wilson wrote:
> On Tue, 07 Jun 2011 17:55:05 -0700, Kenneth Graunke<kenneth@whitecape.org>  wrote:
>> On 06/07/2011 04:14 PM, Keith Packard wrote:
>>> What's this last DWORD supposed to be for? The IVB spec says length
>>> should be '1' and there should be only 3 DWORDS in this command.
>>
>> Good question.  My reading of the docs say that it should be 3 DWORDs on
>> SNB as well; this code was directly lifted from "case 6" above (save the
>> first line).
>
> In my ancient copy of the specs, MI_DISPLAY_FLIP is 4 dwords, with this
> last dword for programming the panel-fitter and pipesrc. And it also
> says that command is applicable to IVB, but as I said it is an ancient
> copy.
> -Chris

That's correct.  SNB /does/ include a 4th DWord as you describe---newer 
specs got mangled and lost that info, somehow.  Argh.

IVB does only use three DWords, so the last OUT_RING should be nixed. 
Removing that does change the behavior, but doesn't yet make it work.

Thanks!
--Kenneth

  reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-07 22:54 Kenneth Graunke
2011-06-07 22:54 ` [PATCH 2/3] drm/i915: Remove HAS_BLT/HAS_BSD checks from ivybridge_irq_postinstall Kenneth Graunke
2011-06-07 23:16   ` Keith Packard
2011-06-08  9:29   ` Chris Wilson
2011-06-07 22:54 ` [PATCH 3/3] drm/i915: Enable GPU reset on Ivybridge Kenneth Graunke
2011-06-07 23:18   ` Keith Packard
2011-06-07 23:14 ` [PATCH 1/3] drm/i915: Fix MI_DISPLAY_FLIP plane select offset " Keith Packard
2011-06-08  0:55   ` Kenneth Graunke
2011-06-08  1:09     ` Keith Packard
2011-06-08  9:36     ` Chris Wilson
2011-06-08  9:54       ` Kenneth Graunke [this message]
2011-06-08 10:57         ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DEF46DC.9050203@whitecape.org \
    --to=kenneth@whitecape.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Intel-GFX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/intel-gfx/0 intel-gfx/git/0.git
	git clone --mirror https://lore.kernel.org/intel-gfx/1 intel-gfx/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 intel-gfx intel-gfx/ https://lore.kernel.org/intel-gfx \
		intel-gfx@lists.freedesktop.org
	public-inbox-index intel-gfx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.intel-gfx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git