* [Intel-gfx] [PATCH] drm/i915: Always flush the active worker before returning from the wait
@ 2021-01-21 23:28 Chris Wilson
2021-01-22 5:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2021-01-21 23:28 UTC (permalink / raw)
To: intel-gfx; +Cc: Matthew Auld, stable, Chris Wilson
The first thing the active retirement worker does is decrement the
i915_active count.
The first thing we do during i915_active_wait is try to increment the
i915_active count, but only if already active [non-zero].
The wait may see that the retirement is already started and so marked the
i915_active as idle, and skip waiting for the retirement handler.
However, the caller of i915_active_wait may immediately free the
i915_active upon returning (e.g. i915_vma_destroy) so we must not return
before the concurrent access from the worker are completed. We must
always flush the worker.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2473
Fixes: 274cbf20fd10 ("drm/i915: Push the i915_active.retire into a worker")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: <stable@vger.kernel.org> # v5.5+
---
drivers/gpu/drm/i915/i915_active.c | 28 +++++++++++++++-------------
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_active.c b/drivers/gpu/drm/i915/i915_active.c
index ab4382841c6b..3bc616cc1ad2 100644
--- a/drivers/gpu/drm/i915/i915_active.c
+++ b/drivers/gpu/drm/i915/i915_active.c
@@ -628,24 +628,26 @@ static int flush_lazy_signals(struct i915_active *ref)
int __i915_active_wait(struct i915_active *ref, int state)
{
- int err;
-
might_sleep();
- if (!i915_active_acquire_if_busy(ref))
- return 0;
-
/* Any fence added after the wait begins will not be auto-signaled */
- err = flush_lazy_signals(ref);
- i915_active_release(ref);
- if (err)
- return err;
+ if (i915_active_acquire_if_busy(ref)) {
+ int err;
- if (!i915_active_is_idle(ref) &&
- ___wait_var_event(ref, i915_active_is_idle(ref),
- state, 0, 0, schedule()))
- return -EINTR;
+ err = flush_lazy_signals(ref);
+ i915_active_release(ref);
+ if (err)
+ return err;
+ if (___wait_var_event(ref, i915_active_is_idle(ref),
+ state, 0, 0, schedule()))
+ return -EINTR;
+ }
+
+ /*
+ * After the wait is complete, the caller may free the active.
+ * We have to flush any concurrent retirement before returning.
+ */
flush_work(&ref->work);
return 0;
}
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Always flush the active worker before returning from the wait
2021-01-21 23:28 [Intel-gfx] [PATCH] drm/i915: Always flush the active worker before returning from the wait Chris Wilson
@ 2021-01-22 5:00 ` Patchwork
2021-01-22 9:03 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-01-22 10:27 ` [Intel-gfx] [PATCH] " Matthew Auld
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2021-01-22 5:00 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 3148 bytes --]
== Series Details ==
Series: drm/i915: Always flush the active worker before returning from the wait
URL : https://patchwork.freedesktop.org/series/86161/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9666 -> Patchwork_19453
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/index.html
Known issues
------------
Here are the changes found in Patchwork_19453 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@sync-gfx0:
- fi-bsw-n3050: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/fi-bsw-n3050/igt@amdgpu/amd_cs_nop@sync-gfx0.html
* igt@i915_hangman@error-state-basic:
- fi-tgl-y: [PASS][2] -> [DMESG-WARN][3] ([i915#402]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-y/igt@i915_hangman@error-state-basic.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/fi-tgl-y/igt@i915_hangman@error-state-basic.html
#### Possible fixes ####
* igt@gem_tiled_blits@basic:
- fi-tgl-y: [DMESG-WARN][4] ([i915#402]) -> [PASS][5] +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-y/igt@gem_tiled_blits@basic.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/fi-tgl-y/igt@gem_tiled_blits@basic.html
* igt@i915_selftest@live@execlists:
- fi-bsw-n3050: [INCOMPLETE][6] ([i915#2940]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@hangcheck:
- fi-byt-j1900: [DMESG-WARN][8] -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-byt-j1900/igt@i915_selftest@live@hangcheck.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/fi-byt-j1900/igt@i915_selftest@live@hangcheck.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (41 -> 37)
------------------------------
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_9666 -> Patchwork_19453
CI-20190529: 20190529
CI_DRM_9666: 9ccbc653bf2948d1f7e9ff300dd7679b888ffa25 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5962: 22e3daaed82ab7890018a2f2aabf5082cd536023 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19453: 1ddb3f823966edb0b63902f6084089a0fb04cda8 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
1ddb3f823966 drm/i915: Always flush the active worker before returning from the wait
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/index.html
[-- Attachment #1.2: Type: text/html, Size: 3940 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Always flush the active worker before returning from the wait
2021-01-21 23:28 [Intel-gfx] [PATCH] drm/i915: Always flush the active worker before returning from the wait Chris Wilson
2021-01-22 5:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2021-01-22 9:03 ` Patchwork
2021-01-22 10:27 ` [Intel-gfx] [PATCH] " Matthew Auld
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2021-01-22 9:03 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 20650 bytes --]
== Series Details ==
Series: drm/i915: Always flush the active worker before returning from the wait
URL : https://patchwork.freedesktop.org/series/86161/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9666_full -> Patchwork_19453_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_19453_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-skl: [PASS][1] -> [INCOMPLETE][2] ([i915#198])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-skl1/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl10/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: [PASS][3] -> [FAIL][4] ([i915#2842])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-kbl6/igt@gem_exec_fair@basic-none-solo@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-kbl1/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][5] ([i915#2842])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-tglb: [PASS][6] -> [FAIL][7] ([i915#2842]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-tglb2/igt@gem_exec_fair@basic-pace@vecs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-tglb7/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-apl: [PASS][8] -> [FAIL][9] ([i915#2389])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-apl2/igt@gem_exec_reloc@basic-many-active@rcs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-apl3/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@gem_exec_schedule@u-fairslice-all:
- shard-kbl: [PASS][10] -> [DMESG-WARN][11] ([i915#1610] / [i915#2803])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-kbl6/igt@gem_exec_schedule@u-fairslice-all.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-kbl1/igt@gem_exec_schedule@u-fairslice-all.html
* igt@gem_exec_whisper@basic-contexts-priority:
- shard-glk: [PASS][12] -> [DMESG-WARN][13] ([i915#118] / [i915#95])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-glk4/igt@gem_exec_whisper@basic-contexts-priority.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-glk6/igt@gem_exec_whisper@basic-contexts-priority.html
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [PASS][14] -> [FAIL][15] ([i915#2521])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-skl8/igt@kms_async_flips@alternate-sync-async-flip.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl8/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_ccs@pipe-c-bad-pixel-format:
- shard-skl: NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111304])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl5/igt@kms_ccs@pipe-c-bad-pixel-format.html
* igt@kms_chamelium@dp-edid-read:
- shard-glk: NOTRUN -> [SKIP][17] ([fdo#109271] / [fdo#111827]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-glk6/igt@kms_chamelium@dp-edid-read.html
* igt@kms_color@pipe-a-ctm-0-75:
- shard-skl: [PASS][18] -> [DMESG-WARN][19] ([i915#1982]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-skl4/igt@kms_color@pipe-a-ctm-0-75.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl4/igt@kms_color@pipe-a-ctm-0-75.html
* igt@kms_color_chamelium@pipe-c-degamma:
- shard-skl: NOTRUN -> [SKIP][20] ([fdo#109271] / [fdo#111827]) +3 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl5/igt@kms_color_chamelium@pipe-c-degamma.html
* igt@kms_cursor_crc@pipe-a-cursor-256x85-random:
- shard-skl: NOTRUN -> [FAIL][21] ([i915#54])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-256x85-random.html
* igt@kms_cursor_crc@pipe-a-cursor-64x64-random:
- shard-skl: [PASS][22] -> [FAIL][23] ([i915#54]) +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-64x64-random.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-64x64-random.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][24] -> [FAIL][25] ([i915#72])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-glk4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-tglb: [PASS][26] -> [FAIL][27] ([i915#2598])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-tglb2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-tglb7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [PASS][28] -> [FAIL][29] ([i915#79])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_flip@plain-flip-ts-check@c-edp1:
- shard-skl: [PASS][30] -> [FAIL][31] ([i915#2122])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-skl6/igt@kms_flip@plain-flip-ts-check@c-edp1.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl7/igt@kms_flip@plain-flip-ts-check@c-edp1.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-glk: NOTRUN -> [SKIP][32] ([fdo#109271]) +5 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-glk6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-glk: NOTRUN -> [FAIL][33] ([fdo#108145] / [i915#265])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-glk6/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-skl: NOTRUN -> [FAIL][34] ([fdo#108145] / [i915#265]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][35] -> [FAIL][36] ([fdo#108145] / [i915#265])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109441]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-iclb8/igt@kms_psr@psr2_cursor_render.html
* igt@kms_vblank@pipe-d-query-forked-busy:
- shard-skl: NOTRUN -> [SKIP][39] ([fdo#109271]) +45 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl7/igt@kms_vblank@pipe-d-query-forked-busy.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][40] ([i915#2846]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-kbl3/igt@gem_exec_fair@basic-deadline.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-kbl2/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-tglb: [FAIL][42] ([i915#2842]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-tglb2/igt@gem_exec_fair@basic-pace@vcs0.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-tglb7/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_userptr_blits@huge-split:
- shard-glk: [INCOMPLETE][44] ([i915#2502]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-glk7/igt@gem_userptr_blits@huge-split.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-glk6/igt@gem_userptr_blits@huge-split.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][46] ([i915#454]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
* igt@kms_async_flips@test-time-stamp:
- shard-tglb: [FAIL][48] ([i915#2597]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-tglb5/igt@kms_async_flips@test-time-stamp.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-tglb5/igt@kms_async_flips@test-time-stamp.html
* igt@kms_color@pipe-a-ctm-0-5:
- shard-skl: [DMESG-WARN][50] ([i915#1982]) -> [PASS][51] +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-skl3/igt@kms_color@pipe-a-ctm-0-5.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl2/igt@kms_color@pipe-a-ctm-0-5.html
* igt@kms_cursor_crc@pipe-c-cursor-128x128-random:
- shard-skl: [FAIL][52] ([i915#54]) -> [PASS][53] +6 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-skl8/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl8/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- shard-skl: [FAIL][54] ([i915#2346]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
* igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic:
- shard-kbl: [DMESG-WARN][56] ([i915#95]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-kbl7/igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-kbl3/igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [FAIL][58] ([i915#2122]) -> [PASS][59] +3 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl8/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][60] ([i915#1188]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-skl8/igt@kms_hdr@bpc-switch-suspend.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl9/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][62] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-iclb4/igt@kms_psr2_su@page_flip.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [SKIP][64] ([fdo#109441]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_cpu.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@perf@polling-parameterized:
- shard-glk: [FAIL][66] ([i915#1542]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-glk7/igt@perf@polling-parameterized.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-glk8/igt@perf@polling-parameterized.html
- shard-iclb: [FAIL][68] ([i915#1542]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-iclb4/igt@perf@polling-parameterized.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-iclb2/igt@perf@polling-parameterized.html
* igt@perf_pmu@rc6-suspend:
- shard-skl: [INCOMPLETE][70] ([i915#198]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-skl10/igt@perf_pmu@rc6-suspend.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl6/igt@perf_pmu@rc6-suspend.html
#### Warnings ####
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [FAIL][72] ([i915#2852]) -> [FAIL][73] ([i915#2842])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-iclb7/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-iclb1/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][74] ([i915#1804] / [i915#2684]) -> [WARN][75] ([i915#2684])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-iclb4/igt@i915_pm_rc6_residency@rc6-fence.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][76] ([i915#1804] / [i915#2684]) -> [WARN][77] ([i915#2681] / [i915#2684])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-iclb7/igt@i915_pm_rc6_residency@rc6-idle.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][78] ([fdo#109349]) -> [DMESG-WARN][79] ([i915#1226])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-iclb4/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][80] ([i915#2920]) -> [SKIP][81] ([i915#658]) +2 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-iclb8/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][82] ([i915#658]) -> [SKIP][83] ([i915#2920]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-iclb4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
* igt@runner@aborted:
- shard-kbl: [FAIL][84] ([i915#2295]) -> ([FAIL][85], [FAIL][86]) ([i915#2295] / [i915#2426])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-kbl2/igt@runner@aborted.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-kbl1/igt@runner@aborted.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-kbl2/igt@runner@aborted.html
- shard-skl: ([FAIL][87], [FAIL][88]) ([i915#2295] / [i915#2426]) -> ([FAIL][89], [FAIL][90]) ([i915#1814] / [i915#2029] / [i915#2295])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-skl10/igt@runner@aborted.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/shard-skl1/igt@runner@aborted.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl10/igt@runner@aborted.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/shard-skl3/igt@runner@aborted.html
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2852]: https://gitlab.freedesktop.org/drm/intel/issues/2852
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9666 -> Patchwork_19453
CI-20190529: 20190529
CI_DRM_9666: 9ccbc653bf2948d1f7e9ff300dd7679b888ffa25 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5962: 22e3daaed82ab7890018a2f2aabf5082cd536023 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19453: 1ddb3f823966edb0b63902f6084089a0fb04cda8 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19453/index.html
[-- Attachment #1.2: Type: text/html, Size: 24520 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Always flush the active worker before returning from the wait
2021-01-21 23:28 [Intel-gfx] [PATCH] drm/i915: Always flush the active worker before returning from the wait Chris Wilson
2021-01-22 5:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-22 9:03 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2021-01-22 10:27 ` Matthew Auld
2 siblings, 0 replies; 4+ messages in thread
From: Matthew Auld @ 2021-01-22 10:27 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: stable
On 21/01/2021 23:28, Chris Wilson wrote:
> The first thing the active retirement worker does is decrement the
> i915_active count.
>
> The first thing we do during i915_active_wait is try to increment the
> i915_active count, but only if already active [non-zero].
>
> The wait may see that the retirement is already started and so marked the
> i915_active as idle, and skip waiting for the retirement handler.
> However, the caller of i915_active_wait may immediately free the
> i915_active upon returning (e.g. i915_vma_destroy) so we must not return
> before the concurrent access from the worker are completed. We must
> always flush the worker.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2473
> Fixes: 274cbf20fd10 ("drm/i915: Push the i915_active.retire into a worker")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: <stable@vger.kernel.org> # v5.5+
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-22 10:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 23:28 [Intel-gfx] [PATCH] drm/i915: Always flush the active worker before returning from the wait Chris Wilson
2021-01-22 5:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-22 9:03 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-01-22 10:27 ` [Intel-gfx] [PATCH] " Matthew Auld
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).