From: "Christian König" <christian.koenig@amd.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Melissa Wen <mwen@igalia.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Luben Tuikov <luben.tuikov@amd.com>,
Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [Intel-gfx] [PATCH v5 15/20] drm/sched: Check locking in drm_sched_job_await_implicit
Date: Thu, 5 Aug 2021 15:19:19 +0200 [thread overview]
Message-ID: <67fa5409-df0d-df5f-161e-695394bd7eba@amd.com> (raw)
In-Reply-To: <20210805104705.862416-16-daniel.vetter@ffwll.ch>
Am 05.08.21 um 12:47 schrieb Daniel Vetter:
> You really need to hold the reservation here or all kinds of funny
> things can happen between grabbing the dependencies and inserting the
> new fences.
>
> Acked-by: Melissa Wen <mwen@igalia.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Luben Tuikov <luben.tuikov@amd.com>
> Cc: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
The function name in the subject line should be updated, apart from that
feel free to add my rb to this patch.
Christian.
> ---
> drivers/gpu/drm/scheduler/sched_main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 49e507f91ec0..1abb40b07324 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -715,6 +715,8 @@ int drm_sched_job_add_implicit_dependencies(struct drm_sched_job *job,
> struct dma_fence **fences;
> unsigned int i, fence_count;
>
> + dma_resv_assert_held(obj->resv);
> +
> if (!write) {
> struct dma_fence *fence = dma_resv_get_excl_unlocked(obj->resv);
>
next prev parent reply other threads:[~2021-08-05 13:19 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 10:46 [Intel-gfx] [PATCH v5 00/20] drm/sched dependency handling and implicit sync fixes Daniel Vetter
2021-08-05 10:46 ` [Intel-gfx] [PATCH v5 01/20] drm/sched: Split drm_sched_job_init Daniel Vetter
2021-08-05 13:43 ` Christian König
2021-08-05 14:07 ` Daniel Vetter
2021-08-05 14:47 ` Christian König
2021-08-05 15:07 ` Daniel Vetter
2021-08-17 8:49 ` [Intel-gfx] [PATCH] " Daniel Vetter
2021-08-05 10:46 ` [Intel-gfx] [PATCH v5 02/20] drm/msm: Fix drm/sched point of no return rules Daniel Vetter
2021-08-05 23:02 ` Rob Clark
2021-08-06 16:41 ` Daniel Vetter
2021-08-06 17:19 ` Rob Clark
2021-08-06 18:41 ` Daniel Vetter
2021-08-06 19:01 ` Rob Clark
2021-08-06 19:10 ` Daniel Vetter
2021-08-06 19:59 ` Rob Clark
2021-08-17 8:53 ` [Intel-gfx] [PATCH] drm/msm: Improve " Daniel Vetter
2021-08-26 9:33 ` Daniel Vetter
2021-08-26 15:38 ` Rob Clark
2021-08-05 10:46 ` [Intel-gfx] [PATCH v5 03/20] drm/sched: Barriers are needed for entity->last_scheduled Daniel Vetter
2021-08-05 13:45 ` Christian König
2021-08-05 10:46 ` [Intel-gfx] [PATCH v5 04/20] drm/sched: Add dependency tracking Daniel Vetter
2021-08-05 13:47 ` Christian König
2021-08-05 10:46 ` [Intel-gfx] [PATCH v5 05/20] drm/sched: drop entity parameter from drm_sched_push_job Daniel Vetter
2021-08-05 13:48 ` Christian König
2021-08-05 10:46 ` [Intel-gfx] [PATCH v5 06/20] drm/sched: improve docs around drm_sched_entity Daniel Vetter
2021-08-05 10:46 ` [Intel-gfx] [PATCH v5 07/20] drm/panfrost: use scheduler dependency tracking Daniel Vetter
2021-08-05 15:10 ` Alyssa Rosenzweig
2021-08-05 10:46 ` [Intel-gfx] [PATCH v5 08/20] drm/lima: " Daniel Vetter
2021-08-12 19:28 ` Daniel Vetter
2021-08-14 2:45 ` Qiang Yu
2021-08-05 10:46 ` [Intel-gfx] [PATCH v5 09/20] drm/v3d: Move drm_sched_job_init to v3d_job_init Daniel Vetter
2021-08-05 10:46 ` [Intel-gfx] [PATCH v5 10/20] drm/v3d: Use scheduler dependency handling Daniel Vetter
2021-08-05 10:46 ` [Intel-gfx] [PATCH v5 11/20] drm/etnaviv: " Daniel Vetter
2021-08-12 19:28 ` Daniel Vetter
2021-08-05 10:46 ` [Intel-gfx] [PATCH v5 12/20] drm/msm: " Daniel Vetter
2021-08-12 19:29 ` Daniel Vetter
2021-08-26 16:12 ` Rob Clark
2021-08-30 9:01 ` Daniel Vetter
2021-08-05 10:46 ` [Intel-gfx] [PATCH v5 13/20] drm/gem: Delete gem array fencing helpers Daniel Vetter
2021-08-12 19:29 ` Daniel Vetter
2021-08-05 10:46 ` [Intel-gfx] [PATCH v5 14/20] drm/sched: Don't store self-dependencies Daniel Vetter
2021-08-05 13:18 ` Christian König
2021-08-05 13:25 ` Daniel Vetter
2021-08-05 13:57 ` Christian König
2021-08-05 15:06 ` Daniel Vetter
2021-08-05 10:47 ` [Intel-gfx] [PATCH v5 15/20] drm/sched: Check locking in drm_sched_job_await_implicit Daniel Vetter
2021-08-05 13:19 ` Christian König [this message]
2021-08-05 13:27 ` Daniel Vetter
2021-08-05 10:47 ` [Intel-gfx] [PATCH v5 16/20] drm/msm: Don't break exclusive fence ordering Daniel Vetter
2021-08-26 16:16 ` Rob Clark
2021-08-30 9:02 ` Daniel Vetter
2021-08-05 10:47 ` [Intel-gfx] [PATCH v5 17/20] drm/etnaviv: " Daniel Vetter
2021-08-05 10:47 ` [Intel-gfx] [PATCH v5 18/20] drm/i915: delete exclude argument from i915_sw_fence_await_reservation Daniel Vetter
2021-08-05 10:47 ` [Intel-gfx] [PATCH v5 19/20] drm/i915: Don't break exclusive fence ordering Daniel Vetter
2021-08-05 10:47 ` [Intel-gfx] [PATCH v5 20/20] dma-resv: Give the docs a do-over Daniel Vetter
2021-08-30 19:38 ` Daniel Vetter
2021-08-05 13:58 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/sched dependency handling and implicit sync fixes Patchwork
2021-08-05 14:29 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-08-06 19:14 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/sched dependency handling and implicit sync fixes (rev2) Patchwork
2021-08-17 16:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/sched dependency handling and implicit sync fixes (rev4) Patchwork
2021-08-17 16:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-08-17 18:15 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-08-26 13:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/sched dependency handling and implicit sync fixes (rev5) Patchwork
2021-08-26 13:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-08-26 21:46 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67fa5409-df0d-df5f-161e-695394bd7eba@amd.com \
--to=christian.koenig@amd.com \
--cc=alexander.deucher@amd.com \
--cc=andrey.grodzovsky@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=luben.tuikov@amd.com \
--cc=mwen@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).