* [Intel-gfx] [PATCH 1/2] drm/i915: Fix fast wake AUX sync len
@ 2023-03-29 17:24 Ville Syrjala
2023-03-29 17:24 ` [Intel-gfx] [PATCH 2/2] drm/i915: Explain the magic numbers for AUX SYNC/precharge length Ville Syrjala
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Ville Syrjala @ 2023-03-29 17:24 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fast wake should use 8 SYNC pulses for the preamble
and 10-16 SYNC pulses for the precharge. Recuce our
fast wake SYNC count to match the maximum value.
We also use the maximum precharge length for normal
AUX transactions.
Cc: Jouni Högander <jouni.hogander@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_aux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index eb07dc5d8709..ad0aac707219 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -164,7 +164,7 @@ static u32 skl_get_aux_send_ctl(struct intel_dp *intel_dp,
DP_AUX_CH_CTL_TIME_OUT_MAX |
DP_AUX_CH_CTL_RECEIVE_ERROR |
(send_bytes << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) |
- DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(32) |
+ DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(24) |
DP_AUX_CH_CTL_SYNC_PULSE_SKL(32);
if (intel_tc_port_in_tbt_alt_mode(dig_port))
--
2.39.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915: Explain the magic numbers for AUX SYNC/precharge length
2023-03-29 17:24 [Intel-gfx] [PATCH 1/2] drm/i915: Fix fast wake AUX sync len Ville Syrjala
@ 2023-03-29 17:24 ` Ville Syrjala
2023-03-30 7:22 ` Hogander, Jouni
2023-03-29 21:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix fast wake AUX sync len Patchwork
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Ville Syrjala @ 2023-03-29 17:24 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Replace the hardcoded final numbers in the AUX SYNC/precharge
setup, and derive those from numbers from the (e)DP specs.
The new functions can serve as the single point of truth for
the number of SYNC pulses we use.
Cc: Jouni Högander <jouni.hogander@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_aux.c | 32 +++++++++++++++++++--
1 file changed, 29 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index ad0aac707219..374492293392 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -118,6 +118,32 @@ static u32 skl_get_aux_clock_divider(struct intel_dp *intel_dp, int index)
return index ? 0 : 1;
}
+static int intel_dp_aux_sync_len(void)
+{
+ int precharge = 16; /* 10-16 */
+ int preamble = 16;
+
+ return precharge + preamble;
+}
+
+static int intel_dp_aux_fw_sync_len(void)
+{
+ int precharge = 16; /* 10-16 */
+ int preamble = 8;
+
+ return precharge + preamble;
+}
+
+static int g4x_dp_aux_precharge_len(void)
+{
+ int precharge_min = 10;
+ int preamble = 16;
+
+ /* HW wants the length of the extra precharge in 2us units */
+ return (intel_dp_aux_sync_len() -
+ precharge_min - preamble) / 2;
+}
+
static u32 g4x_get_aux_send_ctl(struct intel_dp *intel_dp,
int send_bytes,
u32 aux_clock_divider)
@@ -140,7 +166,7 @@ static u32 g4x_get_aux_send_ctl(struct intel_dp *intel_dp,
timeout |
DP_AUX_CH_CTL_RECEIVE_ERROR |
(send_bytes << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) |
- (3 << DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
+ (g4x_dp_aux_precharge_len() << DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
(aux_clock_divider << DP_AUX_CH_CTL_BIT_CLOCK_2X_SHIFT);
}
@@ -164,8 +190,8 @@ static u32 skl_get_aux_send_ctl(struct intel_dp *intel_dp,
DP_AUX_CH_CTL_TIME_OUT_MAX |
DP_AUX_CH_CTL_RECEIVE_ERROR |
(send_bytes << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) |
- DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(24) |
- DP_AUX_CH_CTL_SYNC_PULSE_SKL(32);
+ DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(intel_dp_aux_fw_sync_len()) |
+ DP_AUX_CH_CTL_SYNC_PULSE_SKL(intel_dp_aux_sync_len());
if (intel_tc_port_in_tbt_alt_mode(dig_port))
ret |= DP_AUX_CH_CTL_TBT_IO;
--
2.39.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix fast wake AUX sync len
2023-03-29 17:24 [Intel-gfx] [PATCH 1/2] drm/i915: Fix fast wake AUX sync len Ville Syrjala
2023-03-29 17:24 ` [Intel-gfx] [PATCH 2/2] drm/i915: Explain the magic numbers for AUX SYNC/precharge length Ville Syrjala
@ 2023-03-29 21:42 ` Patchwork
2023-03-30 7:27 ` [Intel-gfx] [PATCH 1/2] " Hogander, Jouni
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2023-03-29 21:42 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3825 bytes --]
== Series Details ==
Series: series starting with [1/2] drm/i915: Fix fast wake AUX sync len
URL : https://patchwork.freedesktop.org/series/115810/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12937 -> Patchwork_115810v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/index.html
Participating hosts (36 -> 34)
------------------------------
Missing (2): fi-kbl-soraka fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_115810v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3@smem:
- bat-rpls-1: [PASS][1] -> [ABORT][2] ([i915#6687] / [i915#7978])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12937/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-dg2-11: NOTRUN -> [SKIP][3] ([i915#7828])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/bat-dg2-11/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@read-crc:
- bat-dg2-11: NOTRUN -> [SKIP][4] ([i915#5354])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/bat-dg2-11/igt@kms_pipe_crc_basic@read-crc.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-glk-j4005: [DMESG-FAIL][5] ([i915#5334]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12937/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@hangcheck:
- bat-dg2-11: [ABORT][7] ([i915#7913]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12937/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
#### Warnings ####
* igt@i915_selftest@live@slpc:
- bat-rpls-1: [DMESG-FAIL][9] ([i915#6367]) -> [DMESG-FAIL][10] ([i915#6367] / [i915#7996])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12937/bat-rpls-1/igt@i915_selftest@live@slpc.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/bat-rpls-1/igt@i915_selftest@live@slpc.html
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
Build changes
-------------
* Linux: CI_DRM_12937 -> Patchwork_115810v1
CI-20190529: 20190529
CI_DRM_12937: 6848d3613c0a63382d00ff550c41394902bda903 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7226: 41be8b4ab86f9e11388c10366dfd71e5032589c1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_115810v1: 6848d3613c0a63382d00ff550c41394902bda903 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
ca3d3eda792c drm/i915: Explain the magic numbers for AUX SYNC/precharge length
39b0f8225522 drm/i915: Fix fast wake AUX sync len
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/index.html
[-- Attachment #2: Type: text/html, Size: 4638 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Explain the magic numbers for AUX SYNC/precharge length
2023-03-29 17:24 ` [Intel-gfx] [PATCH 2/2] drm/i915: Explain the magic numbers for AUX SYNC/precharge length Ville Syrjala
@ 2023-03-30 7:22 ` Hogander, Jouni
2023-03-31 11:06 ` Hogander, Jouni
0 siblings, 1 reply; 11+ messages in thread
From: Hogander, Jouni @ 2023-03-30 7:22 UTC (permalink / raw)
To: ville.syrjala, intel-gfx
On Wed, 2023-03-29 at 20:24 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Replace the hardcoded final numbers in the AUX SYNC/precharge
> setup, and derive those from numbers from the (e)DP specs.
>
> The new functions can serve as the single point of truth for
> the number of SYNC pulses we use.
>
> Cc: Jouni Högander <jouni.hogander@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux.c | 32
> +++++++++++++++++++--
> 1 file changed, 29 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index ad0aac707219..374492293392 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -118,6 +118,32 @@ static u32 skl_get_aux_clock_divider(struct
> intel_dp *intel_dp, int index)
> return index ? 0 : 1;
> }
>
> +static int intel_dp_aux_sync_len(void)
> +{
> + int precharge = 16; /* 10-16 */
> + int preamble = 16;
> +
> + return precharge + preamble;
> +}
> +
> +static int intel_dp_aux_fw_sync_len(void)
> +{
> + int precharge = 16; /* 10-16 */
> + int preamble = 8;
> +
> + return precharge + preamble;
> +}
What do you think if we move this into intel_dp_aux.h and use that to
calculate io wake time and fast wake time in
intel_psr.c:_compute_psr2_wake_time.
> +
> +static int g4x_dp_aux_precharge_len(void)
> +{
> + int precharge_min = 10;
> + int preamble = 16;
> +
> + /* HW wants the length of the extra precharge in 2us units */
> + return (intel_dp_aux_sync_len() -
> + precharge_min - preamble) / 2;
> +}
> +
> static u32 g4x_get_aux_send_ctl(struct intel_dp *intel_dp,
> int send_bytes,
> u32 aux_clock_divider)
> @@ -140,7 +166,7 @@ static u32 g4x_get_aux_send_ctl(struct intel_dp
> *intel_dp,
> timeout |
> DP_AUX_CH_CTL_RECEIVE_ERROR |
> (send_bytes << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) |
> - (3 << DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
> + (g4x_dp_aux_precharge_len() <<
> DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
> (aux_clock_divider <<
> DP_AUX_CH_CTL_BIT_CLOCK_2X_SHIFT);
> }
>
> @@ -164,8 +190,8 @@ static u32 skl_get_aux_send_ctl(struct intel_dp
> *intel_dp,
> DP_AUX_CH_CTL_TIME_OUT_MAX |
> DP_AUX_CH_CTL_RECEIVE_ERROR |
> (send_bytes << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) |
> - DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(24) |
> - DP_AUX_CH_CTL_SYNC_PULSE_SKL(32);
> +
> DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(intel_dp_aux_fw_sync_len()) |
> + DP_AUX_CH_CTL_SYNC_PULSE_SKL(intel_dp_aux_sync_len());
>
> if (intel_tc_port_in_tbt_alt_mode(dig_port))
> ret |= DP_AUX_CH_CTL_TBT_IO;
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix fast wake AUX sync len
2023-03-29 17:24 [Intel-gfx] [PATCH 1/2] drm/i915: Fix fast wake AUX sync len Ville Syrjala
2023-03-29 17:24 ` [Intel-gfx] [PATCH 2/2] drm/i915: Explain the magic numbers for AUX SYNC/precharge length Ville Syrjala
2023-03-29 21:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix fast wake AUX sync len Patchwork
@ 2023-03-30 7:27 ` Hogander, Jouni
2023-03-30 14:33 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] " Patchwork
2023-04-25 5:46 ` [Intel-gfx] " youling257
4 siblings, 0 replies; 11+ messages in thread
From: Hogander, Jouni @ 2023-03-30 7:27 UTC (permalink / raw)
To: ville.syrjala, intel-gfx
On Wed, 2023-03-29 at 20:24 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Fast wake should use 8 SYNC pulses for the preamble
> and 10-16 SYNC pulses for the precharge. Recuce our
> fast wake SYNC count to match the maximum value.
> We also use the maximum precharge length for normal
> AUX transactions.
>
> Cc: Jouni Högander <jouni.hogander@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index eb07dc5d8709..ad0aac707219 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -164,7 +164,7 @@ static u32 skl_get_aux_send_ctl(struct intel_dp
> *intel_dp,
> DP_AUX_CH_CTL_TIME_OUT_MAX |
> DP_AUX_CH_CTL_RECEIVE_ERROR |
> (send_bytes << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) |
> - DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(32) |
> + DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(24) |
> DP_AUX_CH_CTL_SYNC_PULSE_SKL(32);
>
> if (intel_tc_port_in_tbt_alt_mode(dig_port))
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Fix fast wake AUX sync len
2023-03-29 17:24 [Intel-gfx] [PATCH 1/2] drm/i915: Fix fast wake AUX sync len Ville Syrjala
` (2 preceding siblings ...)
2023-03-30 7:27 ` [Intel-gfx] [PATCH 1/2] " Hogander, Jouni
@ 2023-03-30 14:33 ` Patchwork
2023-04-25 5:46 ` [Intel-gfx] " youling257
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2023-03-30 14:33 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10392 bytes --]
== Series Details ==
Series: series starting with [1/2] drm/i915: Fix fast wake AUX sync len
URL : https://patchwork.freedesktop.org/series/115810/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12937_full -> Patchwork_115810v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_115810v1_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_pm_rpm@i2c:
- {shard-dg1}: [DMESG-WARN][1] ([i915#4391]) -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12937/shard-dg1-18/igt@i915_pm_rpm@i2c.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/shard-dg1-16/igt@i915_pm_rpm@i2c.html
Known issues
------------
Here are the changes found in Patchwork_115810v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-deadline:
- shard-apl: [PASS][3] -> [FAIL][4] ([i915#2846])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12937/shard-apl1/igt@gem_exec_fair@basic-deadline.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/shard-apl2/igt@gem_exec_fair@basic-deadline.html
* igt@i915_suspend@forcewake:
- shard-snb: [PASS][5] -> [DMESG-WARN][6] ([i915#5090])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12937/shard-snb2/igt@i915_suspend@forcewake.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/shard-snb2/igt@i915_suspend@forcewake.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#2346])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12937/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
- shard-apl: [PASS][9] -> [FAIL][10] ([i915#2346])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12937/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][11] ([i915#6268]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12937/shard-tglu-9/igt@gem_ctx_exec@basic-nohangcheck.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/shard-tglu-3/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_endless@dispatch@rcs0:
- {shard-tglu}: [TIMEOUT][13] ([i915#3778]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12937/shard-tglu-5/igt@gem_exec_endless@dispatch@rcs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/shard-tglu-7/igt@gem_exec_endless@dispatch@rcs0.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][15] ([i915#2846]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12937/shard-glk9/igt@gem_exec_fair@basic-deadline.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/shard-glk4/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-tglu}: [FAIL][17] ([i915#2842]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12937/shard-tglu-2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/shard-tglu-10/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_whisper@basic-fds-forked-all:
- {shard-tglu}: [INCOMPLETE][19] ([i915#6755] / [i915#7663]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12937/shard-tglu-10/igt@gem_exec_whisper@basic-fds-forked-all.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/shard-tglu-2/igt@gem_exec_whisper@basic-fds-forked-all.html
* igt@sysfs_heartbeat_interval@precise@rcs0:
- {shard-dg1}: [FAIL][21] ([i915#1755]) -> [PASS][22] +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12937/shard-dg1-18/igt@sysfs_heartbeat_interval@precise@rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/shard-dg1-16/igt@sysfs_heartbeat_interval@precise@rcs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#5090]: https://gitlab.freedesktop.org/drm/intel/issues/5090
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6755]: https://gitlab.freedesktop.org/drm/intel/issues/6755
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7663]: https://gitlab.freedesktop.org/drm/intel/issues/7663
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8308]: https://gitlab.freedesktop.org/drm/intel/issues/8308
Build changes
-------------
* Linux: CI_DRM_12937 -> Patchwork_115810v1
CI-20190529: 20190529
CI_DRM_12937: 6848d3613c0a63382d00ff550c41394902bda903 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7226: 41be8b4ab86f9e11388c10366dfd71e5032589c1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_115810v1: 6848d3613c0a63382d00ff550c41394902bda903 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115810v1/index.html
[-- Attachment #2: Type: text/html, Size: 7245 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Explain the magic numbers for AUX SYNC/precharge length
2023-03-30 7:22 ` Hogander, Jouni
@ 2023-03-31 11:06 ` Hogander, Jouni
0 siblings, 0 replies; 11+ messages in thread
From: Hogander, Jouni @ 2023-03-31 11:06 UTC (permalink / raw)
To: ville.syrjala, intel-gfx
On Thu, 2023-03-30 at 07:22 +0000, Hogander, Jouni wrote:
> On Wed, 2023-03-29 at 20:24 +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Replace the hardcoded final numbers in the AUX SYNC/precharge
> > setup, and derive those from numbers from the (e)DP specs.
> >
> > The new functions can serve as the single point of truth for
> > the number of SYNC pulses we use.
> >
> > Cc: Jouni Högander <jouni.hogander@intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Let's take care of that io/fast wake calculation separately. I think we
want to have these in as currently fast wake SYNC pulse count is not
according to spec.
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp_aux.c | 32
> > +++++++++++++++++++--
> > 1 file changed, 29 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > index ad0aac707219..374492293392 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > @@ -118,6 +118,32 @@ static u32 skl_get_aux_clock_divider(struct
> > intel_dp *intel_dp, int index)
> > return index ? 0 : 1;
> > }
> >
> > +static int intel_dp_aux_sync_len(void)
> > +{
> > + int precharge = 16; /* 10-16 */
> > + int preamble = 16;
> > +
> > + return precharge + preamble;
> > +}
> > +
> > +static int intel_dp_aux_fw_sync_len(void)
> > +{
> > + int precharge = 16; /* 10-16 */
> > + int preamble = 8;
> > +
> > + return precharge + preamble;
> > +}
>
> What do you think if we move this into intel_dp_aux.h and use that to
> calculate io wake time and fast wake time in
> intel_psr.c:_compute_psr2_wake_time.
>
> > +
> > +static int g4x_dp_aux_precharge_len(void)
> > +{
> > + int precharge_min = 10;
> > + int preamble = 16;
> > +
> > + /* HW wants the length of the extra precharge in 2us units
> > */
> > + return (intel_dp_aux_sync_len() -
> > + precharge_min - preamble) / 2;
> > +}
> > +
> > static u32 g4x_get_aux_send_ctl(struct intel_dp *intel_dp,
> > int send_bytes,
> > u32 aux_clock_divider)
> > @@ -140,7 +166,7 @@ static u32 g4x_get_aux_send_ctl(struct intel_dp
> > *intel_dp,
> > timeout |
> > DP_AUX_CH_CTL_RECEIVE_ERROR |
> > (send_bytes << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) |
> > - (3 << DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
> > + (g4x_dp_aux_precharge_len() <<
> > DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
> > (aux_clock_divider <<
> > DP_AUX_CH_CTL_BIT_CLOCK_2X_SHIFT);
> > }
> >
> > @@ -164,8 +190,8 @@ static u32 skl_get_aux_send_ctl(struct intel_dp
> > *intel_dp,
> > DP_AUX_CH_CTL_TIME_OUT_MAX |
> > DP_AUX_CH_CTL_RECEIVE_ERROR |
> > (send_bytes << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) |
> > - DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(24) |
> > - DP_AUX_CH_CTL_SYNC_PULSE_SKL(32);
> > +
> > DP_AUX_CH_CTL_FW_SYNC_PULSE_SKL(intel_dp_aux_fw_sync_len()) |
> > +
> > DP_AUX_CH_CTL_SYNC_PULSE_SKL(intel_dp_aux_sync_len());
> >
> > if (intel_tc_port_in_tbt_alt_mode(dig_port))
> > ret |= DP_AUX_CH_CTL_TBT_IO;
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] [1/2] drm/i915: Fix fast wake AUX sync len
2023-03-29 17:24 [Intel-gfx] [PATCH 1/2] drm/i915: Fix fast wake AUX sync len Ville Syrjala
` (3 preceding siblings ...)
2023-03-30 14:33 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] " Patchwork
@ 2023-04-25 5:46 ` youling257
2023-04-25 9:31 ` Ville Syrjälä
4 siblings, 1 reply; 11+ messages in thread
From: youling257 @ 2023-04-25 5:46 UTC (permalink / raw)
To: ville.syrjala; +Cc: intel-gfx
This patch cause suspend to disk resume later hdmi out no sound.
Revert "drm/i915: Fix fast wake AUX sync len", suspend resume hdmi sound work.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [1/2] drm/i915: Fix fast wake AUX sync len
2023-04-25 5:46 ` [Intel-gfx] " youling257
@ 2023-04-25 9:31 ` Ville Syrjälä
2023-04-25 13:52 ` youling 257
[not found] ` <CAOzgRdagsgD+8PNXhCRzqN6Pk8xympmHoA+yYM1iGK_QVcSGmw@mail.gmail.com>
0 siblings, 2 replies; 11+ messages in thread
From: Ville Syrjälä @ 2023-04-25 9:31 UTC (permalink / raw)
To: youling257; +Cc: intel-gfx
On Tue, Apr 25, 2023 at 01:46:57PM +0800, youling257 wrote:
> This patch cause suspend to disk resume later hdmi out no sound.
> Revert "drm/i915: Fix fast wake AUX sync len", suspend resume hdmi sound work.
I find that hard to believe. Fast wake is a PSR2 thing, which has
nothing to do with HDMI.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [1/2] drm/i915: Fix fast wake AUX sync len
2023-04-25 9:31 ` Ville Syrjälä
@ 2023-04-25 13:52 ` youling 257
[not found] ` <CAOzgRdagsgD+8PNXhCRzqN6Pk8xympmHoA+yYM1iGK_QVcSGmw@mail.gmail.com>
1 sibling, 0 replies; 11+ messages in thread
From: youling 257 @ 2023-04-25 13:52 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
pcmC0D3p use for hdmi sound out,
numid=13,iface=CARD,name='HDMI/DP,pcm=3 Jack'
; type=BOOLEAN,access=r-------,values=1
: values=on
this patch cause 'HDMI/DP,pcm=3 Jack' value off, hdmi sound not work,
replug hdmi cable no useful, still no sound, 'HDMI/DP,pcm=3 Jack'
unable become on, have to reboot.
2023-04-25 17:31 GMT+08:00, Ville Syrjälä <ville.syrjala@linux.intel.com>:
> On Tue, Apr 25, 2023 at 01:46:57PM +0800, youling257 wrote:
>> This patch cause suspend to disk resume later hdmi out no sound.
>> Revert "drm/i915: Fix fast wake AUX sync len", suspend resume hdmi sound
>> work.
>
> I find that hard to believe. Fast wake is a PSR2 thing, which has
> nothing to do with HDMI.
>
> --
> Ville Syrjälä
> Intel
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [1/2] drm/i915: Fix fast wake AUX sync len
[not found] ` <CAOzgRdagsgD+8PNXhCRzqN6Pk8xympmHoA+yYM1iGK_QVcSGmw@mail.gmail.com>
@ 2023-04-25 14:37 ` youling 257
0 siblings, 0 replies; 11+ messages in thread
From: youling 257 @ 2023-04-25 14:37 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
When i from kernel 6.3rc7 update to 6.3 release, it happened this hdmi
sound problem.
I retest many times, the cause of the problem is not this patch, i'm so sorry.
2023-04-25 21:52 GMT+08:00, youling 257 <youling257@gmail.com>:
> pcmC0D3p use for hdmi sound out,
> numid=13,iface=CARD,name='HDMI/DP,pcm=3 Jack'
> ; type=BOOLEAN,access=r-------,values=1
> : values=on
>
> this patch cause 'HDMI/DP,pcm=3 Jack' value off, hdmi sound not work,
> replug hdmi cable no useful, still no sound, 'HDMI/DP,pcm=3 Jack'
> unable become on, have to reboot.
>
> 2023-04-25 17:31 GMT+08:00, Ville Syrjälä <ville.syrjala@linux.intel.com>:
>> On Tue, Apr 25, 2023 at 01:46:57PM +0800, youling257 wrote:
>>> This patch cause suspend to disk resume later hdmi out no sound.
>>> Revert "drm/i915: Fix fast wake AUX sync len", suspend resume hdmi sound
>>> work.
>>
>> I find that hard to believe. Fast wake is a PSR2 thing, which has
>> nothing to do with HDMI.
>>
>> --
>> Ville Syrjälä
>> Intel
>>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2023-04-26 13:16 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-29 17:24 [Intel-gfx] [PATCH 1/2] drm/i915: Fix fast wake AUX sync len Ville Syrjala
2023-03-29 17:24 ` [Intel-gfx] [PATCH 2/2] drm/i915: Explain the magic numbers for AUX SYNC/precharge length Ville Syrjala
2023-03-30 7:22 ` Hogander, Jouni
2023-03-31 11:06 ` Hogander, Jouni
2023-03-29 21:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix fast wake AUX sync len Patchwork
2023-03-30 7:27 ` [Intel-gfx] [PATCH 1/2] " Hogander, Jouni
2023-03-30 14:33 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] " Patchwork
2023-04-25 5:46 ` [Intel-gfx] " youling257
2023-04-25 9:31 ` Ville Syrjälä
2023-04-25 13:52 ` youling 257
[not found] ` <CAOzgRdagsgD+8PNXhCRzqN6Pk8xympmHoA+yYM1iGK_QVcSGmw@mail.gmail.com>
2023-04-25 14:37 ` youling 257
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).