From: Jason Baron <jbaron@akamai.com>
To: Jim Cromie <jim.cromie@gmail.com>,
gregkh@linuxfoundation.org, seanpaul@chromium.org,
jeyu@kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v6 00/11] use DYNAMIC_DEBUG to implement DRM.debug
Date: Wed, 25 Aug 2021 13:18:44 -0400 [thread overview]
Message-ID: <7017599d-8e11-7bda-90df-3cbf39ef8f3b@akamai.com> (raw)
In-Reply-To: <20210822222009.2035788-1-jim.cromie@gmail.com>
On 8/22/21 6:19 PM, Jim Cromie wrote:
> This patchset does 3 main things.
>
> Adds DEFINE_DYNAMIC_DEBUG_CATEGORIES to define bitmap => category
> control of pr_debugs, and to create their sysfs entries.
>
> Uses it in amdgpu, i915 to control existing pr_debugs according to
> their ad-hoc categorizations.
>
> Plugs dyndbg into drm-debug framework, in a configurable manner.
>
> v6: cleans up per v5 feedback, and adds RFC stuff:
>
> - test_dynamic_debug.ko: uses tracer facility added in v5:8/9
> - prototype print-once & rate-limiting
>
> Hopefully adding RFC stuff doesnt distract too much.
Hi Jim,
Yeah, I feel like the RFC patches should be in a separate series
unless there is a drm dependency for them?
Thanks,
-Jason
>
> Jim Cromie (11):
> moduleparam: add data member to struct kernel_param
> dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks
> i915/gvt: remove spaces in pr_debug "gvt: core:" etc prefixes
> i915/gvt: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to create "gvt:core:"
> etc categories
> amdgpu: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to control categorized
> pr_debugs
> drm_print: add choice to use dynamic debug in drm-debug
> drm_print: instrument drm_debug_enabled
> amdgpu_ucode: reduce number of pr_debug calls
> nouveau: fold multiple DRM_DEBUG_DRIVERs together
> dyndbg: RFC add debug-trace callback, selftest with it. RFC
> dyndbg: RFC add print-once and print-ratelimited features. RFC.
>
> drivers/gpu/drm/Kconfig | 13 +
> drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 293 ++++++++-------
> .../gpu/drm/amd/display/dc/core/dc_debug.c | 44 ++-
> drivers/gpu/drm/drm_print.c | 49 ++-
> drivers/gpu/drm/i915/gvt/Makefile | 4 +
> drivers/gpu/drm/i915/gvt/debug.h | 18 +-
> drivers/gpu/drm/i915/i915_params.c | 35 ++
> drivers/gpu/drm/nouveau/nouveau_drm.c | 36 +-
> include/drm/drm_print.h | 148 ++++++--
> include/linux/dynamic_debug.h | 81 ++++-
> include/linux/moduleparam.h | 11 +-
> lib/Kconfig.debug | 11 +
> lib/Makefile | 1 +
> lib/dynamic_debug.c | 336 ++++++++++++++++--
> lib/test_dynamic_debug.c | 279 +++++++++++++++
> 15 files changed, 1117 insertions(+), 242 deletions(-)
> create mode 100644 lib/test_dynamic_debug.c
>
prev parent reply other threads:[~2021-08-25 18:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 22:19 [Intel-gfx] [PATCH v6 00/11] use DYNAMIC_DEBUG to implement DRM.debug Jim Cromie
2021-08-22 22:19 ` [Intel-gfx] [PATCH v6 01/11] moduleparam: add data member to struct kernel_param Jim Cromie
2021-08-25 17:12 ` Jason Baron
2021-08-27 18:04 ` jim.cromie
2021-08-22 22:20 ` [Intel-gfx] [PATCH v6 02/11] dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks Jim Cromie
2021-08-23 6:40 ` Andy Shevchenko
2021-08-23 18:36 ` jim.cromie
2021-08-25 17:17 ` Jason Baron
2021-08-22 22:20 ` [Intel-gfx] [PATCH v6 03/11] i915/gvt: remove spaces in pr_debug "gvt: core:" etc prefixes Jim Cromie
2021-08-22 22:20 ` [Intel-gfx] [PATCH v6 04/11] i915/gvt: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to create "gvt:core:" etc categories Jim Cromie
2021-08-22 22:20 ` [Intel-gfx] [PATCH v6 05/11] amdgpu: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to control categorized pr_debugs Jim Cromie
2021-08-22 22:20 ` [Intel-gfx] [PATCH v6 06/11] drm_print: add choice to use dynamic debug in drm-debug Jim Cromie
2021-08-22 22:20 ` [Intel-gfx] [PATCH v6 07/11] drm_print: instrument drm_debug_enabled Jim Cromie
2021-08-22 22:20 ` [Intel-gfx] [PATCH v6 08/11] amdgpu_ucode: reduce number of pr_debug calls Jim Cromie
2021-08-22 22:20 ` [Intel-gfx] [PATCH v6 09/11] nouveau: fold multiple DRM_DEBUG_DRIVERs together Jim Cromie
2021-08-22 22:20 ` [Intel-gfx] [PATCH v6 10/11] dyndbg: RFC add debug-trace callback, selftest with it. RFC Jim Cromie
2021-08-22 22:20 ` [Intel-gfx] [PATCH v6 11/11] dyndbg: RFC add print-once and print-ratelimited features. RFC Jim Cromie
2021-08-22 23:08 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for use DYNAMIC_DEBUG to implement DRM.debug Patchwork
2021-08-25 17:18 ` Jason Baron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7017599d-8e11-7bda-90df-3cbf39ef8f3b@akamai.com \
--to=jbaron@akamai.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jeyu@kernel.org \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).