Re: [Intel-gfx] [PATCH i-g-t] tests/core_hotunplug: Reduce debug noise on stdout

[Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>]

On Tue, 2021-01-19 at 12:08 +0100, Marcin Bernatowicz wrote:
> On Tue, 2021-01-19 at 09:42 +0100, Janusz Krzysztofik wrote:
> > Since igt_fixture sections are processed unconditionally regardless
> > of
> > which subtest has been requested, they can now emit a lot of
> > unrelated
> > debug messages which can make the picture less clear.  Avoid emitting
> > those messages from outside igt_subtest sections.
> > 
> > Move device close status prerequisite checks from igt_fixture
> > sections
> > into subtest execution paths.  For simplicity, pass any device close
> > errors, including those from health checks, to next sections via a
> > single .fd.drm data structure field.
> > 
> > Moreover, postpone initial device health check until first actually
> > selected subtest is started.  In order to let that subtest skip on
> > unsuccessful initial health check, not fail, move the decision
> > whether
> > to fail or skip on error from the health check helper to its users.
> > 
> > Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com
> > ...
> Reviewed-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>

Thank you Marcin.

CI results with no false positives finally collected after a few re-
runs, so pushed.

Thanks,
Janusz

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx