* [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp
@ 2021-08-12 5:48 Animesh Manna
2021-08-12 5:48 ` [Intel-gfx] [PATCH 1/5] drm/i915/dp: Fix eDP max rate for display 11+ Animesh Manna
` (11 more replies)
0 siblings, 12 replies; 20+ messages in thread
From: Animesh Manna @ 2021-08-12 5:48 UTC (permalink / raw)
To: intel-gfx; +Cc: Animesh Manna
HBR3 support for display gen11+ platform is depends upon some
conditions which are mentioned below.
ICL:
- eDP (only on DDI-A): Up to HBR3 for higher Vccio.
- DP:
- (DDI-B, combo phy): upto HBR2.
- (DDI-C to DDI-F): upto HBR3
RKLC:
- eDP/DP: Up to HBR3? Vccio dependent? (missing bspec pages)
JSL/EHL:
- eDP (DDI-A): Up to HBR2.
- DP (DDI-B to DDI-D): Up to HBR3 for higher Vccio _and_ retimers.
TGL:
- eDP (DDI-A to DDI-C): Up to HBR3 for higher Vccio.
- DP:
- (DDI-A to DDI-C, combo phy): Up to HBR2.
- (DDI-TC1 to DDI-TC6): Up to HBR3
DG1/ADL_S:
- eDP (all DDI is part of combo phy): Up to HBR3 for higher Vccio.
- DP (all DDI is part of combo phy): Up to HBR3 for higher Vccio _and_ retimers.
ADL_P/D13:
- eDP (DDI-A to DDI-B): Up to HBR3 for higher Vccio.
- DP:
- (DDI-A to DDI-E): Up to HBR3 for higher Vccio.
- (DDI-TC1 to DDI-TC4): Up to HBR3 for higher Vccio.
Some condition added during max rate calculation in this patch series
based on above conditions.
Animesh Manna (2):
drm/i915/dp: fix EHL/JSL max source rates calculation
drm/i915/dp: fix for ADL_P/S and DG2 dp/edp max source rates
Jani Nikula (2):
drm/i915/dp: fix TGL and ICL max source rates
drm/i915/dp: fix DG1 and RKL max source rates
Matt Atwood (1):
drm/i915/dp: Fix eDP max rate for display 11+
drivers/gpu/drm/i915/display/intel_dp.c | 62 +++++++++++++++++--------
1 file changed, 42 insertions(+), 20 deletions(-)
--
2.29.0
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Intel-gfx] [PATCH 1/5] drm/i915/dp: Fix eDP max rate for display 11+
2021-08-12 5:48 [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp Animesh Manna
@ 2021-08-12 5:48 ` Animesh Manna
2021-08-12 15:04 ` Imre Deak
2021-08-12 5:48 ` [Intel-gfx] [PATCH 2/5] drm/i915/dp: fix TGL and ICL max source rates Animesh Manna
` (10 subsequent siblings)
11 siblings, 1 reply; 20+ messages in thread
From: Animesh Manna @ 2021-08-12 5:48 UTC (permalink / raw)
To: intel-gfx
Cc: Matt Atwood, Uma Shankar, Imre Deak, Ville Syrjälä,
José Roberto de Souza, Jani Nikula, Animesh Manna
From: Matt Atwood <matthew.s.atwood@intel.com>
intel_dp_set_source_rates() calls intel_dp_is_edp(), which is unsafe to
use before intel_encoder->type is set. This causes incorrect max source
rate to be used for display 11+. On EHL and JSL, HBR3 is used instead of
HBR2, and on the other affected platforms, HBR2 is used instead of HBR3.
Move intel_dp_set_source_rates() to after intel_encoder->type is
set. Add comment to intel_dp_is_edp() describing unsafe usages. Cleanup
intel_dp_init_connector() while at it.
Note: The same change was originally added as commit 680c45c767f6
("drm/i915/dp: Correctly advertise HBR3 for GEN11+"), but later reverted
due to issues in CI in commit d3913019602e ("Revert "drm/i915/dp:
Correctly advertise HBR3 for GEN11+"").
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 28 ++++++++++---------------
1 file changed, 11 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 75d4ebc66941..4df56af36b3f 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -100,6 +100,8 @@ static const u8 valid_dsc_slicecount[] = {1, 2, 4};
*
* If a CPU or PCH DP output is attached to an eDP panel, this function
* will return true, and false otherwise.
+ *
+ * This function is not safe to use prior to encoder type being set.
*/
bool intel_dp_is_edp(struct intel_dp *intel_dp)
{
@@ -5294,8 +5296,6 @@ intel_dp_init_connector(struct intel_digital_port *dig_port,
intel_encoder->base.name))
return false;
- intel_dp_set_source_rates(intel_dp);
-
intel_dp->reset_link_params = true;
intel_dp->pps.pps_pipe = INVALID_PIPE;
intel_dp->pps.active_pipe = INVALID_PIPE;
@@ -5311,28 +5311,22 @@ intel_dp_init_connector(struct intel_digital_port *dig_port,
*/
drm_WARN_ON(dev, intel_phy_is_tc(dev_priv, phy));
type = DRM_MODE_CONNECTOR_eDP;
+ intel_encoder->type = INTEL_OUTPUT_EDP;
+
+ /* eDP only on port B and/or C on vlv/chv */
+ if (drm_WARN_ON(dev, (IS_VALLEYVIEW(dev_priv) ||
+ IS_CHERRYVIEW(dev_priv)) &&
+ port != PORT_B && port != PORT_C))
+ return false;
} else {
type = DRM_MODE_CONNECTOR_DisplayPort;
}
+ intel_dp_set_source_rates(intel_dp);
+
if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
intel_dp->pps.active_pipe = vlv_active_pipe(intel_dp);
- /*
- * For eDP we always set the encoder type to INTEL_OUTPUT_EDP, but
- * for DP the encoder type can be set by the caller to
- * INTEL_OUTPUT_UNKNOWN for DDI, so don't rewrite it.
- */
- if (type == DRM_MODE_CONNECTOR_eDP)
- intel_encoder->type = INTEL_OUTPUT_EDP;
-
- /* eDP only on port B and/or C on vlv/chv */
- if (drm_WARN_ON(dev, (IS_VALLEYVIEW(dev_priv) ||
- IS_CHERRYVIEW(dev_priv)) &&
- intel_dp_is_edp(intel_dp) &&
- port != PORT_B && port != PORT_C))
- return false;
-
drm_dbg_kms(&dev_priv->drm,
"Adding %s connector on [ENCODER:%d:%s]\n",
type == DRM_MODE_CONNECTOR_eDP ? "eDP" : "DP",
--
2.29.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [Intel-gfx] [PATCH 2/5] drm/i915/dp: fix TGL and ICL max source rates
2021-08-12 5:48 [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp Animesh Manna
2021-08-12 5:48 ` [Intel-gfx] [PATCH 1/5] drm/i915/dp: Fix eDP max rate for display 11+ Animesh Manna
@ 2021-08-12 5:48 ` Animesh Manna
2021-08-12 15:12 ` Imre Deak
2021-08-12 5:48 ` [Intel-gfx] [PATCH 3/5] drm/i915/dp: fix EHL/JSL max source rates calculation Animesh Manna
` (9 subsequent siblings)
11 siblings, 1 reply; 20+ messages in thread
From: Animesh Manna @ 2021-08-12 5:48 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Imre Deak, Animesh Manna
From: Jani Nikula <jani.nikula@intel.com>
Combo phy is limited to 5.4 GHz on low-voltage SKUs. Combo phy DP is
limited to 5.4 GHz, while combo phy eDP can do 8.1 GHz.
Bspec: 20584, 20598, 49180, 49201
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 4df56af36b3f..42b29948bc72 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -224,6 +224,15 @@ bool intel_dp_can_bigjoiner(struct intel_dp *intel_dp)
encoder->port != PORT_A);
}
+static bool is_low_voltage_sku(struct drm_i915_private *i915, enum phy phy)
+{
+ u32 voltage;
+
+ voltage = intel_de_read(i915, ICL_PORT_COMP_DW3(phy)) & VOLTAGE_INFO_MASK;
+
+ return voltage == VOLTAGE_INFO_0_85V;
+}
+
static int icl_max_source_rate(struct intel_dp *intel_dp)
{
struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
@@ -231,7 +240,7 @@ static int icl_max_source_rate(struct intel_dp *intel_dp)
enum phy phy = intel_port_to_phy(dev_priv, dig_port->base.port);
if (intel_phy_is_combo(dev_priv, phy) &&
- !intel_dp_is_edp(intel_dp))
+ (is_low_voltage_sku(dev_priv, phy) || !intel_dp_is_edp(intel_dp)))
return 540000;
return 810000;
--
2.29.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [Intel-gfx] [PATCH 3/5] drm/i915/dp: fix EHL/JSL max source rates calculation
2021-08-12 5:48 [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp Animesh Manna
2021-08-12 5:48 ` [Intel-gfx] [PATCH 1/5] drm/i915/dp: Fix eDP max rate for display 11+ Animesh Manna
2021-08-12 5:48 ` [Intel-gfx] [PATCH 2/5] drm/i915/dp: fix TGL and ICL max source rates Animesh Manna
@ 2021-08-12 5:48 ` Animesh Manna
2021-08-12 15:24 ` Imre Deak
2021-08-12 5:48 ` [Intel-gfx] [PATCH 4/5] drm/i915/dp: fix DG1 and RKL max source rates Animesh Manna
` (8 subsequent siblings)
11 siblings, 1 reply; 20+ messages in thread
From: Animesh Manna @ 2021-08-12 5:48 UTC (permalink / raw)
To: intel-gfx; +Cc: Animesh Manna, Jani Nikula, Imre Deak
Only higher voltage sku can support HBR3 so a condition
check added in max source rate calculation for ehl/jsl.
Bspec: 32247, 20598
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 42b29948bc72..d27f29477713 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -248,7 +248,11 @@ static int icl_max_source_rate(struct intel_dp *intel_dp)
static int ehl_max_source_rate(struct intel_dp *intel_dp)
{
- if (intel_dp_is_edp(intel_dp))
+ struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
+ struct drm_i915_private *dev_priv = to_i915(dig_port->base.base.dev);
+ enum phy phy = intel_port_to_phy(dev_priv, dig_port->base.port);
+
+ if (intel_dp_is_edp(intel_dp) || is_low_voltage_sku(dev_priv, phy))
return 540000;
return 810000;
--
2.29.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [Intel-gfx] [PATCH 4/5] drm/i915/dp: fix DG1 and RKL max source rates
2021-08-12 5:48 [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp Animesh Manna
` (2 preceding siblings ...)
2021-08-12 5:48 ` [Intel-gfx] [PATCH 3/5] drm/i915/dp: fix EHL/JSL max source rates calculation Animesh Manna
@ 2021-08-12 5:48 ` Animesh Manna
2021-08-12 15:40 ` Imre Deak
2021-08-12 5:48 ` [Intel-gfx] [PATCH 5/5] drm/i915/dp: fix for ADL_P/S and DG2 dp/edp " Animesh Manna
` (7 subsequent siblings)
11 siblings, 1 reply; 20+ messages in thread
From: Animesh Manna @ 2021-08-12 5:48 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Imre Deak, Animesh Manna
From: Jani Nikula <jani.nikula@intel.com>
Combo phy is limited to 5.4 GHz on low-voltage SKUs, but both eDP and DP
can do 8.1 GHz on combo phy.
Bspec: 49182, 49205, 49202
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index d27f29477713..e8d2d381c587 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -258,6 +258,18 @@ static int ehl_max_source_rate(struct intel_dp *intel_dp)
return 810000;
}
+static int dg1_max_source_rate(struct intel_dp *intel_dp)
+{
+ struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
+ struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
+ enum phy phy = intel_port_to_phy(i915, dig_port->base.port);
+
+ if (intel_phy_is_combo(i915, phy) && is_low_voltage_sku(i915, phy))
+ return 540000;
+
+ return 810000;
+}
+
static void
intel_dp_set_source_rates(struct intel_dp *intel_dp)
{
@@ -290,7 +302,9 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp)
if (DISPLAY_VER(dev_priv) >= 11) {
source_rates = icl_rates;
size = ARRAY_SIZE(icl_rates);
- if (IS_JSL_EHL(dev_priv))
+ if (IS_DG1(dev_priv) || IS_ROCKETLAKE(dev_priv))
+ max_rate = dg1_max_source_rate(intel_dp);
+ else if (IS_JSL_EHL(dev_priv))
max_rate = ehl_max_source_rate(intel_dp);
else
max_rate = icl_max_source_rate(intel_dp);
--
2.29.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [Intel-gfx] [PATCH 5/5] drm/i915/dp: fix for ADL_P/S and DG2 dp/edp max source rates
2021-08-12 5:48 [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp Animesh Manna
` (3 preceding siblings ...)
2021-08-12 5:48 ` [Intel-gfx] [PATCH 4/5] drm/i915/dp: fix DG1 and RKL max source rates Animesh Manna
@ 2021-08-12 5:48 ` Animesh Manna
2021-08-12 15:44 ` Imre Deak
2021-08-12 7:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix in max source calculation for dp/edp Patchwork
` (6 subsequent siblings)
11 siblings, 1 reply; 20+ messages in thread
From: Animesh Manna @ 2021-08-12 5:48 UTC (permalink / raw)
To: intel-gfx; +Cc: Animesh Manna, Jani Nikula, Imre Deak
Added support for platforms having DISPLAY13 like DG2, ADL_P and ADL_S.
Bspec: 53597, 53720, 53657, 54034, 49185, 55409
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index e8d2d381c587..fcb6b0cd9788 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -302,7 +302,8 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp)
if (DISPLAY_VER(dev_priv) >= 11) {
source_rates = icl_rates;
size = ARRAY_SIZE(icl_rates);
- if (IS_DG1(dev_priv) || IS_ROCKETLAKE(dev_priv))
+ if (DISPLAY_VER(dev_priv) >= 13 || IS_ALDERLAKE_S(dev_priv) ||
+ IS_DG1(dev_priv) || IS_ROCKETLAKE(dev_priv))
max_rate = dg1_max_source_rate(intel_dp);
else if (IS_JSL_EHL(dev_priv))
max_rate = ehl_max_source_rate(intel_dp);
--
2.29.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix in max source calculation for dp/edp
2021-08-12 5:48 [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp Animesh Manna
` (4 preceding siblings ...)
2021-08-12 5:48 ` [Intel-gfx] [PATCH 5/5] drm/i915/dp: fix for ADL_P/S and DG2 dp/edp " Animesh Manna
@ 2021-08-12 7:15 ` Patchwork
2021-08-12 7:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (5 subsequent siblings)
11 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2021-08-12 7:15 UTC (permalink / raw)
To: Animesh Manna; +Cc: intel-gfx
== Series Details ==
Series: Fix in max source calculation for dp/edp
URL : https://patchwork.freedesktop.org/series/93622/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
d3bee2d775fd drm/i915/dp: Fix eDP max rate for display 11+
-:20: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit d3913019602e ("Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+"")'
#20:
due to issues in CI in commit d3913019602e ("Revert "drm/i915/dp:
total: 1 errors, 0 warnings, 0 checks, 53 lines checked
11ca6e858027 drm/i915/dp: fix TGL and ICL max source rates
efac1c8cc038 drm/i915/dp: fix EHL/JSL max source rates calculation
9d0d6ab4aaa2 drm/i915/dp: fix DG1 and RKL max source rates
c92201975535 drm/i915/dp: fix for ADL_P/S and DG2 dp/edp max source rates
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Fix in max source calculation for dp/edp
2021-08-12 5:48 [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp Animesh Manna
` (5 preceding siblings ...)
2021-08-12 7:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix in max source calculation for dp/edp Patchwork
@ 2021-08-12 7:46 ` Patchwork
2021-08-12 9:32 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (4 subsequent siblings)
11 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2021-08-12 7:46 UTC (permalink / raw)
To: Animesh Manna; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4350 bytes --]
== Series Details ==
Series: Fix in max source calculation for dp/edp
URL : https://patchwork.freedesktop.org/series/93622/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10472 -> Patchwork_20800
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/index.html
Known issues
------------
Here are the changes found in Patchwork_20800 that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- fi-kbl-soraka: [PASS][1] -> [FAIL][2] ([i915#3895])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/fi-kbl-soraka/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/fi-kbl-soraka/boot.html
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-gfx:
- fi-skl-6700k2: NOTRUN -> [SKIP][3] ([fdo#109271]) +33 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/fi-skl-6700k2/igt@amdgpu/amd_basic@cs-gfx.html
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-1115g4: [PASS][4] -> [FAIL][5] ([i915#1888])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
* igt@gem_huc_copy@huc-copy:
- fi-skl-6700k2: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/fi-skl-6700k2/igt@gem_huc_copy@huc-copy.html
* igt@i915_pm_rpm@basic-rte:
- fi-skl-6700k2: NOTRUN -> [FAIL][7] ([i915#579])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/fi-skl-6700k2/igt@i915_pm_rpm@basic-rte.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-tgl-1115g4: [PASS][8] -> [DMESG-WARN][9] ([i915#1385] / [i915#1887])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/fi-tgl-1115g4/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/fi-tgl-1115g4/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-skl-6700k2: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#533])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/fi-skl-6700k2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@runner@aborted:
- fi-tgl-1115g4: NOTRUN -> [FAIL][11] ([i915#1602])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/fi-tgl-1115g4/igt@runner@aborted.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1385]: https://gitlab.freedesktop.org/drm/intel/issues/1385
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1887]: https://gitlab.freedesktop.org/drm/intel/issues/1887
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3895]: https://gitlab.freedesktop.org/drm/intel/issues/3895
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
Participating hosts (39 -> 35)
------------------------------
Additional (1): fi-skl-6700k2
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan bat-jsl-1 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_10472 -> Patchwork_20800
CI-20190529: 20190529
CI_DRM_10472: c5c1fcf35511df21cf435b1dcea1082db8de11a0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6170: d4ff2b4ab88d62a1888cb0316e70a1729fe4a685 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20800: c92201975535d5a9d6dfd40d820d2900c72d3df4 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c92201975535 drm/i915/dp: fix for ADL_P/S and DG2 dp/edp max source rates
9d0d6ab4aaa2 drm/i915/dp: fix DG1 and RKL max source rates
efac1c8cc038 drm/i915/dp: fix EHL/JSL max source rates calculation
11ca6e858027 drm/i915/dp: fix TGL and ICL max source rates
d3bee2d775fd drm/i915/dp: Fix eDP max rate for display 11+
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/index.html
[-- Attachment #2: Type: text/html, Size: 5297 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for Fix in max source calculation for dp/edp
2021-08-12 5:48 [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp Animesh Manna
` (6 preceding siblings ...)
2021-08-12 7:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-08-12 9:32 ` Patchwork
2021-08-23 6:21 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix in max source calculation for dp/edp (rev2) Patchwork
` (3 subsequent siblings)
11 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2021-08-12 9:32 UTC (permalink / raw)
To: Animesh Manna; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30255 bytes --]
== Series Details ==
Series: Fix in max source calculation for dp/edp
URL : https://patchwork.freedesktop.org/series/93622/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10472_full -> Patchwork_20800_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_20800_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_20800_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20800_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-apl8/igt@kms_flip@flip-vs-suspend@c-dp1.html
Known issues
------------
Here are the changes found in Patchwork_20800_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@engines-cleanup:
- shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099]) +2 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-snb5/igt@gem_ctx_persistence@engines-cleanup.html
* igt@gem_ctx_persistence@legacy-engines-hang@render:
- shard-tglb: [PASS][3] -> [FAIL][4] ([i915#2410])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-tglb6/igt@gem_ctx_persistence@legacy-engines-hang@render.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-tglb8/igt@gem_ctx_persistence@legacy-engines-hang@render.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2846])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-glk1/igt@gem_exec_fair@basic-deadline.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-glk6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][7] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-iclb4/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [PASS][10] -> [FAIL][11] ([i915#2842]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-tglb5/igt@gem_exec_fair@basic-pace@bcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-tglb6/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: NOTRUN -> [FAIL][12] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_schedule@semaphore-codependency:
- shard-snb: NOTRUN -> [SKIP][13] ([fdo#109271]) +322 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-snb5/igt@gem_exec_schedule@semaphore-codependency.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][14] -> [SKIP][15] ([i915#2190])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-tglb3/igt@gem_huc_copy@huc-copy.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-tglb6/igt@gem_huc_copy@huc-copy.html
- shard-apl: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#2190])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-apl7/igt@gem_huc_copy@huc-copy.html
* igt@gem_userptr_blits@input-checking:
- shard-snb: NOTRUN -> [DMESG-WARN][17] ([i915#3002])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-snb2/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][18] ([i915#2724])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-snb5/igt@gem_userptr_blits@vma-merge.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-skl: [PASS][19] -> [INCOMPLETE][20] ([i915#146] / [i915#198] / [i915#2405])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-skl1/igt@gem_workarounds@suspend-resume-fd.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl5/igt@gem_workarounds@suspend-resume-fd.html
* igt@i915_pm_dc@dc5-dpms:
- shard-skl: NOTRUN -> [FAIL][21] ([i915#545])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl9/igt@i915_pm_dc@dc5-dpms.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][22] -> [DMESG-WARN][23] ([i915#180])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-kbl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#3777])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-kbl4/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3886]) +6 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-kbl4/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3886]) +7 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-apl8/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][27] ([fdo#109271]) +115 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-kbl1/igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cdclk@mode-transition:
- shard-apl: NOTRUN -> [SKIP][28] ([fdo#109271]) +292 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-apl1/igt@kms_cdclk@mode-transition.html
* igt@kms_chamelium@hdmi-hpd-with-enabled-mode:
- shard-kbl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +10 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-kbl4/igt@kms_chamelium@hdmi-hpd-with-enabled-mode.html
* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-skl: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl9/igt@kms_chamelium@vga-hpd-after-suspend.html
* igt@kms_color@pipe-c-ctm-0-75:
- shard-skl: [PASS][31] -> [DMESG-WARN][32] ([i915#1982]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-skl5/igt@kms_color@pipe-c-ctm-0-75.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl1/igt@kms_color@pipe-c-ctm-0-75.html
* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-snb: NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +15 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-snb6/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +18 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-apl3/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html
* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> [TIMEOUT][35] ([i915#1319]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-apl7/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@uevent:
- shard-kbl: NOTRUN -> [FAIL][36] ([i915#2105])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-kbl1/igt@kms_content_protection@uevent.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-skl: NOTRUN -> [SKIP][37] ([fdo#109271]) +60 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl9/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#533]) +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-apl1/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_flip@flip-vs-suspend@b-dp1:
- shard-apl: NOTRUN -> [DMESG-WARN][39] ([i915#180])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-apl8/igt@kms_flip@flip-vs-suspend@b-dp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [PASS][40] -> [FAIL][41] ([i915#2122])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-skl8/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl8/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-skl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#2672])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl9/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
- shard-apl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#2672])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-apl3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-cpu:
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#111825])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-kbl: NOTRUN -> [FAIL][45] ([i915#2546])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][46] -> [FAIL][47] ([i915#1188]) +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-skl9/igt@kms_hdr@bpc-switch-dpms.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl10/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-kbl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#533])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-kbl1/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-kbl: [PASS][49] -> [DMESG-WARN][50] ([i915#180]) +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][51] ([fdo#108145] / [i915#265]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-kbl2/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][52] -> [FAIL][53] ([fdo#108145] / [i915#265])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-skl: NOTRUN -> [FAIL][54] ([fdo#108145] / [i915#265])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][55] ([fdo#108145] / [i915#265]) +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-apl8/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][56] ([i915#265])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1:
- shard-skl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#658])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl9/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#658]) +5 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-apl7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-kbl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#658]) +3 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-kbl1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][60] -> [SKIP][61] ([fdo#109441]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-iclb7/igt@kms_psr@psr2_primary_page_flip.html
* igt@perf_pmu@rc6-suspend:
- shard-skl: [PASS][62] -> [INCOMPLETE][63] ([i915#198] / [i915#2910])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-skl5/igt@perf_pmu@rc6-suspend.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl3/igt@perf_pmu@rc6-suspend.html
* igt@sysfs_clients@recycle:
- shard-apl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#2994]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-apl6/igt@sysfs_clients@recycle.html
#### Possible fixes ####
* igt@fbdev@write:
- {shard-rkl}: [SKIP][65] ([i915#2582]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-1/igt@fbdev@write.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@fbdev@write.html
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][67] ([i915#658]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-iclb3/igt@feature_discovery@psr2.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [DMESG-WARN][69] ([i915#180]) -> [PASS][70] +6 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@vcs0.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-kbl4/igt@gem_ctx_isolation@preservation-s3@vcs0.html
* igt@gem_ctx_persistence@legacy-engines-hang@render:
- shard-skl: [FAIL][71] ([i915#2410]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-skl7/igt@gem_ctx_persistence@legacy-engines-hang@render.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl6/igt@gem_ctx_persistence@legacy-engines-hang@render.html
- shard-glk: [FAIL][73] ([i915#2410]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-glk9/igt@gem_ctx_persistence@legacy-engines-hang@render.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-glk4/igt@gem_ctx_persistence@legacy-engines-hang@render.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [FAIL][75] ([i915#2842]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-tglb1/igt@gem_exec_fair@basic-none-share@rcs0.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-tglb3/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-kbl: [FAIL][77] ([i915#2842]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-kbl3/igt@gem_exec_fair@basic-none@vecs0.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-kbl3/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- {shard-rkl}: [FAIL][79] ([i915#2842]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-2/igt@gem_exec_fair@basic-throttle@rcs0.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-2/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_reloc@basic-scanout@vecs0:
- {shard-rkl}: [SKIP][81] ([i915#3639]) -> [PASS][82] +3 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-2/igt@gem_exec_reloc@basic-scanout@vecs0.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@gem_exec_reloc@basic-scanout@vecs0.html
* igt@gem_mmap_gtt@cpuset-big-copy-xy:
- shard-iclb: [FAIL][83] ([i915#307]) -> [PASS][84] +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-iclb6/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-iclb3/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
- {shard-rkl}: [FAIL][85] ([i915#307]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-2/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-2/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
* igt@i915_selftest@live@gt_pm:
- {shard-rkl}: [DMESG-FAIL][87] ([i915#1021]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-5/igt@i915_selftest@live@gt_pm.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-1/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@forcewake:
- shard-apl: [DMESG-WARN][89] ([i915#180]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-apl8/igt@i915_suspend@forcewake.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-apl8/igt@i915_suspend@forcewake.html
* igt@kms_big_fb@linear-8bpp-rotate-180:
- {shard-rkl}: [SKIP][91] ([i915#3638]) -> [PASS][92] +3 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-1/igt@kms_big_fb@linear-8bpp-rotate-180.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@kms_big_fb@linear-8bpp-rotate-180.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- {shard-rkl}: [SKIP][93] ([i915#3721]) -> [PASS][94] +5 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-2/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_big_fb@y-tiled-32bpp-rotate-90:
- {shard-rkl}: [SKIP][95] ([fdo#111614]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-1/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [FAIL][97] ([i915#3678]) -> [PASS][98] +10 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-5/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_color@pipe-a-ctm-0-75:
- {shard-rkl}: [SKIP][99] ([i915#1149] / [i915#1849]) -> [PASS][100] +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-1/igt@kms_color@pipe-a-ctm-0-75.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@kms_color@pipe-a-ctm-0-75.html
* igt@kms_cursor_crc@pipe-a-cursor-256x85-random:
- {shard-rkl}: [SKIP][101] ([fdo#112022]) -> [PASS][102] +16 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-5/igt@kms_cursor_crc@pipe-a-cursor-256x85-random.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-256x85-random.html
* igt@kms_cursor_legacy@cursora-vs-flipa-atomic:
- {shard-rkl}: [SKIP][103] ([fdo#111825]) -> [PASS][104] +4 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-1/igt@kms_cursor_legacy@cursora-vs-flipa-atomic.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@kms_cursor_legacy@cursora-vs-flipa-atomic.html
* igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-untiled:
- {shard-rkl}: [SKIP][105] ([fdo#111314]) -> [PASS][106] +7 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-1/igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-untiled.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-untiled.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1:
- shard-kbl: [FAIL][107] ([i915#79]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-kbl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-kbl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [FAIL][109] ([i915#2122]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-skl8/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl8/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-pwrite:
- {shard-rkl}: [SKIP][111] ([i915#1849] / [i915#3180]) -> [PASS][112] +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-pwrite.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-render:
- {shard-rkl}: [SKIP][113] ([i915#1849]) -> [PASS][114] +54 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-1/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-render.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-render.html
* igt@kms_plane@plane-position-hole@pipe-b-planes:
- {shard-rkl}: [SKIP][115] ([i915#3558]) -> [PASS][116] +5 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-1/igt@kms_plane@plane-position-hole@pipe-b-planes.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@kms_plane@plane-position-hole@pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][117] ([fdo#108145] / [i915#265]) -> [PASS][118] +1 similar issue
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- {shard-rkl}: [SKIP][119] ([i915#1849] / [i915#3558]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-5/igt@kms_plane_multiple@atomic-pipe-c-tiling-y.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@kms_plane_multiple@atomic-pipe-c-tiling-y.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][121] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-iclb1/igt@kms_psr2_su@frontbuffer.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][123] ([fdo#109441]) -> [PASS][124] +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-iclb1/igt@kms_psr@psr2_no_drrs.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@kms_psr@sprite_plane_move:
- {shard-rkl}: [SKIP][125] ([i915#1072]) -> [PASS][126] +4 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-5/igt@kms_psr@sprite_plane_move.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@kms_psr@sprite_plane_move.html
* igt@kms_vblank@pipe-a-ts-continuation-modeset:
- {shard-rkl}: [SKIP][127] ([i915#1845]) -> [PASS][128] +25 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-2/igt@kms_vblank@pipe-a-ts-continuation-modeset.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@kms_vblank@pipe-a-ts-continuation-modeset.html
* igt@perf@blocking:
- {shard-rkl}: [FAIL][129] ([i915#1542]) -> [PASS][130] +1 similar issue
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-5/igt@perf@blocking.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-6/igt@perf@blocking.html
* igt@perf@polling-parameterized:
- shard-skl: [FAIL][131] ([i915#1542]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-skl9/igt@perf@polling-parameterized.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl7/igt@perf@polling-parameterized.html
* igt@perf@polling-small-buf:
- shard-skl: [FAIL][133] ([i915#1722]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-skl8/igt@perf@polling-small-buf.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl8/igt@perf@polling-small-buf.html
* igt@perf_pmu@rc6-runtime-pm:
- {shard-rkl}: [SKIP][135] ([i915#293]) -> [PASS][136]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-rkl-6/igt@perf_pmu@rc6-runtime-pm.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-rkl-2/igt@perf_pmu@rc6-runtime-pm.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][137] ([i915#1804] / [i915#2684]) -> [FAIL][138] ([i915#2680])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-iclb4/igt@i915_pm_rc6_residency@rc6-idle.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-skl: [FAIL][139] ([i915#3722]) -> [FAIL][140] ([i915#1888] / [i915#3722])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-skl9/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-skl10/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1:
- shard-iclb: [SKIP][141] ([i915#658]) -> [SKIP][142] ([i915#2920])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-iclb3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-1:
- shard-iclb: [SKIP][143] ([i915#2920]) -> [SKIP][144] ([i915#658]) +1 similar issue
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10472/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area-1.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/shard-iclb5/igt@kms_psr2_sf@plane-move-sf-dmg-area-1.html
* igt@runner@aborted:
- shard-kbl:
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20800/index.html
[-- Attachment #2: Type: text/html, Size: 33304 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH 1/5] drm/i915/dp: Fix eDP max rate for display 11+
2021-08-12 5:48 ` [Intel-gfx] [PATCH 1/5] drm/i915/dp: Fix eDP max rate for display 11+ Animesh Manna
@ 2021-08-12 15:04 ` Imre Deak
2021-08-13 10:34 ` Manna, Animesh
0 siblings, 1 reply; 20+ messages in thread
From: Imre Deak @ 2021-08-12 15:04 UTC (permalink / raw)
To: Animesh Manna
Cc: intel-gfx, Matt Atwood, Uma Shankar, Ville Syrjälä,
José Roberto de Souza, Jani Nikula
On Thu, Aug 12, 2021 at 11:18:02AM +0530, Animesh Manna wrote:
> From: Matt Atwood <matthew.s.atwood@intel.com>
>
> intel_dp_set_source_rates() calls intel_dp_is_edp(), which is unsafe to
> use before intel_encoder->type is set. This causes incorrect max source
> rate to be used for display 11+. On EHL and JSL, HBR3 is used instead of
> HBR2, and on the other affected platforms, HBR2 is used instead of HBR3.
>
> Move intel_dp_set_source_rates() to after intel_encoder->type is
> set. Add comment to intel_dp_is_edp() describing unsafe usages. Cleanup
> intel_dp_init_connector() while at it.
>
> Note: The same change was originally added as commit 680c45c767f6
> ("drm/i915/dp: Correctly advertise HBR3 for GEN11+"), but later reverted
> due to issues in CI in commit d3913019602e ("Revert "drm/i915/dp:
> Correctly advertise HBR3 for GEN11+"").
AFAIR, this issue was that TGL started to use TPS4, which somehow broke
link training on the panel connected to that box. But I think TPS4 is
supported on TGL, regardless of the link rate used, so this change looks
ok wrt. that.
As a side-note allowing TPS4 only on ports supporting HBR3 looks
incorrect, I think TPS4 is either supported or not by a platform
regardless of what is the max link rate. Due to that we may stop using
TPS4 on EHL/JSL after this patchset, but I think that can be fixed
separately.
> Cc: Uma Shankar <uma.shankar@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 28 ++++++++++---------------
> 1 file changed, 11 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 75d4ebc66941..4df56af36b3f 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -100,6 +100,8 @@ static const u8 valid_dsc_slicecount[] = {1, 2, 4};
> *
> * If a CPU or PCH DP output is attached to an eDP panel, this function
> * will return true, and false otherwise.
> + *
> + * This function is not safe to use prior to encoder type being set.
> */
> bool intel_dp_is_edp(struct intel_dp *intel_dp)
> {
> @@ -5294,8 +5296,6 @@ intel_dp_init_connector(struct intel_digital_port *dig_port,
> intel_encoder->base.name))
> return false;
>
> - intel_dp_set_source_rates(intel_dp);
> -
> intel_dp->reset_link_params = true;
> intel_dp->pps.pps_pipe = INVALID_PIPE;
> intel_dp->pps.active_pipe = INVALID_PIPE;
> @@ -5311,28 +5311,22 @@ intel_dp_init_connector(struct intel_digital_port *dig_port,
> */
> drm_WARN_ON(dev, intel_phy_is_tc(dev_priv, phy));
> type = DRM_MODE_CONNECTOR_eDP;
> + intel_encoder->type = INTEL_OUTPUT_EDP;
> +
> + /* eDP only on port B and/or C on vlv/chv */
> + if (drm_WARN_ON(dev, (IS_VALLEYVIEW(dev_priv) ||
> + IS_CHERRYVIEW(dev_priv)) &&
> + port != PORT_B && port != PORT_C))
> + return false;
> } else {
> type = DRM_MODE_CONNECTOR_DisplayPort;
> }
>
> + intel_dp_set_source_rates(intel_dp);
> +
> if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
> intel_dp->pps.active_pipe = vlv_active_pipe(intel_dp);
>
> - /*
> - * For eDP we always set the encoder type to INTEL_OUTPUT_EDP, but
> - * for DP the encoder type can be set by the caller to
> - * INTEL_OUTPUT_UNKNOWN for DDI, so don't rewrite it.
> - */
> - if (type == DRM_MODE_CONNECTOR_eDP)
> - intel_encoder->type = INTEL_OUTPUT_EDP;
> -
> - /* eDP only on port B and/or C on vlv/chv */
> - if (drm_WARN_ON(dev, (IS_VALLEYVIEW(dev_priv) ||
> - IS_CHERRYVIEW(dev_priv)) &&
> - intel_dp_is_edp(intel_dp) &&
> - port != PORT_B && port != PORT_C))
> - return false;
> -
> drm_dbg_kms(&dev_priv->drm,
> "Adding %s connector on [ENCODER:%d:%s]\n",
> type == DRM_MODE_CONNECTOR_eDP ? "eDP" : "DP",
> --
> 2.29.0
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH 2/5] drm/i915/dp: fix TGL and ICL max source rates
2021-08-12 5:48 ` [Intel-gfx] [PATCH 2/5] drm/i915/dp: fix TGL and ICL max source rates Animesh Manna
@ 2021-08-12 15:12 ` Imre Deak
0 siblings, 0 replies; 20+ messages in thread
From: Imre Deak @ 2021-08-12 15:12 UTC (permalink / raw)
To: Animesh Manna; +Cc: intel-gfx, Jani Nikula
On Thu, Aug 12, 2021 at 11:18:03AM +0530, Animesh Manna wrote:
> From: Jani Nikula <jani.nikula@intel.com>
>
> Combo phy is limited to 5.4 GHz on low-voltage SKUs. Combo phy DP is
> limited to 5.4 GHz, while combo phy eDP can do 8.1 GHz.
>
> Bspec: 20584, 20598, 49180, 49201
>
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 4df56af36b3f..42b29948bc72 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -224,6 +224,15 @@ bool intel_dp_can_bigjoiner(struct intel_dp *intel_dp)
> encoder->port != PORT_A);
> }
>
> +static bool is_low_voltage_sku(struct drm_i915_private *i915, enum phy phy)
> +{
> + u32 voltage;
> +
> + voltage = intel_de_read(i915, ICL_PORT_COMP_DW3(phy)) & VOLTAGE_INFO_MASK;
> +
> + return voltage == VOLTAGE_INFO_0_85V;
> +}
> +
> static int icl_max_source_rate(struct intel_dp *intel_dp)
> {
> struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
> @@ -231,7 +240,7 @@ static int icl_max_source_rate(struct intel_dp *intel_dp)
> enum phy phy = intel_port_to_phy(dev_priv, dig_port->base.port);
>
> if (intel_phy_is_combo(dev_priv, phy) &&
> - !intel_dp_is_edp(intel_dp))
> + (is_low_voltage_sku(dev_priv, phy) || !intel_dp_is_edp(intel_dp)))
> return 540000;
>
> return 810000;
> --
> 2.29.0
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH 3/5] drm/i915/dp: fix EHL/JSL max source rates calculation
2021-08-12 5:48 ` [Intel-gfx] [PATCH 3/5] drm/i915/dp: fix EHL/JSL max source rates calculation Animesh Manna
@ 2021-08-12 15:24 ` Imre Deak
0 siblings, 0 replies; 20+ messages in thread
From: Imre Deak @ 2021-08-12 15:24 UTC (permalink / raw)
To: Animesh Manna; +Cc: intel-gfx, Jani Nikula
On Thu, Aug 12, 2021 at 11:18:04AM +0530, Animesh Manna wrote:
> Only higher voltage sku can support HBR3 so a condition
> check added in max source rate calculation for ehl/jsl.
>
> Bspec: 32247, 20598
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 42b29948bc72..d27f29477713 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -248,7 +248,11 @@ static int icl_max_source_rate(struct intel_dp *intel_dp)
>
> static int ehl_max_source_rate(struct intel_dp *intel_dp)
> {
> - if (intel_dp_is_edp(intel_dp))
> + struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
> + struct drm_i915_private *dev_priv = to_i915(dig_port->base.base.dev);
> + enum phy phy = intel_port_to_phy(dev_priv, dig_port->base.port);
> +
> + if (intel_dp_is_edp(intel_dp) || is_low_voltage_sku(dev_priv, phy))
> return 540000;
>
> return 810000;
> --
> 2.29.0
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH 4/5] drm/i915/dp: fix DG1 and RKL max source rates
2021-08-12 5:48 ` [Intel-gfx] [PATCH 4/5] drm/i915/dp: fix DG1 and RKL max source rates Animesh Manna
@ 2021-08-12 15:40 ` Imre Deak
0 siblings, 0 replies; 20+ messages in thread
From: Imre Deak @ 2021-08-12 15:40 UTC (permalink / raw)
To: Animesh Manna; +Cc: intel-gfx, Jani Nikula
On Thu, Aug 12, 2021 at 11:18:05AM +0530, Animesh Manna wrote:
> From: Jani Nikula <jani.nikula@intel.com>
>
> Combo phy is limited to 5.4 GHz on low-voltage SKUs, but both eDP and DP
> can do 8.1 GHz on combo phy.
>
> Bspec: 49182, 49205, 49202
>
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index d27f29477713..e8d2d381c587 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -258,6 +258,18 @@ static int ehl_max_source_rate(struct intel_dp *intel_dp)
> return 810000;
> }
>
> +static int dg1_max_source_rate(struct intel_dp *intel_dp)
> +{
> + struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
> + struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
> + enum phy phy = intel_port_to_phy(i915, dig_port->base.port);
> +
> + if (intel_phy_is_combo(i915, phy) && is_low_voltage_sku(i915, phy))
> + return 540000;
> +
> + return 810000;
> +}
> +
> static void
> intel_dp_set_source_rates(struct intel_dp *intel_dp)
> {
> @@ -290,7 +302,9 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp)
> if (DISPLAY_VER(dev_priv) >= 11) {
> source_rates = icl_rates;
> size = ARRAY_SIZE(icl_rates);
> - if (IS_JSL_EHL(dev_priv))
> + if (IS_DG1(dev_priv) || IS_ROCKETLAKE(dev_priv))
> + max_rate = dg1_max_source_rate(intel_dp);
> + else if (IS_JSL_EHL(dev_priv))
> max_rate = ehl_max_source_rate(intel_dp);
> else
> max_rate = icl_max_source_rate(intel_dp);
> --
> 2.29.0
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH 5/5] drm/i915/dp: fix for ADL_P/S and DG2 dp/edp max source rates
2021-08-12 5:48 ` [Intel-gfx] [PATCH 5/5] drm/i915/dp: fix for ADL_P/S and DG2 dp/edp " Animesh Manna
@ 2021-08-12 15:44 ` Imre Deak
0 siblings, 0 replies; 20+ messages in thread
From: Imre Deak @ 2021-08-12 15:44 UTC (permalink / raw)
To: Animesh Manna; +Cc: intel-gfx, Jani Nikula
On Thu, Aug 12, 2021 at 11:18:06AM +0530, Animesh Manna wrote:
> Added support for platforms having DISPLAY13 like DG2, ADL_P and ADL_S.
>
> Bspec: 53597, 53720, 53657, 54034, 49185, 55409
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index e8d2d381c587..fcb6b0cd9788 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -302,7 +302,8 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp)
> if (DISPLAY_VER(dev_priv) >= 11) {
> source_rates = icl_rates;
> size = ARRAY_SIZE(icl_rates);
> - if (IS_DG1(dev_priv) || IS_ROCKETLAKE(dev_priv))
> + if (DISPLAY_VER(dev_priv) >= 13 || IS_ALDERLAKE_S(dev_priv) ||
> + IS_DG1(dev_priv) || IS_ROCKETLAKE(dev_priv))
> max_rate = dg1_max_source_rate(intel_dp);
> else if (IS_JSL_EHL(dev_priv))
> max_rate = ehl_max_source_rate(intel_dp);
> --
> 2.29.0
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH 1/5] drm/i915/dp: Fix eDP max rate for display 11+
2021-08-12 15:04 ` Imre Deak
@ 2021-08-13 10:34 ` Manna, Animesh
0 siblings, 0 replies; 20+ messages in thread
From: Manna, Animesh @ 2021-08-13 10:34 UTC (permalink / raw)
To: Deak, Imre
Cc: intel-gfx, Atwood, Matthew S, Shankar, Uma,
Ville Syrjälä,
Souza, Jose, Nikula, Jani
> -----Original Message-----
> From: Deak, Imre <imre.deak@intel.com>
> Sent: Thursday, August 12, 2021 8:34 PM
> To: Manna, Animesh <animesh.manna@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Atwood, Matthew S
> <matthew.s.atwood@intel.com>; Shankar, Uma <uma.shankar@intel.com>;
> Ville Syrjälä <ville.syrjala@linux.intel.com>; Souza, Jose
> <jose.souza@intel.com>; Nikula, Jani <jani.nikula@intel.com>
> Subject: Re: [PATCH 1/5] drm/i915/dp: Fix eDP max rate for display 11+
>
> On Thu, Aug 12, 2021 at 11:18:02AM +0530, Animesh Manna wrote:
> > From: Matt Atwood <matthew.s.atwood@intel.com>
> >
> > intel_dp_set_source_rates() calls intel_dp_is_edp(), which is unsafe
> > to use before intel_encoder->type is set. This causes incorrect max
> > source rate to be used for display 11+. On EHL and JSL, HBR3 is used
> > instead of HBR2, and on the other affected platforms, HBR2 is used instead of
> HBR3.
> >
> > Move intel_dp_set_source_rates() to after intel_encoder->type is set.
> > Add comment to intel_dp_is_edp() describing unsafe usages. Cleanup
> > intel_dp_init_connector() while at it.
> >
> > Note: The same change was originally added as commit 680c45c767f6
> > ("drm/i915/dp: Correctly advertise HBR3 for GEN11+"), but later
> > reverted due to issues in CI in commit d3913019602e ("Revert "drm/i915/dp:
> > Correctly advertise HBR3 for GEN11+"").
>
> AFAIR, this issue was that TGL started to use TPS4, which somehow broke link
> training on the panel connected to that box. But I think TPS4 is supported on
> TGL, regardless of the link rate used, so this change looks ok wrt. that.
>
> As a side-note allowing TPS4 only on ports supporting HBR3 looks incorrect, I
> think TPS4 is either supported or not by a platform regardless of what is the max
> link rate. Due to that we may stop using
> TPS4 on EHL/JSL after this patchset, but I think that can be fixed separately.
Ok. HBR3 needs TPS4, maybe lttpr also need TPS4 which need to be handled.
>
> > Cc: Uma Shankar <uma.shankar@intel.com>
> > Cc: Imre Deak <imre.deak@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Animesh Manna <animesh.manna@intel.com>
>
> Reviewed-by: Imre Deak <imre.deak@intel.com>
Thanks for review.
Regards,
Animesh
>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp.c | 28
> > ++++++++++---------------
> > 1 file changed, 11 insertions(+), 17 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> > b/drivers/gpu/drm/i915/display/intel_dp.c
> > index 75d4ebc66941..4df56af36b3f 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -100,6 +100,8 @@ static const u8 valid_dsc_slicecount[] = {1, 2, 4};
> > *
> > * If a CPU or PCH DP output is attached to an eDP panel, this function
> > * will return true, and false otherwise.
> > + *
> > + * This function is not safe to use prior to encoder type being set.
> > */
> > bool intel_dp_is_edp(struct intel_dp *intel_dp) { @@ -5294,8 +5296,6
> > @@ intel_dp_init_connector(struct intel_digital_port *dig_port,
> > intel_encoder->base.name))
> > return false;
> >
> > - intel_dp_set_source_rates(intel_dp);
> > -
> > intel_dp->reset_link_params = true;
> > intel_dp->pps.pps_pipe = INVALID_PIPE;
> > intel_dp->pps.active_pipe = INVALID_PIPE; @@ -5311,28 +5311,22 @@
> > intel_dp_init_connector(struct intel_digital_port *dig_port,
> > */
> > drm_WARN_ON(dev, intel_phy_is_tc(dev_priv, phy));
> > type = DRM_MODE_CONNECTOR_eDP;
> > + intel_encoder->type = INTEL_OUTPUT_EDP;
> > +
> > + /* eDP only on port B and/or C on vlv/chv */
> > + if (drm_WARN_ON(dev, (IS_VALLEYVIEW(dev_priv) ||
> > + IS_CHERRYVIEW(dev_priv)) &&
> > + port != PORT_B && port != PORT_C))
> > + return false;
> > } else {
> > type = DRM_MODE_CONNECTOR_DisplayPort;
> > }
> >
> > + intel_dp_set_source_rates(intel_dp);
> > +
> > if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
> > intel_dp->pps.active_pipe = vlv_active_pipe(intel_dp);
> >
> > - /*
> > - * For eDP we always set the encoder type to INTEL_OUTPUT_EDP, but
> > - * for DP the encoder type can be set by the caller to
> > - * INTEL_OUTPUT_UNKNOWN for DDI, so don't rewrite it.
> > - */
> > - if (type == DRM_MODE_CONNECTOR_eDP)
> > - intel_encoder->type = INTEL_OUTPUT_EDP;
> > -
> > - /* eDP only on port B and/or C on vlv/chv */
> > - if (drm_WARN_ON(dev, (IS_VALLEYVIEW(dev_priv) ||
> > - IS_CHERRYVIEW(dev_priv)) &&
> > - intel_dp_is_edp(intel_dp) &&
> > - port != PORT_B && port != PORT_C))
> > - return false;
> > -
> > drm_dbg_kms(&dev_priv->drm,
> > "Adding %s connector on [ENCODER:%d:%s]\n",
> > type == DRM_MODE_CONNECTOR_eDP ? "eDP" : "DP",
> > --
> > 2.29.0
> >
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix in max source calculation for dp/edp (rev2)
2021-08-12 5:48 [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp Animesh Manna
` (7 preceding siblings ...)
2021-08-12 9:32 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2021-08-23 6:21 ` Patchwork
2021-08-23 6:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
11 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2021-08-23 6:21 UTC (permalink / raw)
To: Manna, Animesh; +Cc: intel-gfx
== Series Details ==
Series: Fix in max source calculation for dp/edp (rev2)
URL : https://patchwork.freedesktop.org/series/93622/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
b4ce1a67c5b8 drm/i915/dp: Fix eDP max rate for display 11+
-:20: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit d3913019602e ("Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+"")'
#20:
due to issues in CI in commit d3913019602e ("Revert "drm/i915/dp:
total: 1 errors, 0 warnings, 0 checks, 53 lines checked
87cefe9bc3eb drm/i915/dp: fix TGL and ICL max source rates
b2a58b5d5a42 drm/i915/dp: fix EHL/JSL max source rates calculation
c5926a3624a8 drm/i915/dp: fix DG1 and RKL max source rates
8c6040f53b02 drm/i915/dp: fix for ADL_P/S and DG2 dp/edp max source rates
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Fix in max source calculation for dp/edp (rev2)
2021-08-12 5:48 [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp Animesh Manna
` (8 preceding siblings ...)
2021-08-23 6:21 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix in max source calculation for dp/edp (rev2) Patchwork
@ 2021-08-23 6:52 ` Patchwork
2021-08-23 8:09 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-09-01 11:20 ` [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp Jani Nikula
11 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2021-08-23 6:52 UTC (permalink / raw)
To: Manna, Animesh; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5897 bytes --]
== Series Details ==
Series: Fix in max source calculation for dp/edp (rev2)
URL : https://patchwork.freedesktop.org/series/93622/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10506 -> Patchwork_20870
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/index.html
Known issues
------------
Here are the changes found in Patchwork_20870 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +23 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][3] ([i915#1886] / [i915#2291])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@workarounds:
- fi-rkl-guc: [PASS][4] -> [DMESG-FAIL][5] ([i915#3928])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/fi-rkl-guc/igt@i915_selftest@live@workarounds.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/fi-rkl-guc/igt@i915_selftest@live@workarounds.html
* igt@kms_busy@basic@modeset:
- fi-tgl-1115g4: [PASS][6] -> [DMESG-WARN][7] ([i915#4002])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/fi-tgl-1115g4/igt@kms_busy@basic@modeset.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/fi-tgl-1115g4/igt@kms_busy@basic@modeset.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +8 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#533])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-rkl-11600: [PASS][10] -> [SKIP][11] ([i915#3919])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/fi-rkl-11600/igt@kms_pipe_crc_basic@read-crc-pipe-a.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/fi-rkl-11600/igt@kms_pipe_crc_basic@read-crc-pipe-a.html
* igt@runner@aborted:
- fi-rkl-guc: NOTRUN -> [FAIL][12] ([i915#3928])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/fi-rkl-guc/igt@runner@aborted.html
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- fi-tgl-1115g4: [DMESG-WARN][13] ([i915#4002]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/fi-tgl-1115g4/igt@core_hotunplug@unbind-rebind.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/fi-tgl-1115g4/igt@core_hotunplug@unbind-rebind.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-1115g4: [FAIL][15] ([i915#1888]) -> [DMESG-WARN][16] ([i915#4002])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
* igt@kms_chamelium@dp-hpd-fast:
- fi-tgl-1115g4: [SKIP][17] ([fdo#111827] / [i915#1385]) -> [SKIP][18] ([fdo#111827])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/fi-tgl-1115g4/igt@kms_chamelium@dp-hpd-fast.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/fi-tgl-1115g4/igt@kms_chamelium@dp-hpd-fast.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1385]: https://gitlab.freedesktop.org/drm/intel/issues/1385
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#3919]: https://gitlab.freedesktop.org/drm/intel/issues/3919
[i915#3928]: https://gitlab.freedesktop.org/drm/intel/issues/3928
[i915#4002]: https://gitlab.freedesktop.org/drm/intel/issues/4002
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Participating hosts (38 -> 34)
------------------------------
Additional (1): fi-kbl-soraka
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan bat-jsl-1 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_10506 -> Patchwork_20870
CI-20190529: 20190529
CI_DRM_10506: d6681095a2aa987fa64c6d0ed991674745589c06 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6181: e7a9ab2f21a67b1ab3f4093ec0bd775647308ba6 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20870: 8c6040f53b02acc1d6140a973a6d342769056bed @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
8c6040f53b02 drm/i915/dp: fix for ADL_P/S and DG2 dp/edp max source rates
c5926a3624a8 drm/i915/dp: fix DG1 and RKL max source rates
b2a58b5d5a42 drm/i915/dp: fix EHL/JSL max source rates calculation
87cefe9bc3eb drm/i915/dp: fix TGL and ICL max source rates
b4ce1a67c5b8 drm/i915/dp: Fix eDP max rate for display 11+
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/index.html
[-- Attachment #2: Type: text/html, Size: 7343 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for Fix in max source calculation for dp/edp (rev2)
2021-08-12 5:48 [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp Animesh Manna
` (9 preceding siblings ...)
2021-08-23 6:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-08-23 8:09 ` Patchwork
2021-09-01 11:20 ` [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp Jani Nikula
11 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2021-08-23 8:09 UTC (permalink / raw)
To: Manna, Animesh; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30270 bytes --]
== Series Details ==
Series: Fix in max source calculation for dp/edp (rev2)
URL : https://patchwork.freedesktop.org/series/93622/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10506_full -> Patchwork_20870_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_20870_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-snb7/igt@gem_ctx_persistence@legacy-engines-mixed-process.html
* igt@gem_exec_fair@basic-none@rcs0:
- shard-kbl: [PASS][2] -> [FAIL][3] ([i915#2842]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-kbl4/igt@gem_exec_fair@basic-none@rcs0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-kbl7/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][4] -> [FAIL][5] ([i915#2842]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [PASS][6] -> [FAIL][7] ([i915#2842]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-glk6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_media_vme:
- shard-skl: NOTRUN -> [SKIP][8] ([fdo#109271]) +58 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl7/igt@gem_media_vme.html
* igt@gem_pwrite@basic-exhaustion:
- shard-skl: NOTRUN -> [WARN][9] ([i915#2658])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl3/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_userptr_blits@vma-merge:
- shard-apl: NOTRUN -> [FAIL][10] ([i915#3318])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl7/igt@gem_userptr_blits@vma-merge.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][11] -> [DMESG-WARN][12] ([i915#1436] / [i915#716])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl4/igt@gen9_exec_parse@allowed-single.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl9/igt@gen9_exec_parse@allowed-single.html
* igt@i915_selftest@live@gt_pm:
- shard-skl: NOTRUN -> [DMESG-FAIL][13] ([i915#1886] / [i915#2291])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl3/igt@i915_selftest@live@gt_pm.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][14] ([i915#3722])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl3/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#3777]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl3/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-270:
- shard-iclb: [PASS][16] -> [DMESG-WARN][17] ([i915#3621])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb8/igt@kms_big_fb@yf-tiled-32bpp-rotate-270.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-iclb1/igt@kms_big_fb@yf-tiled-32bpp-rotate-270.html
* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#3886]) +3 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl7/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#3886]) +12 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl2/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@dp-crc-fast:
- shard-snb: NOTRUN -> [SKIP][20] ([fdo#109271] / [fdo#111827]) +14 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-snb5/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_color_chamelium@pipe-d-degamma:
- shard-skl: NOTRUN -> [SKIP][21] ([fdo#109271] / [fdo#111827]) +5 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl7/igt@kms_color_chamelium@pipe-d-degamma.html
* igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes:
- shard-apl: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827]) +23 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl3/igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes.html
* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][23] ([i915#1319]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl8/igt@kms_content_protection@lic.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-snb: NOTRUN -> [SKIP][24] ([fdo#109271]) +310 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-snb5/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#533]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl6/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled:
- shard-skl: [PASS][26] -> [DMESG-WARN][27] ([i915#1982])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl3/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl2/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled.html
* igt@kms_flip@flip-vs-expired-vblank@a-dp1:
- shard-kbl: [PASS][28] -> [FAIL][29] ([i915#79])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-kbl1/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-kbl7/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html
- shard-apl: [PASS][30] -> [FAIL][31] ([i915#79])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl6/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl2/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [PASS][32] -> [DMESG-WARN][33] ([i915#180]) +4 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: NOTRUN -> [FAIL][34] ([i915#2122])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl3/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#2672]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- shard-skl: [PASS][36] -> [INCOMPLETE][37] ([i915#198])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl9/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl5/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][38] ([fdo#108145] / [i915#265]) +3 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl3/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][39] ([i915#265])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl8/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
- shard-skl: NOTRUN -> [FAIL][40] ([i915#265])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-skl: NOTRUN -> [FAIL][41] ([fdo#108145] / [i915#265])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][42] -> [FAIL][43] ([fdo#108145] / [i915#265])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#2733])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl3/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#658]) +4 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
- shard-skl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#658]) +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][47] -> [SKIP][48] ([fdo#109441]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-iclb5/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#2437]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl7/igt@kms_writeback@writeback-check-output.html
* igt@perf@polling-parameterized:
- shard-skl: [PASS][50] -> [FAIL][51] ([i915#1542])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl1/igt@perf@polling-parameterized.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl7/igt@perf@polling-parameterized.html
* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271]) +266 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl7/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html
* igt@syncobj_wait@multi-wait-all-for-submit-unsubmitted:
- shard-iclb: [PASS][53] -> [DMESG-WARN][54] ([i915#1226])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb3/igt@syncobj_wait@multi-wait-all-for-submit-unsubmitted.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-iclb2/igt@syncobj_wait@multi-wait-all-for-submit-unsubmitted.html
* igt@sysfs_clients@busy:
- shard-skl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#2994])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl3/igt@sysfs_clients@busy.html
* igt@sysfs_clients@pidname:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#2994]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl3/igt@sysfs_clients@pidname.html
#### Possible fixes ####
* igt@gem_ctx_persistence@legacy-engines-hang@blt:
- {shard-rkl}: [FAIL][57] ([i915#2410]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-rkl-5/igt@gem_ctx_persistence@legacy-engines-hang@blt.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-rkl-1/igt@gem_ctx_persistence@legacy-engines-hang@blt.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [FAIL][59] ([i915#2842]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk3/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-glk5/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- {shard-rkl}: [FAIL][61] ([i915#2842]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-rkl-1/igt@gem_exec_fair@basic-none-share@rcs0.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-rkl-5/igt@gem_exec_fair@basic-none-share@rcs0.html
- shard-apl: [SKIP][63] ([fdo#109271]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl8/igt@gem_exec_fair@basic-none-share@rcs0.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl7/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][65] ([i915#2842]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-kbl4/igt@gem_exec_fair@basic-none@vcs0.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-kbl7/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-tglb: [FAIL][67] ([i915#2842]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-tglb6/igt@gem_exec_fair@basic-pace@vecs0.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-tglb7/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_reloc@basic-wc-read:
- shard-apl: [DMESG-WARN][69] ([i915#165]) -> [PASS][70] +12 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl1/igt@gem_exec_reloc@basic-wc-read.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl1/igt@gem_exec_reloc@basic-wc-read.html
* igt@gem_exec_suspend@basic-s4-devices:
- {shard-rkl}: [INCOMPLETE][71] ([i915#3189] / [i915#3810]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-rkl-2/igt@gem_exec_suspend@basic-s4-devices.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-rkl-1/igt@gem_exec_suspend@basic-s4-devices.html
* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-glk: [DMESG-WARN][73] ([i915#118] / [i915#95]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk9/igt@gem_exec_whisper@basic-contexts-forked-all.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-glk9/igt@gem_exec_whisper@basic-contexts-forked-all.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][75] ([i915#3921]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-snb5/igt@i915_selftest@live@hangcheck.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-snb6/igt@i915_selftest@live@hangcheck.html
* igt@kms_color@pipe-c-ctm-0-75:
- shard-skl: [DMESG-WARN][77] ([i915#1982]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl8/igt@kms_color@pipe-c-ctm-0-75.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl4/igt@kms_color@pipe-c-ctm-0-75.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-apl: [DMESG-WARN][79] ([i915#203]) -> [PASS][80] +8 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl1/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl1/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-skl: [FAIL][81] ([i915#2346]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_flip@flip-vs-absolute-wf_vblank@b-edp1:
- shard-skl: [FAIL][83] ([i915#2122]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl4/igt@kms_flip@flip-vs-absolute-wf_vblank@b-edp1.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl9/igt@kms_flip@flip-vs-absolute-wf_vblank@b-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-glk: [FAIL][85] ([i915#79]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk4/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-glk8/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-apl: [DMESG-WARN][87] ([i915#180]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][89] ([fdo#108145] / [i915#265]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid:
- shard-apl: [DMESG-WARN][91] ([i915#165] / [i915#180] / [i915#62]) -> [PASS][92] +23 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl1/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl1/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid.html
* igt@kms_plane_cursor@pipe-a-overlay-size-64:
- shard-apl: [DMESG-WARN][93] ([i915#180] / [i915#203] / [i915#62]) -> [PASS][94] +2 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl1/igt@kms_plane_cursor@pipe-a-overlay-size-64.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl1/igt@kms_plane_cursor@pipe-a-overlay-size-64.html
* igt@kms_psr@psr2_primary_render:
- shard-iclb: [SKIP][95] ([fdo#109441]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb3/igt@kms_psr@psr2_primary_render.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-iclb2/igt@kms_psr@psr2_primary_render.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][97] ([i915#180] / [i915#295]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-apl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-skl: [INCOMPLETE][99] ([i915#198] / [i915#2828]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl3/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl3/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@perf@blocking-parameterized:
- {shard-rkl}: [FAIL][101] ([i915#3793]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-rkl-5/igt@perf@blocking-parameterized.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-rkl-1/igt@perf@blocking-parameterized.html
* igt@perf@polling-parameterized:
- shard-glk: [FAIL][103] ([i915#1542]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk8/igt@perf@polling-parameterized.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-glk1/igt@perf@polling-parameterized.html
- {shard-rkl}: [FAIL][105] ([i915#1542]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-rkl-5/igt@perf@polling-parameterized.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-rkl-1/igt@perf@polling-parameterized.html
* igt@perf@polling-small-buf:
- shard-skl: [FAIL][107] ([i915#1722]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl7/igt@perf@polling-small-buf.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl4/igt@perf@polling-small-buf.html
* igt@sysfs_timeslice_duration@timeout@rcs0:
- {shard-rkl}: [FAIL][109] ([i915#3259]) -> [PASS][110] +3 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-rkl-5/igt@sysfs_timeslice_duration@timeout@rcs0.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-rkl-1/igt@sysfs_timeslice_duration@timeout@rcs0.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][111] ([i915#1804] / [i915#2684]) -> [FAIL][112] ([i915#2680])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb4/igt@i915_pm_rc6_residency@rc6-idle.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-iclb8/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: [FAIL][113] ([i915#3743]) -> [FAIL][114] ([i915#3722])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl2/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl1/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-iclb: [SKIP][115] ([i915#2920]) -> [SKIP][116] ([i915#658])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-iclb5/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-iclb: [SKIP][117] ([i915#658]) -> [SKIP][118] ([i915#2920])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html
* igt@runner@aborted:
- shard-iclb: [FAIL][119] ([i915#3002]) -> [FAIL][120] ([i915#1814])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb7/igt@runner@aborted.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-iclb1/igt@runner@aborted.html
- shard-skl: [FAIL][121] ([i915#3002] / [i915#3363]) -> ([FAIL][122], [FAIL][123], [FAIL][124]) ([i915#1436] / [i915#1814] / [i915#2029] / [i915#3002] / [i915#3363])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl8/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl3/igt@runner@aborted.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl5/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/shard-skl9/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1021]: https://gitlab.freedesktop.org/drm/intel/issues/1021
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#203]: https://gitlab.freedesktop.org/drm/intel/issues/203
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2680]: https://gitlab.freedesktop.org/drm/intel/issues/2680
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2733]: https://gitlab.freedesktop.org/drm/intel/issues/2733
[i915#2828]: https://gitlab.freedesktop.org/drm/intel/issues/2828
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2876]: https://gitlab.freedesktop.org/drm/intel/issues/2876
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#307]: https://gitlab.freedesktop.org/drm/intel/issues/307
[i915#3189]: https://gitlab.freedesktop.org/drm/intel/issues/3189
[i915#3259]: https://gitlab.freedesktop.org/drm/intel/issues/3259
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3343]: https://gitlab.freedesktop.org/drm/intel/issues/3343
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3621]: https://gitlab.freedesktop.org/drm/intel/issues/3621
[i915#3722]: https://gitlab.freedesktop.org/drm/intel/issues/3722
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3777]: https://gitlab.freedesktop.org/drm/intel/issues/3777
[i915#3793]: https://gitlab.freedesktop.org/drm/intel/issues/3793
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3811]: https://gitlab.freedesktop.org/drm/intel/issues/3811
[i915#3830]: https://gitlab.freedesktop.org/drm/intel/issues/3830
[i915#3833]: https://gitlab.freedesktop.org/drm/intel/issues/3833
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_10506 -> Patchwork_20870
CI-20190529: 20190529
CI_DRM_10506: d6681095a2aa987fa64c6d0ed991674745589c06 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6181: e7a9ab2f21a67b1ab3f4093ec0bd775647308ba6 @ https://gitlab.f
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20870/index.html
[-- Attachment #2: Type: text/html, Size: 36559 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp
2021-08-12 5:48 [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp Animesh Manna
` (10 preceding siblings ...)
2021-08-23 8:09 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2021-09-01 11:20 ` Jani Nikula
11 siblings, 0 replies; 20+ messages in thread
From: Jani Nikula @ 2021-09-01 11:20 UTC (permalink / raw)
To: Animesh Manna, intel-gfx; +Cc: Animesh Manna
On Thu, 12 Aug 2021, Animesh Manna <animesh.manna@intel.com> wrote:
> HBR3 support for display gen11+ platform is depends upon some
> conditions which are mentioned below.
The series no longer applies, please rebase and resend.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Intel-gfx] [PATCH 1/5] drm/i915/dp: Fix eDP max rate for display 11+
2021-09-01 16:03 Animesh Manna
@ 2021-09-01 16:03 ` Animesh Manna
0 siblings, 0 replies; 20+ messages in thread
From: Animesh Manna @ 2021-09-01 16:03 UTC (permalink / raw)
To: intel-gfx
Cc: Matt Atwood, Uma Shankar, Imre Deak, Ville Syrjälä,
José Roberto de Souza, Jani Nikula, Animesh Manna
From: Matt Atwood <matthew.s.atwood@intel.com>
intel_dp_set_source_rates() calls intel_dp_is_edp(), which is unsafe to
use before intel_encoder->type is set. This causes incorrect max source
rate to be used for display 11+. On EHL and JSL, HBR3 is used instead of
HBR2, and on the other affected platforms, HBR2 is used instead of HBR3.
Move intel_dp_set_source_rates() to after intel_encoder->type is
set. Add comment to intel_dp_is_edp() describing unsafe usages. Cleanup
intel_dp_init_connector() while at it.
Note: The same change was originally added as commit 680c45c767f6
("drm/i915/dp: Correctly advertise HBR3 for GEN11+"), but later reverted
due to issues in CI in commit d3913019602e ("Revert "drm/i915/dp:
Correctly advertise HBR3 for GEN11+"").
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 28 ++++++++++---------------
1 file changed, 11 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 4f2fd33529ca..7e823c02c1e9 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -102,6 +102,8 @@ static const u8 valid_dsc_slicecount[] = {1, 2, 4};
*
* If a CPU or PCH DP output is attached to an eDP panel, this function
* will return true, and false otherwise.
+ *
+ * This function is not safe to use prior to encoder type being set.
*/
bool intel_dp_is_edp(struct intel_dp *intel_dp)
{
@@ -4899,8 +4901,6 @@ intel_dp_init_connector(struct intel_digital_port *dig_port,
intel_encoder->base.name))
return false;
- intel_dp_set_source_rates(intel_dp);
-
intel_dp->reset_link_params = true;
intel_dp->pps.pps_pipe = INVALID_PIPE;
intel_dp->pps.active_pipe = INVALID_PIPE;
@@ -4916,28 +4916,22 @@ intel_dp_init_connector(struct intel_digital_port *dig_port,
*/
drm_WARN_ON(dev, intel_phy_is_tc(dev_priv, phy));
type = DRM_MODE_CONNECTOR_eDP;
+ intel_encoder->type = INTEL_OUTPUT_EDP;
+
+ /* eDP only on port B and/or C on vlv/chv */
+ if (drm_WARN_ON(dev, (IS_VALLEYVIEW(dev_priv) ||
+ IS_CHERRYVIEW(dev_priv)) &&
+ port != PORT_B && port != PORT_C))
+ return false;
} else {
type = DRM_MODE_CONNECTOR_DisplayPort;
}
+ intel_dp_set_source_rates(intel_dp);
+
if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
intel_dp->pps.active_pipe = vlv_active_pipe(intel_dp);
- /*
- * For eDP we always set the encoder type to INTEL_OUTPUT_EDP, but
- * for DP the encoder type can be set by the caller to
- * INTEL_OUTPUT_UNKNOWN for DDI, so don't rewrite it.
- */
- if (type == DRM_MODE_CONNECTOR_eDP)
- intel_encoder->type = INTEL_OUTPUT_EDP;
-
- /* eDP only on port B and/or C on vlv/chv */
- if (drm_WARN_ON(dev, (IS_VALLEYVIEW(dev_priv) ||
- IS_CHERRYVIEW(dev_priv)) &&
- intel_dp_is_edp(intel_dp) &&
- port != PORT_B && port != PORT_C))
- return false;
-
drm_dbg_kms(&dev_priv->drm,
"Adding %s connector on [ENCODER:%d:%s]\n",
type == DRM_MODE_CONNECTOR_eDP ? "eDP" : "DP",
--
2.29.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
end of thread, other threads:[~2021-09-01 16:26 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-12 5:48 [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp Animesh Manna
2021-08-12 5:48 ` [Intel-gfx] [PATCH 1/5] drm/i915/dp: Fix eDP max rate for display 11+ Animesh Manna
2021-08-12 15:04 ` Imre Deak
2021-08-13 10:34 ` Manna, Animesh
2021-08-12 5:48 ` [Intel-gfx] [PATCH 2/5] drm/i915/dp: fix TGL and ICL max source rates Animesh Manna
2021-08-12 15:12 ` Imre Deak
2021-08-12 5:48 ` [Intel-gfx] [PATCH 3/5] drm/i915/dp: fix EHL/JSL max source rates calculation Animesh Manna
2021-08-12 15:24 ` Imre Deak
2021-08-12 5:48 ` [Intel-gfx] [PATCH 4/5] drm/i915/dp: fix DG1 and RKL max source rates Animesh Manna
2021-08-12 15:40 ` Imre Deak
2021-08-12 5:48 ` [Intel-gfx] [PATCH 5/5] drm/i915/dp: fix for ADL_P/S and DG2 dp/edp " Animesh Manna
2021-08-12 15:44 ` Imre Deak
2021-08-12 7:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix in max source calculation for dp/edp Patchwork
2021-08-12 7:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-08-12 9:32 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-08-23 6:21 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix in max source calculation for dp/edp (rev2) Patchwork
2021-08-23 6:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-08-23 8:09 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-09-01 11:20 ` [Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp Jani Nikula
2021-09-01 16:03 Animesh Manna
2021-09-01 16:03 ` [Intel-gfx] [PATCH 1/5] drm/i915/dp: Fix eDP max rate for display 11+ Animesh Manna
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).