From: Chris Wilson <chris@chris-wilson.co.uk>
To: Paul Menzel <paulepanter@users.sourceforge.net>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915/tv: Remember the detected TV type
Date: Tue, 12 Apr 2011 09:43:17 +0100 [thread overview]
Message-ID: <849307$cea27j@azsmga001.ch.intel.com> (raw)
In-Reply-To: <1302597281.4323.21.camel@mattotaupa>
On Tue, 12 Apr 2011 10:34:41 +0200, Paul Menzel <paulepanter@users.sourceforge.net> wrote:
> Am Dienstag, den 12.04.2011, 06:51 +0100 schrieb Chris Wilson:
> > This fixes a regression from 7b334fcb45b757ffb093696ca3de1b0c8b4a33f1.
>
> To quote Mark Brown [1].
>
> Always include the subject line of the commit in patches -
> readers are unlikely to have memorised commit IDs.
Does it really help to include the subject as well? I suppose it will help
in the case where the patch has been cherry-picked into other trees,
stable for instance. However, I truly didn't expect anyone to remember the
original commit as the first thing I do is to read through the identified
commit to try and understand the subsequent patch in context.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-04-12 8:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 5:51 i915 TV fixes Chris Wilson
2011-04-12 5:51 ` [PATCH 1/3] drm/i915/tv: Remember the detected TV type Chris Wilson
2011-04-12 8:34 ` Paul Menzel
2011-04-12 8:43 ` Chris Wilson [this message]
2011-04-12 9:21 ` Paul Menzel
2011-04-12 5:51 ` [PATCH 2/3] drm/i915/tv: Only poll for TV connections Chris Wilson
2011-04-12 5:51 ` [PATCH 3/3] drm/i915/tv: Fix modeset flickering introduced in 7f58aabc3 Chris Wilson
2011-04-12 15:16 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='849307$cea27j@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulepanter@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).