From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 2/4] drm/i915: kill obj->gtt_offset
Date: Fri, 15 Apr 2011 19:56:10 +0100 [thread overview]
Message-ID: <849307$cgjlsv@azsmga001.ch.intel.com> (raw)
In-Reply-To: <1302893858-8234-3-git-send-email-daniel.vetter@ffwll.ch>
On Fri, 15 Apr 2011 20:57:36 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Yet another massive round of sed'ing.
The only hitch here is that in the vmap code obj->gtt_offset !=
obj->gtt_space.offset.
There obj->gtt_space.offset is the base of the page aligned region allocated
in the GTT and obj->gtt_offset is obj->gtt_space.offset +
offset_in_page(user_addr).
I haven't checked but is obj->gtt_space immutable by the caller, i.e. can
we modify obj->gtt_space.offset and drm_mm still function correctly? Bake
the page aligned assumption into drm_mm? Or simply undo the page_offset
when releasing the gtt_space...? The latter sounds like it would work
best.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-04-15 18:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 18:57 [PATCH 0/4] embed drm_mm_node Daniel Vetter
2011-04-15 18:57 ` [PATCH 1/4] drm/i915: embed struct drm_mm_node into struct drm_i915_gem_object Daniel Vetter
2011-04-15 23:01 ` Dave Airlie
2011-04-16 10:59 ` Daniel Vetter
2011-04-15 18:57 ` [PATCH 2/4] drm/i915: kill obj->gtt_offset Daniel Vetter
2011-04-15 18:56 ` Chris Wilson [this message]
2011-04-15 19:19 ` Daniel Vetter
2011-04-15 20:04 ` Chris Wilson
2011-04-15 18:57 ` [PATCH 3/4] drm/i915: kill gtt_list Daniel Vetter
2011-04-15 18:57 ` [PATCH 4/4] drm/i915: use drm_mm_for_each_scanned_node_reverse helper Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='849307$cgjlsv@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).