From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm/i915: don't block resume on fb console resume
Date: Fri, 02 Nov 2012 13:35:58 +0000 [thread overview]
Message-ID: <84c8a8$6cfk8a@orsmga001.jf.intel.com> (raw)
In-Reply-To: <1351723265-4086-1-git-send-email-jbarnes@virtuousgeek.org>
On Wed, 31 Oct 2012 15:41:02 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> The console lock can be contended, so rather than prevent other drivers
> after us from being held up, queue the console suspend into the global
> work queue that can happen anytime. I've measured this to take around
> 200ms on my T420. Combined with the ring freq/turbo change, we should
> save almost 1/2 a second on resume.
Hmm, I'd rather not postpone the work unless actually contended,
otherwise we may end up just increasing the resume time whilst avoiding
the blame. Perhaps:
if (console_trylock() {
intel_fbdev_set_suspend(dev, 0);
console_unlock();
} else
schedule_work(&dev_priv->console_resume_work);
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-11-02 13:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 22:41 [PATCH 1/4] drm/i915: don't block resume on fb console resume Jesse Barnes
2012-10-31 22:41 ` [PATCH 2/4] drm/i915: put ring frequency and turbo setup into a work queue v3 Jesse Barnes
2012-11-02 13:37 ` Chris Wilson
2012-10-31 22:41 ` [PATCH 3/4] drm/i915: protect RPS/RC6 related accesses (including PCU) with a new mutex Jesse Barnes
2012-11-02 13:38 ` Chris Wilson
2012-10-31 22:41 ` [PATCH 4/4] drm/i915: don't rewrite the GTT on resume v3 Jesse Barnes
2012-11-02 15:16 ` Chris Wilson
2012-11-02 16:40 ` Jesse Barnes
2012-11-02 13:35 ` Chris Wilson [this message]
2012-11-04 21:16 ` [PATCH 1/4] drm/i915: don't block resume on fb console resume Paul Menzel
2012-11-04 23:12 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='84c8a8$6cfk8a@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).