From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/perf: Do not clear pollin for small user read buffers
Date: Thu, 26 Mar 2020 18:28:15 -0700 [thread overview]
Message-ID: <871rpetwls.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20200326180246.GB9553@orsosgc001.amr.corp.intel.com>
On Thu, 26 Mar 2020 11:02:46 -0700, Umesh Nerlige Ramappa wrote:
> On Wed, Mar 25, 2020 at 06:52:52PM -0700, Dixit, Ashutosh wrote:
> > On Wed, 25 Mar 2020 17:32:35 -0700, Umesh Nerlige Ramappa wrote:
> >>
> >> On Wed, Mar 25, 2020 at 11:20:19AM -0700, Ashutosh Dixit wrote:
> >> >
> >> > + /* Possible values for __ret are 0, -EFAULT, -ENOSPC, -EAGAIN, ... */
> >>
> >> __ret may never be EAGAIN either (comment^). I don't see EAGAIN in the read
> >> path.
> >
> > It's here:
> >
> > gen8_append_oa_reports()
> > {
> >
> > /*
> > * An invalid tail pointer here means we're still waiting for the poll
> > * hrtimer callback to give us a pointer
> > */
> > if (tail == INVALID_TAIL_PTR)
> > return -EAGAIN;
> > }
>
> Oh, you are right, EAGAIN is returned here. I was looking for it with the
> poll period patch series applied and these references are removed in that
> series.
No, you are right, since that series is likely to be merged first, it is
better to remove it from this patch.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-27 1:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 18:20 [Intel-gfx] [PATCH] drm/i915/perf: Do not clear pollin for small user read buffers Ashutosh Dixit
2020-03-25 19:25 ` Lionel Landwerlin
2020-03-25 20:44 ` Dixit, Ashutosh
2020-03-25 19:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-03-26 0:26 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-03-26 0:32 ` [Intel-gfx] [PATCH] " Umesh Nerlige Ramappa
2020-03-26 1:52 ` Dixit, Ashutosh
2020-03-26 18:02 ` Umesh Nerlige Ramappa
2020-03-27 1:28 ` Dixit, Ashutosh [this message]
2020-03-26 4:43 Ashutosh Dixit
2020-03-26 9:09 ` Lionel Landwerlin
2020-03-27 3:39 ` Dixit, Ashutosh
2020-03-27 23:11 Ashutosh Dixit
2020-03-27 23:16 Ashutosh Dixit
2020-03-30 8:23 ` Lionel Landwerlin
2020-03-31 5:47 ` Dixit, Ashutosh
2020-03-31 5:22 Ashutosh Dixit
2020-03-31 7:34 ` Lionel Landwerlin
2020-03-31 23:29 ` Dixit, Ashutosh
2020-03-31 23:14 Ashutosh Dixit
2020-04-01 6:57 ` Lionel Landwerlin
2020-04-01 7:43 ` Dixit, Ashutosh
2020-04-01 7:51 ` Lionel Landwerlin
2020-04-03 1:01 Ashutosh Dixit
2020-04-03 16:17 ` Chris Wilson
2020-04-03 17:45 ` Dixit, Ashutosh
2020-04-03 17:59 ` Chris Wilson
2020-04-08 23:42 Ashutosh Dixit
2020-04-13 22:05 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rpetwls.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).