From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BADDFC33CAF for ; Sun, 19 Jan 2020 20:19:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94DCB206ED for ; Sun, 19 Jan 2020 20:19:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94DCB206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 03A806E027; Sun, 19 Jan 2020 20:19:18 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id F34B26E027 for ; Sun, 19 Jan 2020 20:19:16 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jan 2020 12:19:16 -0800 X-IronPort-AV: E=Sophos;i="5.70,339,1574150400"; d="scan'208";a="219467175" Received: from thaismor-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.36.153]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jan 2020 12:19:14 -0800 From: Jani Nikula To: Vivek Kasireddy , intel-gfx@lists.freedesktop.org, Hans de Goede In-Reply-To: <20200118005848.20382-1-vivek.kasireddy@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200118005848.20382-1-vivek.kasireddy@intel.com> Date: Sun, 19 Jan 2020 22:20:00 +0200 Message-ID: <871rrvjj0v.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915/dsi: Ensure that the ACPI adapter lookup overrides the bus num X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 17 Jan 2020, Vivek Kasireddy wrote: > Remove the i2c_bus_num >= 0 check from the adapter lookup function > as this would prevent ACPI bus number override. This check was mainly > there to return early if the bus number has already been found but we > anyway return in the next line if the slave address does not match. Hans, could I trouble you to check this on your collection of BYT DSI devices please? BR, Jani. > > Fixes: 8cbf89db2941 ("drm/i915/dsi: Parse the I2C element from the VBT MIPI sequence block (v3)") > Cc: Hans de Goede > Cc: Nabendu Maiti > Cc: Matt Roper > Cc: Bob Paauwe > Cc: Jani Nikula > Signed-off-by: Vivek Kasireddy > --- > drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > index 6ec35d975bd7..04f953ba8f00 100644 > --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > @@ -394,8 +394,7 @@ static int i2c_adapter_lookup(struct acpi_resource *ares, void *data) > acpi_handle adapter_handle; > acpi_status status; > > - if (intel_dsi->i2c_bus_num >= 0 || > - !i2c_acpi_get_i2c_resource(ares, &sb)) > + if (!i2c_acpi_get_i2c_resource(ares, &sb)) > return 1; > > if (lookup->slave_addr != sb->slave_address) -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx