From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 3/3] drm/i915/ringbuffer: embed pipe_control into struct ring_buffer Date: Wed, 27 Apr 2011 16:24:25 -0700 Message-ID: <8739l3jn12.fsf@pollan.anholt.net> References: <1303937166-1756-1-git-send-email-daniel.vetter@ffwll.ch> <1303937166-1756-4-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0997163076==" Return-path: In-Reply-To: <1303937166-1756-4-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org --===============0997163076== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Wed, 27 Apr 2011 22:46:06 +0200, Daniel Vetter = wrote: > Pipecontrol is also required to implement gfdt flushing on gen6+. > And if we ever switch to pipecontrol based cache management in the > kernel, also required on gen4. I don't see the point in saving that > little bit of storge. >=20 > In the process make cleanup_pipe_control more robust and call it > unconditionally. >=20 > Signed-off-by: Daniel Vetter Nice. I thought about this when reviewing the first, then decided I didn't care enough. But if you've already cleaned it up, great! these two are: Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk24pakACgkQHUdvYGzw6vfBIQCfdUgwxEee5lAPfhBT9MCuhlaq 4j4AnRxOAMEhVn44e/t2Jd3qH0Bv1pXM =jEcr -----END PGP SIGNATURE----- --=-=-=-- --===============0997163076== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0997163076==--