From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4260FC10F27 for ; Tue, 10 Mar 2020 16:24:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2414020848 for ; Tue, 10 Mar 2020 16:24:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2414020848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2EB196E8AF; Tue, 10 Mar 2020 16:24:05 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id B4F7C6E8AF for ; Tue, 10 Mar 2020 16:24:03 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Mar 2020 09:24:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,537,1574150400"; d="scan'208";a="265668682" Received: from gaia.fi.intel.com ([10.237.72.192]) by fmsmga004.fm.intel.com with ESMTP; 10 Mar 2020 09:24:02 -0700 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id C4F8C5C1DD8; Tue, 10 Mar 2020 18:22:36 +0200 (EET) From: Mika Kuoppala To: Matt Roper , intel-gfx@lists.freedesktop.org In-Reply-To: <20200310004911.1723239-3-matthew.d.roper@intel.com> References: <20200310004911.1723239-1-matthew.d.roper@intel.com> <20200310004911.1723239-3-matthew.d.roper@intel.com> Date: Tue, 10 Mar 2020 18:22:36 +0200 Message-ID: <87a74o5gdv.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 2/7] drm/i915: Add Wa_1207131216:icl,ehl X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Matt Roper writes: > On gen11 the XY_FAST_COPY_BLT command has some size restrictions on its > usage. Although this instruction is mainly used by userspace, i915 also > uses it to copy object contents during some selftests, so let's ensure > the restrictions are followed. > > Bspec: 6544 > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gem/i915_gem_object_blt.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c > index 39b8a055d80a..e00792158f13 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c > @@ -196,6 +196,17 @@ int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj, > return err; > } > > +/* Wa_1209644611:icl,ehl */ > +static bool wa_1209644611_applies(struct drm_i915_private *i915, u32 size) > +{ > + u32 height = size >> PAGE_SHIFT; > + > + if (!IS_GEN(i915, 11)) > + return false; > + > + return height % 4 == 3 && height <= 8; The workaround description matches with this. However the original sighting was only for Y-Tiled surfaces. I asked for clarification. If we won't get one, we can play it safe and use this as it is. -Mika > +} > + > struct i915_vma *intel_emit_vma_copy_blt(struct intel_context *ce, > struct i915_vma *src, > struct i915_vma *dst) > @@ -237,7 +248,8 @@ struct i915_vma *intel_emit_vma_copy_blt(struct intel_context *ce, > size = min_t(u64, rem, block_size); > GEM_BUG_ON(size >> PAGE_SHIFT > S16_MAX); > > - if (INTEL_GEN(i915) >= 9) { > + if (INTEL_GEN(i915) >= 9 && > + !wa_1209644611_applies(i915, size)) { > *cmd++ = GEN9_XY_FAST_COPY_BLT_CMD | (10 - 2); > *cmd++ = BLT_DEPTH_32 | PAGE_SIZE; > *cmd++ = 0; > -- > 2.24.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx