From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CC16C3F68F for ; Tue, 11 Feb 2020 15:24:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09BD8214DB for ; Tue, 11 Feb 2020 15:24:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09BD8214DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9AF146EA94; Tue, 11 Feb 2020 15:24:26 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3789D6EA94 for ; Tue, 11 Feb 2020 15:24:25 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 07:24:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="280959101" Received: from gaia.fi.intel.com ([10.237.72.192]) by FMSMGA003.fm.intel.com with ESMTP; 11 Feb 2020 07:24:23 -0800 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id 249445C0D8C; Tue, 11 Feb 2020 17:23:24 +0200 (EET) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20200210205722.794180-3-chris@chris-wilson.co.uk> References: <20200210205722.794180-1-chris@chris-wilson.co.uk> <20200210205722.794180-3-chris@chris-wilson.co.uk> Date: Tue, 11 Feb 2020 17:23:24 +0200 Message-ID: <87a75p9mhf.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 3/7] drm/i915/selftests: Relax timeout for error-interrupt reset processing X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > We can not require that the system process a tasklet in reasonable time > (thanks be to ksoftirqd), but we can insist that having waited > sufficiently for the error interrupt to have been raised and having > kicked the tasklet, the reset has begun and the request will be marked > as in error (if not already completed). > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/gt/selftest_lrc.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c > index 8b7383f6d9b3..ccd4cd2c202d 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c > +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c > @@ -503,14 +503,21 @@ static int live_error_interrupt(void *arg) > } > > for (i = 0; i < ARRAY_SIZE(client); i++) { > - if (i915_request_wait(client[i], 0, HZ / 5) < 0) { > - pr_err("%s: %s request still executing!\n", > - engine->name, > - error_repr(p->error[i])); > + if (i915_request_wait(client[i], 0, HZ / 5) < 0) > + pr_debug("%s: %s request incomplete!\n", > + engine->name, > + error_repr(p->error[i])); > + > + if (!i915_request_started(client[i])) { > + pr_debug("%s: %s request not stated!\n", > + engine->name, > + error_repr(p->error[i])); > err = -ETIME; > goto out; > } > > + /* Kick the tasklet to process the error */ > + intel_engine_flush_submission(engine); This pattern of usage in selftests makes me want to add mb(); to intel_engine_flush_submission(), as it does not seem to do it implicitly. We want to flush submission and observe the effects, thus it seems like a good place. Not in a scope of this patch tho, Reviewed-by: Mika Kuoppala -Mika > if (client[i]->fence.error != p->error[i]) { > pr_err("%s: %s request completed with wrong error code: %d\n", > engine->name, > -- > 2.25.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx