From: Jani Nikula <jani.nikula@linux.intel.com>
To: Vipin Anand <vipin.anand@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 4/7] drm/i915/display: Set HDR Infoframe for HDR capable LSPCON devices
Date: Tue, 07 Apr 2020 15:37:51 +0300 [thread overview]
Message-ID: <87blo3jwtc.fsf@intel.com> (raw)
In-Reply-To: <87eeszjwui.fsf@intel.com>
On Tue, 07 Apr 2020, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Fri, 27 Mar 2020, Vipin Anand <vipin.anand@intel.com> wrote:
>> From: Uma Shankar <uma.shankar@intel.com>
>>
>> Send Dynamic Range and Mastering Infoframe (DRM for HDR metadata)
>> as SDP packet to LSPCON following the DP spec. LSPCON receives the
>> same and sends it to HDMI sink.
>>
>> v2: Suppressed some warnings. No functional change.
>>
>> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
>> ---
>> drivers/gpu/drm/drm_atomic_state_helper.c | 1 +
>> drivers/gpu/drm/drm_atomic_uapi.c | 1 +
>> drivers/gpu/drm/i915/display/intel_lspcon.h | 1 +
>> include/drm/drm_connector.h | 1 +
>> 4 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c
>> index 7cf3cf936547..7cf98c06f424 100644
>> --- a/drivers/gpu/drm/drm_atomic_state_helper.c
>> +++ b/drivers/gpu/drm/drm_atomic_state_helper.c
>> @@ -468,6 +468,7 @@ __drm_atomic_helper_connector_duplicate_state(struct drm_connector *connector,
>>
>> if (state->hdr_output_metadata)
>> drm_property_blob_get(state->hdr_output_metadata);
>> + state->hdr_metadata_changed = false;
>>
>> /* Don't copy over a writeback job, they are used only once */
>> state->writeback_job = NULL;
>> diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c
>> index a1e5e262bae2..4c520e0b9872 100644
>> --- a/drivers/gpu/drm/drm_atomic_uapi.c
>> +++ b/drivers/gpu/drm/drm_atomic_uapi.c
>> @@ -734,6 +734,7 @@ static int drm_atomic_connector_set_property(struct drm_connector *connector,
>> val,
>> sizeof(struct hdr_output_metadata), -1,
>> &replaced);
>> + state->hdr_metadata_changed |= replaced;
>> return ret;
>> } else if (property == config->aspect_ratio_property) {
>> state->picture_aspect_ratio = val;
>> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.h b/drivers/gpu/drm/i915/display/intel_lspcon.h
>> index b2051f236223..bc34124f532e 100644
>> --- a/drivers/gpu/drm/i915/display/intel_lspcon.h
>> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.h
>> @@ -38,4 +38,5 @@ void lspcon_drm_write_infoframe(struct intel_encoder *encoder,
>> const struct intel_crtc_state *crtc_state,
>> unsigned int type,
>> const void *frame, ssize_t len);
>> +
>
> Superfluous change.
>
> Patch needs to be posted to dri-devel.
Alternatively, the details need to be in intel specific states.
>
> BR,
> Jani.
>
>> #endif /* __INTEL_LSPCON_H__ */
>> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
>> index 221910948b37..28df268aa1a7 100644
>> --- a/include/drm/drm_connector.h
>> +++ b/include/drm/drm_connector.h
>> @@ -661,6 +661,7 @@ struct drm_connector_state {
>> * DRM blob property for HDR output metadata
>> */
>> struct drm_property_blob *hdr_output_metadata;
>> + u8 hdr_metadata_changed : 1;
>> };
>>
>> /**
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-04-07 12:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 5:23 [Intel-gfx] [PATCH 0/7] Enable HDR on Gen9 devices with lspcon hdr capability Vipin Anand
2020-03-27 5:23 ` [Intel-gfx] [PATCH 1/7] drm/i915/display: Add HDR Capability detection for LSPCON Vipin Anand
2020-04-07 12:44 ` Jani Nikula
2020-03-27 5:23 ` [Intel-gfx] [PATCH 2/7] drm/i915/display: Enable HDR on gen9 devices with MCA Lspcon Vipin Anand
2020-04-07 12:34 ` Jani Nikula
2020-03-27 5:23 ` [Intel-gfx] [PATCH 3/7] drm/i915/display: Attach HDR property for capable Gen9 devices Vipin Anand
2020-04-07 12:35 ` Jani Nikula
2020-03-27 5:23 ` [Intel-gfx] [PATCH 4/7] drm/i915/display: Set HDR Infoframe for HDR capable LSPCON devices Vipin Anand
2020-04-07 12:37 ` Jani Nikula
2020-04-07 12:37 ` Jani Nikula [this message]
2020-03-27 5:23 ` [Intel-gfx] [PATCH 5/7] drm/i915/display: Enable BT2020 for HDR on " Vipin Anand
2020-03-27 5:23 ` [Intel-gfx] [PATCH 6/7] drm/i915/display: Reduce blanking to support 4k60@10bpp for LSPCON Vipin Anand
2020-04-07 12:40 ` Jani Nikula
2020-03-27 5:23 ` [Intel-gfx] [PATCH 7/7] drm:i915:display: add checks for Gen9 devices with hdr capability Vipin Anand
2020-04-07 12:41 ` Jani Nikula
2020-03-27 5:44 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Enable HDR on Gen9 devices with lspcon " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blo3jwtc.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vipin.anand@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).