From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0884C2BB1D for ; Tue, 7 Apr 2020 12:37:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D37820719 for ; Tue, 7 Apr 2020 12:37:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D37820719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 391EF6E864; Tue, 7 Apr 2020 12:37:57 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 974DF6E864 for ; Tue, 7 Apr 2020 12:37:55 +0000 (UTC) IronPort-SDR: SnbFZteMZNm1oCXp5EIXWaOMPT1LRbf/bANdQiGovQgRrQ8PK/UvspHr1Lkha7HgVApFUSnKgN rWyF4IVToiNg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2020 05:37:55 -0700 IronPort-SDR: 7KFhF4p8nLh0ClGmwa5MNyJJ2NytbRuHB9/0EG3r9gs2SuQfbUQonivSnq1Q3a7rP/E9VKTcN/ R2CRl/Pg2Hhg== X-IronPort-AV: E=Sophos;i="5.72,354,1580803200"; d="scan'208";a="451204555" Received: from vogtstef-mobl3.ger.corp.intel.com (HELO localhost) ([10.249.40.153]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2020 05:37:53 -0700 From: Jani Nikula To: Vipin Anand , intel-gfx@lists.freedesktop.org In-Reply-To: <87eeszjwui.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200327052357.22269-1-vipin.anand@intel.com> <20200327052357.22269-5-vipin.anand@intel.com> <87eeszjwui.fsf@intel.com> Date: Tue, 07 Apr 2020 15:37:51 +0300 Message-ID: <87blo3jwtc.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 4/7] drm/i915/display: Set HDR Infoframe for HDR capable LSPCON devices X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 07 Apr 2020, Jani Nikula wrote: > On Fri, 27 Mar 2020, Vipin Anand wrote: >> From: Uma Shankar >> >> Send Dynamic Range and Mastering Infoframe (DRM for HDR metadata) >> as SDP packet to LSPCON following the DP spec. LSPCON receives the >> same and sends it to HDMI sink. >> >> v2: Suppressed some warnings. No functional change. >> >> Signed-off-by: Uma Shankar >> --- >> drivers/gpu/drm/drm_atomic_state_helper.c | 1 + >> drivers/gpu/drm/drm_atomic_uapi.c | 1 + >> drivers/gpu/drm/i915/display/intel_lspcon.h | 1 + >> include/drm/drm_connector.h | 1 + >> 4 files changed, 4 insertions(+) >> >> diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c >> index 7cf3cf936547..7cf98c06f424 100644 >> --- a/drivers/gpu/drm/drm_atomic_state_helper.c >> +++ b/drivers/gpu/drm/drm_atomic_state_helper.c >> @@ -468,6 +468,7 @@ __drm_atomic_helper_connector_duplicate_state(struct drm_connector *connector, >> >> if (state->hdr_output_metadata) >> drm_property_blob_get(state->hdr_output_metadata); >> + state->hdr_metadata_changed = false; >> >> /* Don't copy over a writeback job, they are used only once */ >> state->writeback_job = NULL; >> diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c >> index a1e5e262bae2..4c520e0b9872 100644 >> --- a/drivers/gpu/drm/drm_atomic_uapi.c >> +++ b/drivers/gpu/drm/drm_atomic_uapi.c >> @@ -734,6 +734,7 @@ static int drm_atomic_connector_set_property(struct drm_connector *connector, >> val, >> sizeof(struct hdr_output_metadata), -1, >> &replaced); >> + state->hdr_metadata_changed |= replaced; >> return ret; >> } else if (property == config->aspect_ratio_property) { >> state->picture_aspect_ratio = val; >> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.h b/drivers/gpu/drm/i915/display/intel_lspcon.h >> index b2051f236223..bc34124f532e 100644 >> --- a/drivers/gpu/drm/i915/display/intel_lspcon.h >> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.h >> @@ -38,4 +38,5 @@ void lspcon_drm_write_infoframe(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> unsigned int type, >> const void *frame, ssize_t len); >> + > > Superfluous change. > > Patch needs to be posted to dri-devel. Alternatively, the details need to be in intel specific states. > > BR, > Jani. > >> #endif /* __INTEL_LSPCON_H__ */ >> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h >> index 221910948b37..28df268aa1a7 100644 >> --- a/include/drm/drm_connector.h >> +++ b/include/drm/drm_connector.h >> @@ -661,6 +661,7 @@ struct drm_connector_state { >> * DRM blob property for HDR output metadata >> */ >> struct drm_property_blob *hdr_output_metadata; >> + u8 hdr_metadata_changed : 1; >> }; >> >> /** -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx