From: Eric Anholt <eric@anholt.net>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Protect mmaped buffers from casual eviction.
Date: Tue, 11 May 2010 09:38:36 -0700 [thread overview]
Message-ID: <87fx1yqtpv.fsf@pollan.anholt.net> (raw)
In-Reply-To: <1273593327-3051-1-git-send-email-chris@chris-wilson.co.uk>
[-- Attachment #1.1: Type: text/plain, Size: 1069 bytes --]
On Tue, 11 May 2010 16:55:27 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> By keeping buffers that are in use by the CPU, having been mmapped and
> moved to the CPU or GTT domain since their last rendering on a separate
> inactive list, prevents the first-pass eviction process from unbinding
> one of these buffers. Those buffers are evicted as normal during
> evict-everything so that the memory can be recovered under high pressure
> or a forced idle.
>
> References:
>
> Bug 20152 - [G45/GM965 UXA] cannot view JPG in firefox when running UXA
> https://bugs.freedesktop.org/show_bug.cgi?id=20152
>
> Bug 24369 - Hang when scrolling firefox page with window in front
> https://bugs.freedesktop.org/show_bug.cgi?id=24369
>
> Bug 15911 - Intermittent X crash (freeze)
> https://bugzilla.kernel.org/show_bug.cgi?id=15911
Couldn't this be more easily handled by the times where you would move
to the tail of mmap, just move to the tail of inactive? Since inactive
is "obj_priv->gtt_space && !obj_priv->active" already.
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2010-05-11 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 15:55 [PATCH] drm/i915: Protect mmaped buffers from casual eviction Chris Wilson
2010-05-11 16:38 ` Eric Anholt [this message]
2010-05-11 22:57 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fx1yqtpv.fsf@pollan.anholt.net \
--to=eric@anholt.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).